Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2101003002: Add functionality to explicitly set SNI in the QUIC test client (Closed)

Created:
4 years, 5 months ago by Ryan Hamilton
Modified:
4 years, 5 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@125459408
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add functionality to explicitly set SNI in the QUIC test client The QUIC test client currently sets SNI based on the request URL which triggers the client to connect. This is problematic for tests which want to set the SNI to something else (in this case: SSL compartments tests). This change makes it possible for such tests to explicitly override this setting. Merge internal change: 125561343 BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -3 lines) Patch
M net/tools/quic/test_tools/quic_test_client.h View 2 chunks +12 lines, -0 lines 0 comments Download
M net/tools/quic/test_tools/quic_test_client.cc View 1 chunk +8 lines, -3 lines 0 comments Download

Depends on Patchset:

Issue 2099123003 Patch 1

Dependent Patchsets:

Issue 2102723002 Patch 1

Messages

Total messages: 3 (1 generated)
Ryan Hamilton
4 years, 5 months ago (2016-06-27 21:09:43 UTC) #2
ramant (doing other things)
4 years, 5 months ago (2016-06-27 22:13:53 UTC) #3 
lgtm

Powered by Google App Engine
This is Rietveld 408576698