Issue 2099313003: Change QuicBufferedPacketStore to store QuicReceivedPackets instead of QuicEncrypterPackets, since …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2099313003: Change QuicBufferedPacketStore to store QuicReceivedPackets instead of QuicEncrypterPackets, since … (Closed)

Created:
4 years, 5 months ago by Ryan Hamilton

Modified:
4 years, 5 months ago

Reviewers:
ramant (doing other things)

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@125727775

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Change QuicBufferedPacketStore to store QuicReceivedPackets instead of QuicEncrypterPackets, since that is what the Dispatcher uses. Also to take a const clock. Add a method for checking if packets are buffered for a connection ID. Also clang-format these files since they appear to be incorrectly styled. n/a - currently unused code Merge internal change: 125777729 BUG=

Patch Set 1 #

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+41 lines, -19 lines)			Patch
M	net/quic/quic_buffered_packet_store.h	View	5 chunks	+8 lines, -5 lines	0 comments	Download
M	net/quic/quic_buffered_packet_store.cc	View	6 chunks	+13 lines, -6 lines	0 comments	Download
M	net/quic/quic_buffered_packet_store_test.cc	View	7 chunks	+20 lines, -8 lines	0 comments	Download

Depends on Patchset:

Issue 2101623003 Patch 1

Dependent Patchsets:

Issue 2107943002 Patch 1

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

lgtm

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages