Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(562)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2102723002: Add extra logging when QuicFramer's AppendStopWaiting fails to serialize. (Closed)

Created:
4 years, 5 months ago by Ryan Hamilton
Modified:
4 years, 5 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@125561343
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add extra logging when QuicFramer's AppendStopWaiting fails to serialize. Merge internal change: 125563155

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M net/quic/quic_framer.cc View 1 chunk +4 lines, -2 lines 2 comments Download

Depends on Patchset:

Issue 2101003002 Patch 1

Dependent Patchsets:

Issue 2102733002 Patch 1

Messages

Total messages: 5 (1 generated)
Ryan Hamilton
4 years, 5 months ago (2016-06-27 21:10:39 UTC) #2
ramant (doing other things)
lgtm https://codereview.chromium.org/2102723002/diff/1/net/quic/quic_framer.cc File net/quic/quic_framer.cc (right): https://codereview.chromium.org/2102723002/diff/1/net/quic/quic_framer.cc#newcode2502 net/quic/quic_framer.cc:2502: << "least_unacked:" << frame.least_unacked overly nit: "least_unacked:" -> ...
4 years, 5 months ago (2016-06-27 22:23:54 UTC) #3
Ryan Hamilton
https://codereview.chromium.org/2102723002/diff/1/net/quic/quic_framer.cc File net/quic/quic_framer.cc (right): https://codereview.chromium.org/2102723002/diff/1/net/quic/quic_framer.cc#newcode2502 net/quic/quic_framer.cc:2502: << "least_unacked:" << frame.least_unacked On 2016/06/27 22:23:54, ramant wrote: ...
4 years, 5 months ago (2016-06-27 22:35:09 UTC) #4
ramant (doing other things)
4 years, 5 months ago (2016-06-28 23:12:16 UTC) #5 
lgtm

Powered by Google App Engine
This is Rietveld 408576698