Landing recent QUIC changes until 6/24/2016 14:00 UTC

net/quic/quic_spdy_stream_test.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/quic/quic_spdy_stream.h"
 
 #include <memory>
 #include <utility>
 
 #include "base/strings/string_number_conversions.h"
@@ skipping 181 matching lines @@
 }
 
 TEST_P(QuicSpdyStreamTest, ParseHeaderStatusCode) {
   // A valid status code should be 3-digit integer. The first digit should be in
   // the range of [1, 5]. All the others are invalid.
   Initialize(kShouldProcessData);
   int status_code = 0;
 
   // Valid status code.
   headers_.ReplaceOrAppendHeader(":status", "404");
-  EXPECT_TRUE(stream_->ParseHeaderStatusCode(&headers_, &status_code));
+  EXPECT_TRUE(stream_->ParseHeaderStatusCode(headers_, &status_code));
   EXPECT_EQ(404, status_code);
 
   // Invalid status codes.
   headers_.ReplaceOrAppendHeader(":status", "010");
-  EXPECT_FALSE(stream_->ParseHeaderStatusCode(&headers_, &status_code));
+  EXPECT_FALSE(stream_->ParseHeaderStatusCode(headers_, &status_code));
 
   headers_.ReplaceOrAppendHeader(":status", "600");
-  EXPECT_FALSE(stream_->ParseHeaderStatusCode(&headers_, &status_code));
+  EXPECT_FALSE(stream_->ParseHeaderStatusCode(headers_, &status_code));
 
   headers_.ReplaceOrAppendHeader(":status", "200 ok");
-  EXPECT_FALSE(stream_->ParseHeaderStatusCode(&headers_, &status_code));
+  EXPECT_FALSE(stream_->ParseHeaderStatusCode(headers_, &status_code));
 
   headers_.ReplaceOrAppendHeader(":status", "2000");
-  EXPECT_FALSE(stream_->ParseHeaderStatusCode(&headers_, &status_code));
+  EXPECT_FALSE(stream_->ParseHeaderStatusCode(headers_, &status_code));
 
   headers_.ReplaceOrAppendHeader(":status", "+200");
-  EXPECT_FALSE(stream_->ParseHeaderStatusCode(&headers_, &status_code));
+  EXPECT_FALSE(stream_->ParseHeaderStatusCode(headers_, &status_code));
 
   headers_.ReplaceOrAppendHeader(":status", "+20");
-  EXPECT_FALSE(stream_->ParseHeaderStatusCode(&headers_, &status_code));
+  EXPECT_FALSE(stream_->ParseHeaderStatusCode(headers_, &status_code));
 
   // Leading or trailing spaces are also invalid.
   headers_.ReplaceOrAppendHeader(":status", " 200");
-  EXPECT_FALSE(stream_->ParseHeaderStatusCode(&headers_, &status_code));
+  EXPECT_FALSE(stream_->ParseHeaderStatusCode(headers_, &status_code));
 
   headers_.ReplaceOrAppendHeader(":status", "200 ");
-  EXPECT_FALSE(stream_->ParseHeaderStatusCode(&headers_, &status_code));
+  EXPECT_FALSE(stream_->ParseHeaderStatusCode(headers_, &status_code));
 
   headers_.ReplaceOrAppendHeader(":status", " 200 ");
-  EXPECT_FALSE(stream_->ParseHeaderStatusCode(&headers_, &status_code));
+  EXPECT_FALSE(stream_->ParseHeaderStatusCode(headers_, &status_code));
 
   headers_.ReplaceOrAppendHeader(":status", "  ");
-  EXPECT_FALSE(stream_->ParseHeaderStatusCode(&headers_, &status_code));
+  EXPECT_FALSE(stream_->ParseHeaderStatusCode(headers_, &status_code));
 }
 
 TEST_P(QuicSpdyStreamTest, MarkHeadersConsumed) {
   Initialize(kShouldProcessData);
 
   string headers = SpdyUtils::SerializeUncompressedHeaders(headers_);
   string body = "this is the body";
 
   stream_->OnStreamHeaders(headers);
   stream_->OnStreamHeadersComplete(false, headers.size());
@@ skipping 747 matching lines @@
 
   // Writing Trailers should fail, as the FIN has already been sent.
   // populated with the number of body bytes written.
   EXPECT_DFATAL(stream_->WriteTrailers(SpdyHeaderBlock(), nullptr),
                 "Trailers cannot be sent after a FIN");
 }
 
 }  // namespace
 }  // namespace test
 }  // namespace net