[ic] Don't pass receiver and name to LoadGlobalIC.

[ic] Don't pass receiver and name to LoadGlobalIC.

The global object can be loaded from the native context and the name can be loaded in the type feedback metadata.

BUG=chromium:576312
Committed: https://crrev.com/cd18075df73e177d5aecdda1eba58eec7f85977c
Cr-Commit-Position: refs/heads/master@{#37278}

[Igor Sheludko, 2016-06-23 21:39:38]

Patchset #1 (id:1) has been deleted

[Igor Sheludko, 2016-06-23 21:39:49]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-23 21:39:57]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2096653003/20001

[commit-bot: I haz the power, 2016-06-23 22:08:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-23 22:08:16]

Dry run: This issue passed the CQ dry run.

[Igor Sheludko, 2016-06-23 22:15:05]

Description was changed from

==========
[ic] Don't pass receiver and name to LoadGlobalIC.

BUG=chromium:576312
==========

to

==========
[ic] Don't pass receiver and name to LoadGlobalIC.

The global object can be loaded from the native context and the name can be
loaded in the type feedback metadata.

BUG=chromium:576312
==========

[Igor Sheludko, 2016-06-23 22:15:51]

ishell@chromium.org changed reviewers:
+ bmeurer@chromium.org

[Igor Sheludko, 2016-06-23 22:15:52]

PTAL

[rmcilroy, 2016-06-23 22:28:26]

rmcilroy@chromium.org changed reviewers:
+ rmcilroy@chromium.org

[rmcilroy, 2016-06-23 22:28:27]

https://codereview.chromium.org/2096653003/diff/20001/src/interpreter/interpr...
File src/interpreter/interpreter.cc (left):

https://codereview.chromium.org/2096653003/diff/20001/src/interpreter/interpr...
src/interpreter/interpreter.cc:401: Node* name = __
LoadConstantPoolEntry(constant_index);
Can you remove the operand from this bytecode too if it is no longer needed.

[Benedikt Meurer, 2016-06-24 03:31:10]

Wohoo, nice. LGTM

[Igor Sheludko, 2016-06-24 07:25:36]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-24 07:25:45]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2096653003/40001

[Igor Sheludko, 2016-06-24 07:26:16]

Updated Ld*Global bytecodes. PTAL.

https://codereview.chromium.org/2096653003/diff/20001/src/interpreter/interpr...
File src/interpreter/interpreter.cc (left):

https://codereview.chromium.org/2096653003/diff/20001/src/interpreter/interpr...
src/interpreter/interpreter.cc:401: Node* name = __
LoadConstantPoolEntry(constant_index);
On 2016/06/23 22:28:27, rmcilroy wrote:
> Can you remove the operand from this bytecode too if it is no longer needed.

Done.

[rmcilroy, 2016-06-24 07:43:08]

https://codereview.chromium.org/2096653003/diff/40001/src/interpreter/bytecod...
File src/interpreter/bytecode-array-builder.cc (right):

https://codereview.chromium.org/2096653003/diff/40001/src/interpreter/bytecod...
src/interpreter/bytecode-array-builder.cc:242: const Handle<String> name, int
feedback_slot, TypeofMode typeof_mode) {
No need to pass the name in here from the bytecode_generator. Please update that
too.

[Igor Sheludko, 2016-06-24 07:55:35]

https://codereview.chromium.org/2096653003/diff/40001/src/interpreter/bytecod...
File src/interpreter/bytecode-array-builder.cc (right):

https://codereview.chromium.org/2096653003/diff/40001/src/interpreter/bytecod...
src/interpreter/bytecode-array-builder.cc:242: const Handle<String> name, int
feedback_slot, TypeofMode typeof_mode) {
On 2016/06/24 07:43:08, rmcilroy wrote:
> No need to pass the name in here from the bytecode_generator. Please update
that
> too.

Done.

[Igor Sheludko, 2016-06-24 07:56:14]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-24 07:56:25]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2096653003/80001

[rmcilroy, 2016-06-24 08:09:03]

LGTM, thanks!

[commit-bot: I haz the power, 2016-06-24 08:21:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-24 08:21:14]

Dry run: This issue passed the CQ dry run.

[Igor Sheludko, 2016-06-27 08:13:49]

The CQ bit was checked by ishell@chromium.org

[Igor Sheludko, 2016-06-27 08:13:50]

The patchset sent to the CQ was uploaded after l-g-t-m from bmeurer@chromium.org
Link to the patchset: https://codereview.chromium.org/2096653003/#ps80001
(title: "Removed name parameter.")

[commit-bot: I haz the power, 2016-06-27 08:13:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-27 08:42:48]

Description was changed from

==========
[ic] Don't pass receiver and name to LoadGlobalIC.

The global object can be loaded from the native context and the name can be
loaded in the type feedback metadata.

BUG=chromium:576312
==========

to

==========
[ic] Don't pass receiver and name to LoadGlobalIC.

The global object can be loaded from the native context and the name can be
loaded in the type feedback metadata.

BUG=chromium:576312
==========

[commit-bot: I haz the power, 2016-06-27 08:42:49]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2016-06-27 08:45:00]

Description was changed from

==========
[ic] Don't pass receiver and name to LoadGlobalIC.

The global object can be loaded from the native context and the name can be
loaded in the type feedback metadata.

BUG=chromium:576312
==========

to

==========
[ic] Don't pass receiver and name to LoadGlobalIC.

The global object can be loaded from the native context and the name can be
loaded in the type feedback metadata.

BUG=chromium:576312

Committed: https://crrev.com/cd18075df73e177d5aecdda1eba58eec7f85977c
Cr-Commit-Position: refs/heads/master@{#37278}
==========

[commit-bot: I haz the power, 2016-06-27 08:45:02]

Patchset 4 (id:??) landed as
https://crrev.com/cd18075df73e177d5aecdda1eba58eec7f85977c
Cr-Commit-Position: refs/heads/master@{#37278}