Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Side by Side Diff: src/full-codegen/arm/full-codegen-arm.cc

Issue 2096653003: [ic] Don't pass receiver and name to LoadGlobalIC. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@store-name-in-metavector
Patch Set: Removed name parameter. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/crankshaft/x87/lithium-x87.cc ('k') | src/full-codegen/arm64/full-codegen-arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_ARM 5 #if V8_TARGET_ARCH_ARM
6 6
7 #include "src/ast/scopes.h" 7 #include "src/ast/scopes.h"
8 #include "src/code-factory.h" 8 #include "src/code-factory.h"
9 #include "src/code-stubs.h" 9 #include "src/code-stubs.h"
10 #include "src/codegen.h" 10 #include "src/codegen.h"
(...skipping 1276 matching lines...) Expand 10 before | Expand all | Expand 10 after
1287 __ push(r0); 1287 __ push(r0);
1288 __ CallRuntime(Runtime::kThrowReferenceError); 1288 __ CallRuntime(Runtime::kThrowReferenceError);
1289 } 1289 }
1290 __ jmp(done); 1290 __ jmp(done);
1291 } 1291 }
1292 } 1292 }
1293 1293
1294 1294
1295 void FullCodeGenerator::EmitGlobalVariableLoad(VariableProxy* proxy, 1295 void FullCodeGenerator::EmitGlobalVariableLoad(VariableProxy* proxy,
1296 TypeofMode typeof_mode) { 1296 TypeofMode typeof_mode) {
1297 #ifdef DEBUG
1297 Variable* var = proxy->var(); 1298 Variable* var = proxy->var();
1298 DCHECK(var->IsUnallocatedOrGlobalSlot() || 1299 DCHECK(var->IsUnallocatedOrGlobalSlot() ||
1299 (var->IsLookupSlot() && var->mode() == DYNAMIC_GLOBAL)); 1300 (var->IsLookupSlot() && var->mode() == DYNAMIC_GLOBAL));
1300 __ LoadGlobalObject(LoadDescriptor::ReceiverRegister()); 1301 #endif
1301 __ mov(LoadDescriptor::NameRegister(), Operand(var->name())); 1302 __ mov(LoadGlobalDescriptor::SlotRegister(),
1302 __ mov(LoadDescriptor::SlotRegister(),
1303 Operand(SmiFromSlot(proxy->VariableFeedbackSlot()))); 1303 Operand(SmiFromSlot(proxy->VariableFeedbackSlot())));
1304 CallLoadGlobalIC(typeof_mode); 1304 CallLoadGlobalIC(typeof_mode);
1305 } 1305 }
1306 1306
1307 1307
1308 void FullCodeGenerator::EmitVariableLoad(VariableProxy* proxy, 1308 void FullCodeGenerator::EmitVariableLoad(VariableProxy* proxy,
1309 TypeofMode typeof_mode) { 1309 TypeofMode typeof_mode) {
1310 // Record position before possible IC call. 1310 // Record position before possible IC call.
1311 SetExpressionPosition(proxy); 1311 SetExpressionPosition(proxy);
1312 PrepareForBailoutForId(proxy->BeforeId(), BailoutState::NO_REGISTERS); 1312 PrepareForBailoutForId(proxy->BeforeId(), BailoutState::NO_REGISTERS);
(...skipping 2547 matching lines...) Expand 10 before | Expand all | Expand 10 after
3860 DCHECK(interrupt_address == 3860 DCHECK(interrupt_address ==
3861 isolate->builtins()->OnStackReplacement()->entry()); 3861 isolate->builtins()->OnStackReplacement()->entry());
3862 return ON_STACK_REPLACEMENT; 3862 return ON_STACK_REPLACEMENT;
3863 } 3863 }
3864 3864
3865 3865
3866 } // namespace internal 3866 } // namespace internal
3867 } // namespace v8 3867 } // namespace v8
3868 3868
3869 #endif // V8_TARGET_ARCH_ARM 3869 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « src/crankshaft/x87/lithium-x87.cc ('k') | src/full-codegen/arm64/full-codegen-arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698