test/unittests/interpreter/bytecode-array-iterator-unittest.cc - Issue 2096653003: [ic] Don't pass receiver and name to LoadGlobalIC.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/unittests/interpreter/bytecode-array-iterator-unittest.cc

Issue 2096653003: [ic] Don't pass receiver and name to LoadGlobalIC. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@store-name-in-metavector

Patch Set: Removed name parameter. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « test/unittests/interpreter/bytecode-array-builder-unittest.cc ('k') | test/unittests/interpreter/bytecode-peephole-optimizer-unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: test/unittests/interpreter/bytecode-array-iterator-unittest.cc

diff --git a/test/unittests/interpreter/bytecode-array-iterator-unittest.cc b/test/unittests/interpreter/bytecode-array-iterator-unittest.cc

index f24c818c3b51eb839a60d1288931aba3d4242cae..6b7374ec1b2cf3e1c7a473054e72b174df48ae2c 100644

--- a/test/unittests/interpreter/bytecode-array-iterator-unittest.cc

+++ b/test/unittests/interpreter/bytecode-array-iterator-unittest.cc

@@ -56,7 +56,7 @@ TEST_F(BytecodeArrayIteratorTest, IteratesBytecodeArray) {

.ForInPrepare(reg_0)

.CallRuntime(Runtime::kLoadIC_Miss, reg_0, 1)

.Debugger()

- .LoadGlobal(name, 0x10000000, TypeofMode::NOT_INSIDE_TYPEOF)

+ .LoadGlobal(0x10000000, TypeofMode::NOT_INSIDE_TYPEOF)

.Return();

// Test iterator sees the expected output from the builder.

@@ -246,8 +246,8 @@ TEST_F(BytecodeArrayIteratorTest, IteratesBytecodeArray) {

CHECK_EQ(iterator.current_bytecode(), Bytecode::kLdaGlobal);

CHECK_EQ(iterator.current_offset(), offset);

CHECK_EQ(iterator.current_operand_scale(), OperandScale::kQuadruple);

- CHECK_EQ(iterator.current_bytecode_size(), 10);

- CHECK_EQ(iterator.GetIndexOperand(1), 0x10000000);

+ CHECK_EQ(iterator.current_bytecode_size(), 6);

+ CHECK_EQ(iterator.GetIndexOperand(0), 0x10000000);

offset += Bytecodes::Size(Bytecode::kLdaGlobal, OperandScale::kQuadruple) +

kPrefixByteSize;

iterator.Advance();