Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Side by Side Diff: src/full-codegen/mips64/full-codegen-mips64.cc

Issue 2096653003: [ic] Don't pass receiver and name to LoadGlobalIC. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@store-name-in-metavector
Patch Set: Removed name parameter. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/full-codegen/mips/full-codegen-mips.cc ('k') | src/full-codegen/ppc/full-codegen-ppc.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_MIPS64 5 #if V8_TARGET_ARCH_MIPS64
6 6
7 // Note on Mips implementation: 7 // Note on Mips implementation:
8 // 8 //
9 // The result_register() for mips is the 'v0' register, which is defined 9 // The result_register() for mips is the 'v0' register, which is defined
10 // by the ABI to contain function return values. However, the first 10 // by the ABI to contain function return values. However, the first
(...skipping 1271 matching lines...) Expand 10 before | Expand all | Expand 10 after
1282 __ push(a0); 1282 __ push(a0);
1283 __ CallRuntime(Runtime::kThrowReferenceError); 1283 __ CallRuntime(Runtime::kThrowReferenceError);
1284 } 1284 }
1285 __ Branch(done); 1285 __ Branch(done);
1286 } 1286 }
1287 } 1287 }
1288 1288
1289 1289
1290 void FullCodeGenerator::EmitGlobalVariableLoad(VariableProxy* proxy, 1290 void FullCodeGenerator::EmitGlobalVariableLoad(VariableProxy* proxy,
1291 TypeofMode typeof_mode) { 1291 TypeofMode typeof_mode) {
1292 #ifdef DEBUG
1292 Variable* var = proxy->var(); 1293 Variable* var = proxy->var();
1293 DCHECK(var->IsUnallocatedOrGlobalSlot() || 1294 DCHECK(var->IsUnallocatedOrGlobalSlot() ||
1294 (var->IsLookupSlot() && var->mode() == DYNAMIC_GLOBAL)); 1295 (var->IsLookupSlot() && var->mode() == DYNAMIC_GLOBAL));
1295 __ LoadGlobalObject(LoadDescriptor::ReceiverRegister()); 1296 #endif
1296 __ li(LoadDescriptor::NameRegister(), Operand(var->name())); 1297 __ li(LoadGlobalDescriptor::SlotRegister(),
1297 __ li(LoadDescriptor::SlotRegister(),
1298 Operand(SmiFromSlot(proxy->VariableFeedbackSlot()))); 1298 Operand(SmiFromSlot(proxy->VariableFeedbackSlot())));
1299 CallLoadGlobalIC(typeof_mode); 1299 CallLoadGlobalIC(typeof_mode);
1300 } 1300 }
1301 1301
1302 1302
1303 void FullCodeGenerator::EmitVariableLoad(VariableProxy* proxy, 1303 void FullCodeGenerator::EmitVariableLoad(VariableProxy* proxy,
1304 TypeofMode typeof_mode) { 1304 TypeofMode typeof_mode) {
1305 // Record position before possible IC call. 1305 // Record position before possible IC call.
1306 SetExpressionPosition(proxy); 1306 SetExpressionPosition(proxy);
1307 PrepareForBailoutForId(proxy->BeforeId(), BailoutState::NO_REGISTERS); 1307 PrepareForBailoutForId(proxy->BeforeId(), BailoutState::NO_REGISTERS);
(...skipping 2503 matching lines...) Expand 10 before | Expand all | Expand 10 after
3811 reinterpret_cast<uint64_t>( 3811 reinterpret_cast<uint64_t>(
3812 isolate->builtins()->OnStackReplacement()->entry())); 3812 isolate->builtins()->OnStackReplacement()->entry()));
3813 return ON_STACK_REPLACEMENT; 3813 return ON_STACK_REPLACEMENT;
3814 } 3814 }
3815 3815
3816 3816
3817 } // namespace internal 3817 } // namespace internal
3818 } // namespace v8 3818 } // namespace v8
3819 3819
3820 #endif // V8_TARGET_ARCH_MIPS64 3820 #endif // V8_TARGET_ARCH_MIPS64
OLDNEW
« no previous file with comments | « src/full-codegen/mips/full-codegen-mips.cc ('k') | src/full-codegen/ppc/full-codegen-ppc.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698