[ic] Let LoadGlobalIC load the variable name from TypeFeedbackMetadata.

[ic] Let LoadGlobalIC load the variable name from TypeFeedbackMetadata.

This simplifies the calling convention of LoadGlobalIC.

Currently we do a linear search to get the name but I'll address this in a follow-up CL.

BUG=chromium:576312
TBR=rossberg@chromium.org

Committed: https://crrev.com/cfcb3597fd04dae6063453b3e362d18c627237a5
Cr-Commit-Position: refs/heads/master@{#37253}

[Igor Sheludko, 2016-06-23 16:25:23]

Description was changed from

==========
[ic] Let LoadGlobalIC load the variable name from TypeFeedbackMetadata.

BUG=chromium:576312
==========

to

==========
[ic] Let LoadGlobalIC load the variable name from TypeFeedbackMetadata.

Currently it is necessary to iterate the metadata to get the name but I'll
address this in a follow-up CL.

BUG=chromium:576312
==========

[Igor Sheludko, 2016-06-23 16:26:47]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-23 16:26:59]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2084913006/1

[Igor Sheludko, 2016-06-23 16:30:26]

Description was changed from

==========
[ic] Let LoadGlobalIC load the variable name from TypeFeedbackMetadata.

Currently it is necessary to iterate the metadata to get the name but I'll
address this in a follow-up CL.

BUG=chromium:576312
==========

to

==========
[ic] Let LoadGlobalIC load the variable name from TypeFeedbackMetadata.

This simplifies the calling convention of LoadGlobalIC.

Currently it is necessary to iterate the metadata to get the name but I'll
address this in a follow-up CL.

BUG=chromium:576312
==========

[Igor Sheludko, 2016-06-23 16:30:55]

ishell@chromium.org changed reviewers:
+ mvstanton@chromium.org, verwaest@chromium.org

[Igor Sheludko, 2016-06-23 16:30:55]

Michael, PTAL.
Toon, FYI.

[Igor Sheludko, 2016-06-23 22:22:08]

Patchset #1 (id:1) has been deleted

[Igor Sheludko, 2016-06-23 22:22:35]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-23 22:22:44]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2084913006/20001

[commit-bot: I haz the power, 2016-06-23 22:49:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-23 22:49:22]

Dry run: This issue passed the CQ dry run.

[mvstanton, 2016-06-24 10:04:12]

LGTM, modulo a few comments.

Really cool!

https://codereview.chromium.org/2084913006/diff/20001/src/type-feedback-vecto...
File src/type-feedback-vector.cc (right):

https://codereview.chromium.org/2084913006/diff/20001/src/type-feedback-vecto...
src/type-feedback-vector.cc:121: Handle<FixedArray> tmp =
maybe call this newNames.

https://codereview.chromium.org/2084913006/diff/20001/src/type-feedback-vecto...
src/type-feedback-vector.cc:122: factory->NewFixedArray(length == 0 ? 16 :
length * 2);
Did you do anything like figure out average # of global loads to decide that a
default names table of size 16 is best? If it's just a guess in the dark I'd
rather be a little more conservative and go for size 8, WDYT?

[Igor Sheludko, 2016-06-24 13:30:50]

https://codereview.chromium.org/2084913006/diff/20001/src/type-feedback-vecto...
File src/type-feedback-vector.cc (right):

https://codereview.chromium.org/2084913006/diff/20001/src/type-feedback-vecto...
src/type-feedback-vector.cc:121: Handle<FixedArray> tmp =
On 2016/06/24 10:04:11, mvstanton wrote:
> maybe call this newNames.

Done.

https://codereview.chromium.org/2084913006/diff/20001/src/type-feedback-vecto...
src/type-feedback-vector.cc:122: factory->NewFixedArray(length == 0 ? 16 :
length * 2);
On 2016/06/24 10:04:12, mvstanton wrote:
> Did you do anything like figure out average # of global loads to decide that a
> default names table of size 16 is best? If it's just a guess in the dark I'd
> rather be a little more conservative and go for size 8, WDYT?

Good point! Although we don't waste space in the end (we shrink the resulting
array) but we can definitely actually allocate this array only once as we can
take the number of names from the spec!

[Igor Sheludko, 2016-06-24 13:30:55]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-24 13:31:06]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2084913006/40001

[Igor Sheludko, 2016-06-24 13:50:36]

Description was changed from

==========
[ic] Let LoadGlobalIC load the variable name from TypeFeedbackMetadata.

This simplifies the calling convention of LoadGlobalIC.

Currently it is necessary to iterate the metadata to get the name but I'll
address this in a follow-up CL.

BUG=chromium:576312
==========

to

==========
[ic] Let LoadGlobalIC load the variable name from TypeFeedbackMetadata.

This simplifies the calling convention of LoadGlobalIC.

Currently we do a linear search to get the name but I'll address this in a
follow-up CL.

BUG=chromium:576312
==========

[commit-bot: I haz the power, 2016-06-24 13:58:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-24 13:58:10]

Dry run: This issue passed the CQ dry run.

[Igor Sheludko, 2016-06-24 14:00:34]

The CQ bit was checked by ishell@chromium.org

[Igor Sheludko, 2016-06-24 14:00:35]

The patchset sent to the CQ was uploaded after l-g-t-m from
mvstanton@chromium.org
Link to the patchset: https://codereview.chromium.org/2084913006/#ps40001
(title: "Addressing comments")

[commit-bot: I haz the power, 2016-06-24 14:00:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2084913006/40001

[commit-bot: I haz the power, 2016-06-24 14:04:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-24 14:04:22]

Try jobs failed on following builders:
  v8_presubmit on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/17970)

[Igor Sheludko, 2016-06-24 14:06:01]

Description was changed from

==========
[ic] Let LoadGlobalIC load the variable name from TypeFeedbackMetadata.

This simplifies the calling convention of LoadGlobalIC.

Currently we do a linear search to get the name but I'll address this in a
follow-up CL.

BUG=chromium:576312
==========

to

==========
[ic] Let LoadGlobalIC load the variable name from TypeFeedbackMetadata.

This simplifies the calling convention of LoadGlobalIC.

Currently we do a linear search to get the name but I'll address this in a
follow-up CL.

BUG=chromium:576312
TBR=rossberg@chromium.org
==========

[Igor Sheludko, 2016-06-24 14:06:05]

The CQ bit was checked by ishell@chromium.org

[commit-bot: I haz the power, 2016-06-24 14:06:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2084913006/40001

[commit-bot: I haz the power, 2016-06-24 14:08:18]

Description was changed from

==========
[ic] Let LoadGlobalIC load the variable name from TypeFeedbackMetadata.

This simplifies the calling convention of LoadGlobalIC.

Currently we do a linear search to get the name but I'll address this in a
follow-up CL.

BUG=chromium:576312
TBR=rossberg@chromium.org
==========

to

==========
[ic] Let LoadGlobalIC load the variable name from TypeFeedbackMetadata.

This simplifies the calling convention of LoadGlobalIC.

Currently we do a linear search to get the name but I'll address this in a
follow-up CL.

BUG=chromium:576312
TBR=rossberg@chromium.org
==========

[commit-bot: I haz the power, 2016-06-24 14:08:19]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-06-24 14:09:04]

Description was changed from

==========
[ic] Let LoadGlobalIC load the variable name from TypeFeedbackMetadata.

This simplifies the calling convention of LoadGlobalIC.

Currently we do a linear search to get the name but I'll address this in a
follow-up CL.

BUG=chromium:576312
TBR=rossberg@chromium.org
==========

to

==========
[ic] Let LoadGlobalIC load the variable name from TypeFeedbackMetadata.

This simplifies the calling convention of LoadGlobalIC.

Currently we do a linear search to get the name but I'll address this in a
follow-up CL.

BUG=chromium:576312
TBR=rossberg@chromium.org

Committed: https://crrev.com/cfcb3597fd04dae6063453b3e362d18c627237a5
Cr-Commit-Position: refs/heads/master@{#37253}
==========

[commit-bot: I haz the power, 2016-06-24 14:09:05]

Patchset 2 (id:??) landed as
https://crrev.com/cfcb3597fd04dae6063453b3e362d18c627237a5
Cr-Commit-Position: refs/heads/master@{#37253}