Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Side by Side Diff: src/crankshaft/ia32/lithium-codegen-ia32.cc

Issue 2096653003: [ic] Don't pass receiver and name to LoadGlobalIC. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@store-name-in-metavector
Patch Set: Removed name parameter. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/crankshaft/hydrogen-instructions.h ('k') | src/crankshaft/ia32/lithium-ia32.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_IA32 5 #if V8_TARGET_ARCH_IA32
6 6
7 #include "src/crankshaft/ia32/lithium-codegen-ia32.h" 7 #include "src/crankshaft/ia32/lithium-codegen-ia32.h"
8 8
9 #include "src/base/bits.h" 9 #include "src/base/bits.h"
10 #include "src/code-factory.h" 10 #include "src/code-factory.h"
(...skipping 2398 matching lines...) Expand 10 before | Expand all | Expand 10 after
2409 Handle<TypeFeedbackVector> vector = instr->hydrogen()->feedback_vector(); 2409 Handle<TypeFeedbackVector> vector = instr->hydrogen()->feedback_vector();
2410 __ mov(vector_register, vector); 2410 __ mov(vector_register, vector);
2411 FeedbackVectorSlot slot = instr->hydrogen()->slot(); 2411 FeedbackVectorSlot slot = instr->hydrogen()->slot();
2412 int index = vector->GetIndex(slot); 2412 int index = vector->GetIndex(slot);
2413 __ mov(slot_register, Immediate(Smi::FromInt(index))); 2413 __ mov(slot_register, Immediate(Smi::FromInt(index)));
2414 } 2414 }
2415 2415
2416 2416
2417 void LCodeGen::DoLoadGlobalGeneric(LLoadGlobalGeneric* instr) { 2417 void LCodeGen::DoLoadGlobalGeneric(LLoadGlobalGeneric* instr) {
2418 DCHECK(ToRegister(instr->context()).is(esi)); 2418 DCHECK(ToRegister(instr->context()).is(esi));
2419 DCHECK(ToRegister(instr->global_object())
2420 .is(LoadDescriptor::ReceiverRegister()));
2421 DCHECK(ToRegister(instr->result()).is(eax)); 2419 DCHECK(ToRegister(instr->result()).is(eax));
2422 2420
2423 __ mov(LoadDescriptor::NameRegister(), instr->name());
2424 EmitVectorLoadICRegisters<LLoadGlobalGeneric>(instr); 2421 EmitVectorLoadICRegisters<LLoadGlobalGeneric>(instr);
2425 Handle<Code> ic = 2422 Handle<Code> ic =
2426 CodeFactory::LoadGlobalICInOptimizedCode(isolate(), instr->typeof_mode()) 2423 CodeFactory::LoadGlobalICInOptimizedCode(isolate(), instr->typeof_mode())
2427 .code(); 2424 .code();
2428 CallCode(ic, RelocInfo::CODE_TARGET, instr); 2425 CallCode(ic, RelocInfo::CODE_TARGET, instr);
2429 } 2426 }
2430 2427
2431 2428
2432 void LCodeGen::DoLoadContextSlot(LLoadContextSlot* instr) { 2429 void LCodeGen::DoLoadContextSlot(LLoadContextSlot* instr) {
2433 Register context = ToRegister(instr->context()); 2430 Register context = ToRegister(instr->context());
(...skipping 2877 matching lines...) Expand 10 before | Expand all | Expand 10 after
5311 __ bind(deferred->exit()); 5308 __ bind(deferred->exit());
5312 __ bind(&done); 5309 __ bind(&done);
5313 } 5310 }
5314 5311
5315 #undef __ 5312 #undef __
5316 5313
5317 } // namespace internal 5314 } // namespace internal
5318 } // namespace v8 5315 } // namespace v8
5319 5316
5320 #endif // V8_TARGET_ARCH_IA32 5317 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/crankshaft/hydrogen-instructions.h ('k') | src/crankshaft/ia32/lithium-ia32.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698