Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 2072573002: Basic support for animating window properties in Mus. (Closed)

Created:
4 years, 6 months ago by mfomitchev
Modified:
4 years, 5 months ago
Reviewers:
sky, meacer
CC:
chromium-reviews, rjkroege, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@launcher_controller_mus_mus_3
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Basic support for animating window properties in Mus. - Adding Mojo types for specifying opacity and transform animations. - Adding support for scheduling and Tick()ing the animations on the Mus side. - Unit tests. BUG=548396 Committed: https://crrev.com/f29c7b9ceb70fab3a19f2e0ea18aa30757188236 Cr-Commit-Position: refs/heads/master@{#402939}

Patch Set 1 #

Total comments: 14

Patch Set 2 : Addressing feedback. #

Total comments: 2

Patch Set 3 : Fixing .mojom Rebase #

Patch Set 4 : Replacing .empty() with .size() == 0 to account for is_null case in mojo::Array. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1579 lines, -0 lines) Patch
M components/mus/public/interfaces/BUILD.gn View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A components/mus/public/interfaces/animations.mojom View 1 2 1 chunk +61 lines, -0 lines 0 comments Download
M components/mus/ws/BUILD.gn View 1 2 3 3 chunks +7 lines, -0 lines 0 comments Download
A components/mus/ws/animation_runner.h View 1 1 chunk +119 lines, -0 lines 0 comments Download
A components/mus/ws/animation_runner.cc View 1 1 chunk +163 lines, -0 lines 0 comments Download
A components/mus/ws/animation_runner_observer.h View 1 chunk +25 lines, -0 lines 0 comments Download
A components/mus/ws/animation_runner_unittest.cc View 1 chunk +639 lines, -0 lines 0 comments Download
A components/mus/ws/scheduled_animation_group.h View 1 chunk +116 lines, -0 lines 0 comments Download
A components/mus/ws/scheduled_animation_group.cc View 1 2 3 1 chunk +356 lines, -0 lines 0 comments Download
A components/mus/ws/scheduled_animation_group_unittest.cc View 1 chunk +92 lines, -0 lines 0 comments Download

Messages

Total messages: 25 (9 generated)
mfomitchev
4 years, 6 months ago (2016-06-15 21:45:44 UTC) #3
sky
https://codereview.chromium.org/2072573002/diff/1/components/mus/public/interfaces/animations.mojom File components/mus/public/interfaces/animations.mojom (right): https://codereview.chromium.org/2072573002/diff/1/components/mus/public/interfaces/animations.mojom#newcode15 components/mus/public/interfaces/animations.mojom:15: //import "ui/gfx/geometry/mojo/geometry.mojom"; ? https://codereview.chromium.org/2072573002/diff/1/components/mus/public/interfaces/animations.mojom#newcode26 components/mus/public/interfaces/animations.mojom:26: gfx.mojom.Transform transform; Shouldn't this ...
4 years, 6 months ago (2016-06-16 16:36:33 UTC) #4
sky
Also, you'll need a security review for the new mojom.
4 years, 6 months ago (2016-06-16 16:36:54 UTC) #5
mfomitchev
https://codereview.chromium.org/2072573002/diff/1/components/mus/public/interfaces/animations.mojom File components/mus/public/interfaces/animations.mojom (right): https://codereview.chromium.org/2072573002/diff/1/components/mus/public/interfaces/animations.mojom#newcode15 components/mus/public/interfaces/animations.mojom:15: //import "ui/gfx/geometry/mojo/geometry.mojom"; On 2016/06/16 16:36:33, sky wrote: > ? ...
4 years, 6 months ago (2016-06-22 21:59:36 UTC) #6
sky
https://codereview.chromium.org/2072573002/diff/20001/components/mus/public/interfaces/animations.mojom File components/mus/public/interfaces/animations.mojom (right): https://codereview.chromium.org/2072573002/diff/20001/components/mus/public/interfaces/animations.mojom#newcode40 components/mus/public/interfaces/animations.mojom:40: AnimationValue start_value; Don't you need the ? here? You ...
4 years, 6 months ago (2016-06-22 23:21:28 UTC) #7
mfomitchev
https://codereview.chromium.org/2072573002/diff/20001/components/mus/public/interfaces/animations.mojom File components/mus/public/interfaces/animations.mojom (right): https://codereview.chromium.org/2072573002/diff/20001/components/mus/public/interfaces/animations.mojom#newcode40 components/mus/public/interfaces/animations.mojom:40: AnimationValue start_value; On 2016/06/22 23:21:28, sky wrote: > Don't ...
4 years, 6 months ago (2016-06-23 14:54:28 UTC) #8
sky
LGTM
4 years, 6 months ago (2016-06-23 15:55:36 UTC) #9
mfomitchev
+meacer@chromium.org for the security review
4 years, 6 months ago (2016-06-23 16:52:54 UTC) #11
mfomitchev
meacer: ping Can you PTAL at components/mus/public/interfaces/animations.mojom?
4 years, 5 months ago (2016-06-27 14:11:29 UTC) #12
meacer
Sorry for the delay. IPC Lgtm.
4 years, 5 months ago (2016-06-27 19:24:44 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2072573002/40001
4 years, 5 months ago (2016-06-27 19:32:54 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/253158)
4 years, 5 months ago (2016-06-27 21:04:58 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2072573002/60001
4 years, 5 months ago (2016-06-29 20:06:29 UTC) #20
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 5 months ago (2016-06-29 21:38:26 UTC) #22
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-06-29 21:38:31 UTC) #23
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 21:40:32 UTC) #25
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/f29c7b9ceb70fab3a19f2e0ea18aa30757188236
Cr-Commit-Position: refs/heads/master@{#402939}

Powered by Google App Engine
This is Rietveld 408576698