Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2068603002: [debugger] simplify debug stepping. (Closed)

Created:
4 years, 6 months ago by Yang
Modified:
4 years, 6 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[debugger] simplify debug stepping. R=bmeurer@chromium.org Committed: https://crrev.com/3e2d60d853cdfe49d4db0040b51f75b214a01714 Cr-Commit-Position: refs/heads/master@{#36960}

Patch Set 1 #

Patch Set 2 : remove declaration #

Total comments: 1

Patch Set 3 : fix #

Patch Set 4 : fix completion callback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -105 lines) Patch
M src/arm/builtins-arm.cc View 1 2 1 chunk +7 lines, -6 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 1 2 1 chunk +7 lines, -6 lines 0 comments Download
M src/arm64/builtins-arm64.cc View 1 2 1 chunk +6 lines, -5 lines 0 comments Download
M src/arm64/macro-assembler-arm64.cc View 1 2 1 chunk +6 lines, -5 lines 0 comments Download
M src/assembler.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/assembler.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M src/debug/debug.h View 1 3 chunks +2 lines, -8 lines 0 comments Download
M src/debug/debug.cc View 1 2 6 chunks +4 lines, -22 lines 0 comments Download
M src/external-reference-table.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/builtins-ia32.cc View 1 2 1 chunk +5 lines, -4 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 2 1 chunk +5 lines, -4 lines 0 comments Download
M src/isolate.cc View 1 2 3 1 chunk +6 lines, -3 lines 0 comments Download
M src/mips/builtins-mips.cc View 1 2 1 chunk +5 lines, -4 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 1 2 1 chunk +5 lines, -4 lines 0 comments Download
M src/mips64/builtins-mips64.cc View 1 2 1 chunk +5 lines, -4 lines 0 comments Download
M src/mips64/macro-assembler-mips64.cc View 1 2 1 chunk +5 lines, -4 lines 0 comments Download
M src/runtime/runtime-debug.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/x64/builtins-x64.cc View 1 chunk +6 lines, -5 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 chunk +6 lines, -5 lines 0 comments Download
M src/x87/builtins-x87.cc View 1 2 1 chunk +5 lines, -4 lines 0 comments Download
M src/x87/macro-assembler-x87.cc View 1 2 1 chunk +5 lines, -4 lines 0 comments Download

Dependent Patchsets:

Issue 2067503002 Patch 20001
Issue 2067503002 Patch 40001

Messages

Total messages: 15 (5 generated)
Yang
4 years, 6 months ago (2016-06-14 05:53:23 UTC) #1
Benedikt Meurer
https://codereview.chromium.org/2068603002/diff/20001/src/x87/builtins-x87.cc File src/x87/builtins-x87.cc (right): https://codereview.chromium.org/2068603002/diff/20001/src/x87/builtins-x87.cc#newcode416 src/x87/builtins-x87.cc:416: __ cmpb(Operand::StaticVariable(last_step_action), Immediate(0)); That 0 doesn't seem to make ...
4 years, 6 months ago (2016-06-14 06:28:05 UTC) #2
Yang
On 2016/06/14 06:28:05, Benedikt Meurer wrote: > https://codereview.chromium.org/2068603002/diff/20001/src/x87/builtins-x87.cc > File src/x87/builtins-x87.cc (right): > > https://codereview.chromium.org/2068603002/diff/20001/src/x87/builtins-x87.cc#newcode416 ...
4 years, 6 months ago (2016-06-14 08:21:50 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2068603002/40001
4 years, 6 months ago (2016-06-14 08:22:06 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2068603002/60001
4 years, 6 months ago (2016-06-14 08:40:55 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-14 09:08:46 UTC) #9
Benedikt Meurer
LGTM.
4 years, 6 months ago (2016-06-14 09:47:43 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2068603002/60001
4 years, 6 months ago (2016-06-14 11:05:21 UTC) #12
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 6 months ago (2016-06-14 11:07:48 UTC) #13
commit-bot: I haz the power
4 years, 6 months ago (2016-06-14 11:08:53 UTC) #15
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/3e2d60d853cdfe49d4db0040b51f75b214a01714
Cr-Commit-Position: refs/heads/master@{#36960}

Powered by Google App Engine
This is Rietveld 408576698