Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Side by Side Diff: src/x64/macro-assembler-x64.cc

Issue 2068603002: [debugger] simplify debug stepping. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: fix completion callback Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/x64/builtins-x64.cc ('k') | src/x87/builtins-x87.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_X64 5 #if V8_TARGET_ARCH_X64
6 6
7 #include "src/base/bits.h" 7 #include "src/base/bits.h"
8 #include "src/base/division-by-constant.h" 8 #include "src/base/division-by-constant.h"
9 #include "src/bootstrapper.h" 9 #include "src/bootstrapper.h"
10 #include "src/codegen.h" 10 #include "src/codegen.h"
(...skipping 4320 matching lines...) Expand 10 before | Expand all | Expand 10 after
4331 } 4331 }
4332 bind(&invoke); 4332 bind(&invoke);
4333 } 4333 }
4334 } 4334 }
4335 4335
4336 4336
4337 void MacroAssembler::FloodFunctionIfStepping(Register fun, Register new_target, 4337 void MacroAssembler::FloodFunctionIfStepping(Register fun, Register new_target,
4338 const ParameterCount& expected, 4338 const ParameterCount& expected,
4339 const ParameterCount& actual) { 4339 const ParameterCount& actual) {
4340 Label skip_flooding; 4340 Label skip_flooding;
4341 ExternalReference step_in_enabled = 4341 ExternalReference last_step_action =
4342 ExternalReference::debug_step_in_enabled_address(isolate()); 4342 ExternalReference::debug_last_step_action_address(isolate());
4343 Operand step_in_enabled_operand = ExternalOperand(step_in_enabled); 4343 Operand last_step_action_operand = ExternalOperand(last_step_action);
4344 cmpb(step_in_enabled_operand, Immediate(0)); 4344 STATIC_ASSERT(StepFrame > StepIn);
4345 j(equal, &skip_flooding); 4345 cmpb(last_step_action_operand, Immediate(StepIn));
4346 j(less, &skip_flooding);
4346 { 4347 {
4347 FrameScope frame(this, 4348 FrameScope frame(this,
4348 has_frame() ? StackFrame::NONE : StackFrame::INTERNAL); 4349 has_frame() ? StackFrame::NONE : StackFrame::INTERNAL);
4349 if (expected.is_reg()) { 4350 if (expected.is_reg()) {
4350 Integer32ToSmi(expected.reg(), expected.reg()); 4351 Integer32ToSmi(expected.reg(), expected.reg());
4351 Push(expected.reg()); 4352 Push(expected.reg());
4352 } 4353 }
4353 if (actual.is_reg()) { 4354 if (actual.is_reg()) {
4354 Integer32ToSmi(actual.reg(), actual.reg()); 4355 Integer32ToSmi(actual.reg(), actual.reg());
4355 Push(actual.reg()); 4356 Push(actual.reg());
(...skipping 1365 matching lines...) Expand 10 before | Expand all | Expand 10 after
5721 movl(rax, dividend); 5722 movl(rax, dividend);
5722 shrl(rax, Immediate(31)); 5723 shrl(rax, Immediate(31));
5723 addl(rdx, rax); 5724 addl(rdx, rax);
5724 } 5725 }
5725 5726
5726 5727
5727 } // namespace internal 5728 } // namespace internal
5728 } // namespace v8 5729 } // namespace v8
5729 5730
5730 #endif // V8_TARGET_ARCH_X64 5731 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/x64/builtins-x64.cc ('k') | src/x87/builtins-x87.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698