Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1125)

Side by Side Diff: src/mips/builtins-mips.cc

Issue 2068603002: [debugger] simplify debug stepping. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: fix completion callback Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/isolate.cc ('k') | src/mips/macro-assembler-mips.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_MIPS 5 #if V8_TARGET_ARCH_MIPS
6 6
7 #include "src/codegen.h" 7 #include "src/codegen.h"
8 #include "src/debug/debug.h" 8 #include "src/debug/debug.h"
9 #include "src/deoptimizer.h" 9 #include "src/deoptimizer.h"
10 #include "src/full-codegen/full-codegen.h" 10 #include "src/full-codegen/full-codegen.h"
(...skipping 822 matching lines...) Expand 10 before | Expand all | Expand 10 after
833 // Store resume mode into generator object. 833 // Store resume mode into generator object.
834 __ sw(a2, FieldMemOperand(a1, JSGeneratorObject::kResumeModeOffset)); 834 __ sw(a2, FieldMemOperand(a1, JSGeneratorObject::kResumeModeOffset));
835 835
836 // Load suspended function and context. 836 // Load suspended function and context.
837 __ lw(cp, FieldMemOperand(a1, JSGeneratorObject::kContextOffset)); 837 __ lw(cp, FieldMemOperand(a1, JSGeneratorObject::kContextOffset));
838 __ lw(t0, FieldMemOperand(a1, JSGeneratorObject::kFunctionOffset)); 838 __ lw(t0, FieldMemOperand(a1, JSGeneratorObject::kFunctionOffset));
839 839
840 // Flood function if we are stepping. 840 // Flood function if we are stepping.
841 Label prepare_step_in_if_stepping, prepare_step_in_suspended_generator; 841 Label prepare_step_in_if_stepping, prepare_step_in_suspended_generator;
842 Label stepping_prepared; 842 Label stepping_prepared;
843 ExternalReference step_in_enabled = 843 ExternalReference last_step_action =
844 ExternalReference::debug_step_in_enabled_address(masm->isolate()); 844 ExternalReference::debug_last_step_action_address(masm->isolate());
845 __ li(t1, Operand(step_in_enabled)); 845 STATIC_ASSERT(StepFrame > StepIn);
846 __ li(t1, Operand(last_step_action));
846 __ lb(t1, MemOperand(t1)); 847 __ lb(t1, MemOperand(t1));
847 __ Branch(&prepare_step_in_if_stepping, ne, t1, Operand(zero_reg)); 848 __ Branch(&prepare_step_in_if_stepping, ge, t1, Operand(StepIn));
848 849
849 // Flood function if we need to continue stepping in the suspended generator. 850 // Flood function if we need to continue stepping in the suspended generator.
850 ExternalReference debug_suspended_generator = 851 ExternalReference debug_suspended_generator =
851 ExternalReference::debug_suspended_generator_address(masm->isolate()); 852 ExternalReference::debug_suspended_generator_address(masm->isolate());
852 __ li(t1, Operand(debug_suspended_generator)); 853 __ li(t1, Operand(debug_suspended_generator));
853 __ lw(t1, MemOperand(t1)); 854 __ lw(t1, MemOperand(t1));
854 __ Branch(&prepare_step_in_suspended_generator, eq, a1, Operand(t1)); 855 __ Branch(&prepare_step_in_suspended_generator, eq, a1, Operand(t1));
855 __ bind(&stepping_prepared); 856 __ bind(&stepping_prepared);
856 857
857 // Push receiver. 858 // Push receiver.
(...skipping 2099 matching lines...) Expand 10 before | Expand all | Expand 10 after
2957 } 2958 }
2958 } 2959 }
2959 2960
2960 2961
2961 #undef __ 2962 #undef __
2962 2963
2963 } // namespace internal 2964 } // namespace internal
2964 } // namespace v8 2965 } // namespace v8
2965 2966
2966 #endif // V8_TARGET_ARCH_MIPS 2967 #endif // V8_TARGET_ARCH_MIPS
OLDNEW
« no previous file with comments | « src/isolate.cc ('k') | src/mips/macro-assembler-mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698