Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Side by Side Diff: src/ia32/macro-assembler-ia32.cc

Issue 2068603002: [debugger] simplify debug stepping. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: fix completion callback Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ia32/builtins-ia32.cc ('k') | src/isolate.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_IA32 5 #if V8_TARGET_ARCH_IA32
6 6
7 #include "src/base/bits.h" 7 #include "src/base/bits.h"
8 #include "src/base/division-by-constant.h" 8 #include "src/base/division-by-constant.h"
9 #include "src/bootstrapper.h" 9 #include "src/bootstrapper.h"
10 #include "src/codegen.h" 10 #include "src/codegen.h"
(...skipping 2344 matching lines...) Expand 10 before | Expand all | Expand 10 after
2355 } 2355 }
2356 bind(&invoke); 2356 bind(&invoke);
2357 } 2357 }
2358 } 2358 }
2359 2359
2360 2360
2361 void MacroAssembler::FloodFunctionIfStepping(Register fun, Register new_target, 2361 void MacroAssembler::FloodFunctionIfStepping(Register fun, Register new_target,
2362 const ParameterCount& expected, 2362 const ParameterCount& expected,
2363 const ParameterCount& actual) { 2363 const ParameterCount& actual) {
2364 Label skip_flooding; 2364 Label skip_flooding;
2365 ExternalReference step_in_enabled = 2365 ExternalReference last_step_action =
2366 ExternalReference::debug_step_in_enabled_address(isolate()); 2366 ExternalReference::debug_last_step_action_address(isolate());
2367 cmpb(Operand::StaticVariable(step_in_enabled), Immediate(0)); 2367 STATIC_ASSERT(StepFrame > StepIn);
2368 j(equal, &skip_flooding); 2368 cmpb(Operand::StaticVariable(last_step_action), Immediate(StepIn));
2369 j(less, &skip_flooding);
2369 { 2370 {
2370 FrameScope frame(this, 2371 FrameScope frame(this,
2371 has_frame() ? StackFrame::NONE : StackFrame::INTERNAL); 2372 has_frame() ? StackFrame::NONE : StackFrame::INTERNAL);
2372 if (expected.is_reg()) { 2373 if (expected.is_reg()) {
2373 SmiTag(expected.reg()); 2374 SmiTag(expected.reg());
2374 Push(expected.reg()); 2375 Push(expected.reg());
2375 } 2376 }
2376 if (actual.is_reg()) { 2377 if (actual.is_reg()) {
2377 SmiTag(actual.reg()); 2378 SmiTag(actual.reg());
2378 Push(actual.reg()); 2379 Push(actual.reg());
(...skipping 1076 matching lines...) Expand 10 before | Expand all | Expand 10 after
3455 mov(eax, dividend); 3456 mov(eax, dividend);
3456 shr(eax, 31); 3457 shr(eax, 31);
3457 add(edx, eax); 3458 add(edx, eax);
3458 } 3459 }
3459 3460
3460 3461
3461 } // namespace internal 3462 } // namespace internal
3462 } // namespace v8 3463 } // namespace v8
3463 3464
3464 #endif // V8_TARGET_ARCH_IA32 3465 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/ia32/builtins-ia32.cc ('k') | src/isolate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698