Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Side by Side Diff: src/arm/builtins-arm.cc

Issue 2068603002: [debugger] simplify debug stepping. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: fix completion callback Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/arm/macro-assembler-arm.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_ARM 5 #if V8_TARGET_ARCH_ARM
6 6
7 #include "src/codegen.h" 7 #include "src/codegen.h"
8 #include "src/debug/debug.h" 8 #include "src/debug/debug.h"
9 #include "src/deoptimizer.h" 9 #include "src/deoptimizer.h"
10 #include "src/full-codegen/full-codegen.h" 10 #include "src/full-codegen/full-codegen.h"
(...skipping 701 matching lines...) Expand 10 before | Expand all | Expand 10 after
712 // Store resume mode into generator object. 712 // Store resume mode into generator object.
713 __ str(r2, FieldMemOperand(r1, JSGeneratorObject::kResumeModeOffset)); 713 __ str(r2, FieldMemOperand(r1, JSGeneratorObject::kResumeModeOffset));
714 714
715 // Load suspended function and context. 715 // Load suspended function and context.
716 __ ldr(cp, FieldMemOperand(r1, JSGeneratorObject::kContextOffset)); 716 __ ldr(cp, FieldMemOperand(r1, JSGeneratorObject::kContextOffset));
717 __ ldr(r4, FieldMemOperand(r1, JSGeneratorObject::kFunctionOffset)); 717 __ ldr(r4, FieldMemOperand(r1, JSGeneratorObject::kFunctionOffset));
718 718
719 // Flood function if we are stepping. 719 // Flood function if we are stepping.
720 Label prepare_step_in_if_stepping, prepare_step_in_suspended_generator; 720 Label prepare_step_in_if_stepping, prepare_step_in_suspended_generator;
721 Label stepping_prepared; 721 Label stepping_prepared;
722 ExternalReference step_in_enabled = 722 ExternalReference last_step_action =
723 ExternalReference::debug_step_in_enabled_address(masm->isolate()); 723 ExternalReference::debug_last_step_action_address(masm->isolate());
724 __ mov(ip, Operand(step_in_enabled)); 724 STATIC_ASSERT(StepFrame > StepIn);
725 __ ldrb(ip, MemOperand(ip)); 725 __ mov(ip, Operand(last_step_action));
726 __ cmp(ip, Operand(0)); 726 __ ldrsb(ip, MemOperand(ip));
727 __ b(ne, &prepare_step_in_if_stepping); 727 __ cmp(ip, Operand(StepIn));
728 __ b(ge, &prepare_step_in_if_stepping);
728 729
729 // Flood function if we need to continue stepping in the suspended generator. 730 // Flood function if we need to continue stepping in the suspended generator.
730 ExternalReference debug_suspended_generator = 731 ExternalReference debug_suspended_generator =
731 ExternalReference::debug_suspended_generator_address(masm->isolate()); 732 ExternalReference::debug_suspended_generator_address(masm->isolate());
732 __ mov(ip, Operand(debug_suspended_generator)); 733 __ mov(ip, Operand(debug_suspended_generator));
733 __ ldr(ip, MemOperand(ip)); 734 __ ldr(ip, MemOperand(ip));
734 __ cmp(ip, Operand(r1)); 735 __ cmp(ip, Operand(r1));
735 __ b(eq, &prepare_step_in_suspended_generator); 736 __ b(eq, &prepare_step_in_suspended_generator);
736 __ bind(&stepping_prepared); 737 __ bind(&stepping_prepared);
737 738
(...skipping 2126 matching lines...) Expand 10 before | Expand all | Expand 10 after
2864 } 2865 }
2865 } 2866 }
2866 2867
2867 2868
2868 #undef __ 2869 #undef __
2869 2870
2870 } // namespace internal 2871 } // namespace internal
2871 } // namespace v8 2872 } // namespace v8
2872 2873
2873 #endif // V8_TARGET_ARCH_ARM 2874 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « no previous file | src/arm/macro-assembler-arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698