Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Side by Side Diff: src/arm64/builtins-arm64.cc

Issue 2068603002: [debugger] simplify debug stepping. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: fix completion callback Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/arm/macro-assembler-arm.cc ('k') | src/arm64/macro-assembler-arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_ARM64 5 #if V8_TARGET_ARCH_ARM64
6 6
7 #include "src/arm64/frames-arm64.h" 7 #include "src/arm64/frames-arm64.h"
8 #include "src/codegen.h" 8 #include "src/codegen.h"
9 #include "src/debug/debug.h" 9 #include "src/debug/debug.h"
10 #include "src/deoptimizer.h" 10 #include "src/deoptimizer.h"
(...skipping 708 matching lines...) Expand 10 before | Expand all | Expand 10 after
719 // Store resume mode into generator object. 719 // Store resume mode into generator object.
720 __ Str(x2, FieldMemOperand(x1, JSGeneratorObject::kResumeModeOffset)); 720 __ Str(x2, FieldMemOperand(x1, JSGeneratorObject::kResumeModeOffset));
721 721
722 // Load suspended function and context. 722 // Load suspended function and context.
723 __ Ldr(cp, FieldMemOperand(x1, JSGeneratorObject::kContextOffset)); 723 __ Ldr(cp, FieldMemOperand(x1, JSGeneratorObject::kContextOffset));
724 __ Ldr(x4, FieldMemOperand(x1, JSGeneratorObject::kFunctionOffset)); 724 __ Ldr(x4, FieldMemOperand(x1, JSGeneratorObject::kFunctionOffset));
725 725
726 // Flood function if we are stepping. 726 // Flood function if we are stepping.
727 Label prepare_step_in_if_stepping, prepare_step_in_suspended_generator; 727 Label prepare_step_in_if_stepping, prepare_step_in_suspended_generator;
728 Label stepping_prepared; 728 Label stepping_prepared;
729 ExternalReference step_in_enabled = 729 ExternalReference last_step_action =
730 ExternalReference::debug_step_in_enabled_address(masm->isolate()); 730 ExternalReference::debug_last_step_action_address(masm->isolate());
731 __ Mov(x10, Operand(step_in_enabled)); 731 STATIC_ASSERT(StepFrame > StepIn);
732 __ Ldrb(x10, MemOperand(x10)); 732 __ Mov(x10, Operand(last_step_action));
733 __ CompareAndBranch(x10, Operand(0), ne, &prepare_step_in_if_stepping); 733 __ Ldrsb(x10, MemOperand(x10));
734 __ CompareAndBranch(x10, Operand(StepIn), ge, &prepare_step_in_if_stepping);
734 735
735 // Flood function if we need to continue stepping in the suspended generator. 736 // Flood function if we need to continue stepping in the suspended generator.
736 ExternalReference debug_suspended_generator = 737 ExternalReference debug_suspended_generator =
737 ExternalReference::debug_suspended_generator_address(masm->isolate()); 738 ExternalReference::debug_suspended_generator_address(masm->isolate());
738 __ Mov(x10, Operand(debug_suspended_generator)); 739 __ Mov(x10, Operand(debug_suspended_generator));
739 __ Ldr(x10, MemOperand(x10)); 740 __ Ldr(x10, MemOperand(x10));
740 __ CompareAndBranch(x10, Operand(x1), eq, 741 __ CompareAndBranch(x10, Operand(x1), eq,
741 &prepare_step_in_suspended_generator); 742 &prepare_step_in_suspended_generator);
742 __ Bind(&stepping_prepared); 743 __ Bind(&stepping_prepared);
743 744
(...skipping 2243 matching lines...) Expand 10 before | Expand all | Expand 10 after
2987 } 2988 }
2988 } 2989 }
2989 2990
2990 2991
2991 #undef __ 2992 #undef __
2992 2993
2993 } // namespace internal 2994 } // namespace internal
2994 } // namespace v8 2995 } // namespace v8
2995 2996
2996 #endif // V8_TARGET_ARCH_ARM 2997 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « src/arm/macro-assembler-arm.cc ('k') | src/arm64/macro-assembler-arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698