Pass responsibility for IOSurface-texture reuse to the gpu process.

Pass responsibility for IOSurface-texture reuse to the gpu process.

The GLRenderer uses the new command buffer function
glScheduleCALayerInUseQueryCHROMIUM to determine whether textures are still in
use by the system compositor. This means that GpuMemoryBufferIds no longer need
to be plumbed through to the browser process.

BUG=608026
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/1ed6908a7a46dde512db953c77e343a63f41630f
Cr-Commit-Position: refs/heads/master@{#400732}

[erikchen, 2016-06-14 21:16:30]

Description was changed from

==========
Clietn side plumbing.

BUG=
==========

to

==========
Clietn side plumbing.

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[erikchen, 2016-06-14 21:16:31]

Description was changed from

==========
Clietn side plumbing.

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Clietn side plumbing.

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[erikchen, 2016-06-14 21:17:48]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-14 21:18:23]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2061993003/1

[commit-bot: I haz the power, 2016-06-14 21:33:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-14 21:33:15]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)

[erikchen, 2016-06-14 22:42:28]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-14 22:43:28]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2061993003/20001

[erikchen, 2016-06-14 22:51:11]

Description was changed from

==========
Clietn side plumbing.

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Clietn side plumbing.

The GLRenderer uses the new command buffer function
glScheduleCALayerInUseQueryCHROMIUM to determine whether textures are still in
use by the system compositor. This means that GpuMemoryBufferIds no longer need
to be plumbed through to the browser process.

BUG=608026
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[erikchen, 2016-06-14 22:52:45]

Description was changed from

==========
Clietn side plumbing.

The GLRenderer uses the new command buffer function
glScheduleCALayerInUseQueryCHROMIUM to determine whether textures are still in
use by the system compositor. This means that GpuMemoryBufferIds no longer need
to be plumbed through to the browser process.

BUG=608026
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Pass responsibility for IOSurface-texture reuse to the gpu process.

The GLRenderer uses the new command buffer function
glScheduleCALayerInUseQueryCHROMIUM to determine whether textures are still in
use by the system compositor. This means that GpuMemoryBufferIds no longer need
to be plumbed through to the browser process.

BUG=608026
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[erikchen, 2016-06-14 22:54:32]

Description was changed from

==========
Pass responsibility for IOSurface-texture reuse to the gpu process.

The GLRenderer uses the new command buffer function
glScheduleCALayerInUseQueryCHROMIUM to determine whether textures are still in
use by the system compositor. This means that GpuMemoryBufferIds no longer need
to be plumbed through to the browser process.

BUG=608026
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Pass responsibility for IOSurface-texture reuse to the gpu process.

The GLRenderer uses the new command buffer function
glScheduleCALayerInUseQueryCHROMIUM to determine whether textures are still in
use by the system compositor. This means that GpuMemoryBufferIds no longer need
to be plumbed through to the browser process.

BUG=608026
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[erikchen, 2016-06-14 23:26:04]

erikchen@chromium.org changed reviewers:
+ ccameron@chromium.org

[erikchen, 2016-06-14 23:26:05]

ccameron: Please review.

[ccameron, 2016-06-14 23:35:49]

lgtm

[erikchen, 2016-06-14 23:38:02]

erikchen@chromium.org changed reviewers:
+ dcheng@chromium.org, piman@chromium.org

[erikchen, 2016-06-14 23:38:03]

piman: Please review.
dcheng: Please review gpu/ipc/common/gpu_messages.h.

[piman, 2016-06-15 00:37:47]

lgtm

https://codereview.chromium.org/2061993003/diff/20001/gpu/ipc/common/gpu_comm...
File gpu/ipc/common/gpu_command_buffer_traits.h (right):

https://codereview.chromium.org/2061993003/diff/20001/gpu/ipc/common/gpu_comm...
gpu/ipc/common/gpu_command_buffer_traits.h:47: struct GPU_EXPORT
ParamTraits<gpu::TextureInUseResponse> {
nit: could this be a IPC_STRUCT_TRAITS in gpu_messages.h ?
(I'm not really sure why some of the others are not... maybe I'm missing
something, but I think it should work).

[erikchen, 2016-06-15 00:44:01]

https://codereview.chromium.org/2061993003/diff/20001/gpu/ipc/common/gpu_comm...
File gpu/ipc/common/gpu_command_buffer_traits.h (right):

https://codereview.chromium.org/2061993003/diff/20001/gpu/ipc/common/gpu_comm...
gpu/ipc/common/gpu_command_buffer_traits.h:47: struct GPU_EXPORT
ParamTraits<gpu::TextureInUseResponse> {
On 2016/06/15 00:37:47, piman wrote:
> nit: could this be a IPC_STRUCT_TRAITS in gpu_messages.h ?
> (I'm not really sure why some of the others are not... maybe I'm missing
> something, but I think it should work).

I tried that at first.  gpu_messages.h is a multiply included file, which causes
problems when it gets included into another header file.

[commit-bot: I haz the power, 2016-06-15 00:45:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-15 00:45:24]

Dry run: Try jobs failed on following builders:
  ios-device on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL)
  ios-device-gn on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL)

[erikchen, 2016-06-15 01:34:34]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-15 01:34:54]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2061993003/20001

[commit-bot: I haz the power, 2016-06-15 02:50:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-15 02:50:36]

Dry run: This issue passed the CQ dry run.

[dcheng, 2016-06-15 08:47:21]

Change LGTM. Out of curiosity, what happens if a rogue GPU process starts
claiming that none of the textures are in use?

https://codereview.chromium.org/2061993003/diff/20001/cc/output/gl_renderer.cc
File cc/output/gl_renderer.cc (right):

https://codereview.chromium.org/2061993003/diff/20001/cc/output/gl_renderer.c...
cc/output/gl_renderer.cc:2746: auto it =
swapped_and_acked_overlay_resources_.find(response.texture);
Out of curiosity, why isn't this just a call to erase()?

[erikchen, 2016-06-20 16:16:18]

On 2016/06/15 08:47:21, dcheng wrote:
> Change LGTM. Out of curiosity, what happens if a rogue GPU process starts
> claiming that none of the textures are in use?
Then the textures will potentially be reused while they are still in use by the
window server.

> 
> https://codereview.chromium.org/2061993003/diff/20001/cc/output/gl_renderer.cc
> File cc/output/gl_renderer.cc (right):
> 
>
https://codereview.chromium.org/2061993003/diff/20001/cc/output/gl_renderer.c...
> cc/output/gl_renderer.cc:2746: auto it =
> swapped_and_acked_overlay_resources_.find(response.texture);
> Out of curiosity, why isn't this just a call to erase()?

[erikchen, 2016-06-20 16:16:32]

https://codereview.chromium.org/2061993003/diff/20001/cc/output/gl_renderer.cc
File cc/output/gl_renderer.cc (right):

https://codereview.chromium.org/2061993003/diff/20001/cc/output/gl_renderer.c...
cc/output/gl_renderer.cc:2746: auto it =
swapped_and_acked_overlay_resources_.find(response.texture);
On 2016/06/15 08:47:21, dcheng wrote:
> Out of curiosity, why isn't this just a call to erase()?

Mistake, fixed.

[erikchen, 2016-06-20 16:16:37]

The CQ bit was checked by erikchen@chromium.org

[erikchen, 2016-06-20 16:16:37]

The patchset sent to the CQ was uploaded after l-g-t-m from
ccameron@chromium.org, dcheng@chromium.org, piman@chromium.org
Link to the patchset: https://codereview.chromium.org/2061993003/#ps100001
(title: "Compile error.")

[commit-bot: I haz the power, 2016-06-20 16:16:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2061993003/100001

[commit-bot: I haz the power, 2016-06-20 16:56:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-20 16:56:17]

Try jobs failed on following builders:
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[erikchen, 2016-06-20 17:10:33]

The CQ bit was checked by erikchen@chromium.org

[erikchen, 2016-06-20 17:10:34]

The patchset sent to the CQ was uploaded after l-g-t-m from
ccameron@chromium.org, dcheng@chromium.org, piman@chromium.org
Link to the patchset: https://codereview.chromium.org/2061993003/#ps120001
(title: "Rebase.")

[commit-bot: I haz the power, 2016-06-20 17:11:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2061993003/120001

[commit-bot: I haz the power, 2016-06-20 18:27:38]

Description was changed from

==========
Pass responsibility for IOSurface-texture reuse to the gpu process.

The GLRenderer uses the new command buffer function
glScheduleCALayerInUseQueryCHROMIUM to determine whether textures are still in
use by the system compositor. This means that GpuMemoryBufferIds no longer need
to be plumbed through to the browser process.

BUG=608026
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Pass responsibility for IOSurface-texture reuse to the gpu process.

The GLRenderer uses the new command buffer function
glScheduleCALayerInUseQueryCHROMIUM to determine whether textures are still in
use by the system compositor. This means that GpuMemoryBufferIds no longer need
to be plumbed through to the browser process.

BUG=608026
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[commit-bot: I haz the power, 2016-06-20 18:27:41]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-06-20 18:29:30]

Description was changed from

==========
Pass responsibility for IOSurface-texture reuse to the gpu process.

The GLRenderer uses the new command buffer function
glScheduleCALayerInUseQueryCHROMIUM to determine whether textures are still in
use by the system compositor. This means that GpuMemoryBufferIds no longer need
to be plumbed through to the browser process.

BUG=608026
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Pass responsibility for IOSurface-texture reuse to the gpu process.

The GLRenderer uses the new command buffer function
glScheduleCALayerInUseQueryCHROMIUM to determine whether textures are still in
use by the system compositor. This means that GpuMemoryBufferIds no longer need
to be plumbed through to the browser process.

BUG=608026
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/1ed6908a7a46dde512db953c77e343a63f41630f
Cr-Commit-Position: refs/heads/master@{#400732}
==========

[commit-bot: I haz the power, 2016-06-20 18:29:32]

Patchset 7 (id:??) landed as
https://crrev.com/1ed6908a7a46dde512db953c77e343a63f41630f
Cr-Commit-Position: refs/heads/master@{#400732}