Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(673)

Side by Side Diff: cc/output/overlay_unittest.cc

Issue 2061993003: Pass responsibility for IOSurface-texture reuse to the gpu process. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@temp85_query_in_use
Patch Set: Rebase. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « cc/output/output_surface_client.h ('k') | cc/output/renderer_settings.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <stddef.h> 5 #include <stddef.h>
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/memory/ptr_util.h" 9 #include "base/memory/ptr_util.h"
10 #include "cc/base/region.h" 10 #include "cc/base/region.h"
(...skipping 1208 matching lines...) Expand 10 before | Expand all | Expand 10 after
1219 output_surface_->OnSwapBuffersComplete(); 1219 output_surface_->OnSwapBuffersComplete();
1220 renderer_->SwapBuffersComplete(); 1220 renderer_->SwapBuffersComplete();
1221 } 1221 }
1222 void SwapBuffersWithoutComplete() { 1222 void SwapBuffersWithoutComplete() {
1223 renderer_->SwapBuffers(CompositorFrameMetadata()); 1223 renderer_->SwapBuffers(CompositorFrameMetadata());
1224 } 1224 }
1225 void SwapBuffersComplete() { 1225 void SwapBuffersComplete() {
1226 output_surface_->OnSwapBuffersComplete(); 1226 output_surface_->OnSwapBuffersComplete();
1227 renderer_->SwapBuffersComplete(); 1227 renderer_->SwapBuffersComplete();
1228 } 1228 }
1229 void ReturnResourceInUseQuery(ResourceId id) {
1230 ResourceProvider::ScopedReadLockGL lock(resource_provider_.get(), id);
1231 gpu::TextureInUseResponse response;
1232 response.texture = lock.texture_id();
1233 response.in_use = false;
1234 gpu::TextureInUseResponses responses;
1235 responses.push_back(response);
1236 renderer_->DidReceiveTextureInUseResponses(responses);
1237 }
1229 1238
1230 RendererSettings settings_; 1239 RendererSettings settings_;
1231 FakeOutputSurfaceClient output_surface_client_; 1240 FakeOutputSurfaceClient output_surface_client_;
1232 std::unique_ptr<OverlayOutputSurface> output_surface_; 1241 std::unique_ptr<OverlayOutputSurface> output_surface_;
1233 FakeRendererClient renderer_client_; 1242 FakeRendererClient renderer_client_;
1234 std::unique_ptr<ResourceProvider> resource_provider_; 1243 std::unique_ptr<ResourceProvider> resource_provider_;
1235 std::unique_ptr<OverlayInfoRendererGL> renderer_; 1244 std::unique_ptr<OverlayInfoRendererGL> renderer_;
1236 scoped_refptr<TestContextProvider> provider_; 1245 scoped_refptr<TestContextProvider> provider_;
1237 MockOverlayScheduler scheduler_; 1246 MockOverlayScheduler scheduler_;
1238 }; 1247 };
(...skipping 287 matching lines...) Expand 10 before | Expand all | Expand 10 after
1526 EXPECT_CALL(scheduler_, Schedule(_, _, _, _, _)).Times(0); 1535 EXPECT_CALL(scheduler_, Schedule(_, _, _, _, _)).Times(0);
1527 renderer_->set_expect_overlays(false); 1536 renderer_->set_expect_overlays(false);
1528 renderer_->BeginDrawingFrame(&frame_no_overlays); 1537 renderer_->BeginDrawingFrame(&frame_no_overlays);
1529 renderer_->FinishDrawingFrame(&frame_no_overlays); 1538 renderer_->FinishDrawingFrame(&frame_no_overlays);
1530 EXPECT_TRUE(resource_provider_->InUseByConsumer(resource1)); 1539 EXPECT_TRUE(resource_provider_->InUseByConsumer(resource1));
1531 SwapBuffers(); 1540 SwapBuffers();
1532 EXPECT_FALSE(resource_provider_->InUseByConsumer(resource1)); 1541 EXPECT_FALSE(resource_provider_->InUseByConsumer(resource1));
1533 Mock::VerifyAndClearExpectations(&scheduler_); 1542 Mock::VerifyAndClearExpectations(&scheduler_);
1534 } 1543 }
1535 1544
1536 TEST_F(GLRendererWithOverlaysTest, ResourcesExportedAndReturnedAtSwapComplete) { 1545 TEST_F(GLRendererWithOverlaysTest, ResourcesExportedAndReturnedAfterGpuQuery) {
1537 bool use_validator = true; 1546 bool use_validator = true;
1538 settings_.release_overlay_resources_on_swap_complete = true; 1547 settings_.release_overlay_resources_after_gpu_query = true;
1539 Init(use_validator); 1548 Init(use_validator);
1540 renderer_->set_expect_overlays(true); 1549 renderer_->set_expect_overlays(true);
1541 1550
1542 ResourceId resource1 = 1551 ResourceId resource1 =
1543 CreateResource(resource_provider_.get(), gfx::Size(32, 32), true); 1552 CreateResource(resource_provider_.get(), gfx::Size(32, 32), true);
1544 ResourceId resource2 = 1553 ResourceId resource2 =
1545 CreateResource(resource_provider_.get(), gfx::Size(32, 32), true); 1554 CreateResource(resource_provider_.get(), gfx::Size(32, 32), true);
1546 ResourceId resource3 = 1555 ResourceId resource3 =
1547 CreateResource(resource_provider_.get(), gfx::Size(32, 32), true); 1556 CreateResource(resource_provider_.get(), gfx::Size(32, 32), true);
1548 1557
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
1603 EXPECT_TRUE(resource_provider_->InUseByConsumer(resource2)); 1612 EXPECT_TRUE(resource_provider_->InUseByConsumer(resource2));
1604 EXPECT_TRUE(resource_provider_->InUseByConsumer(resource3)); 1613 EXPECT_TRUE(resource_provider_->InUseByConsumer(resource3));
1605 SwapBuffersWithoutComplete(); 1614 SwapBuffersWithoutComplete();
1606 EXPECT_TRUE(resource_provider_->InUseByConsumer(resource1)); 1615 EXPECT_TRUE(resource_provider_->InUseByConsumer(resource1));
1607 EXPECT_TRUE(resource_provider_->InUseByConsumer(resource2)); 1616 EXPECT_TRUE(resource_provider_->InUseByConsumer(resource2));
1608 EXPECT_TRUE(resource_provider_->InUseByConsumer(resource3)); 1617 EXPECT_TRUE(resource_provider_->InUseByConsumer(resource3));
1609 Mock::VerifyAndClearExpectations(&scheduler_); 1618 Mock::VerifyAndClearExpectations(&scheduler_);
1610 1619
1611 // This completion corresponds to the first frame. 1620 // This completion corresponds to the first frame.
1612 SwapBuffersComplete(); 1621 SwapBuffersComplete();
1622 EXPECT_TRUE(resource_provider_->InUseByConsumer(resource1));
1623 EXPECT_TRUE(resource_provider_->InUseByConsumer(resource2));
1624 EXPECT_TRUE(resource_provider_->InUseByConsumer(resource3));
1625
1626 // This completion corresponds to the second frame. The first resource is no
1627 // longer in use.
1628 ReturnResourceInUseQuery(resource1);
1629 SwapBuffersComplete();
1613 EXPECT_FALSE(resource_provider_->InUseByConsumer(resource1)); 1630 EXPECT_FALSE(resource_provider_->InUseByConsumer(resource1));
1614 EXPECT_TRUE(resource_provider_->InUseByConsumer(resource2)); 1631 EXPECT_TRUE(resource_provider_->InUseByConsumer(resource2));
1615 EXPECT_TRUE(resource_provider_->InUseByConsumer(resource3)); 1632 EXPECT_TRUE(resource_provider_->InUseByConsumer(resource3));
1616 1633
1617 // This completion corresponds to the second frame. 1634 // This completion corresponds to the third frame.
1618 SwapBuffersComplete(); 1635 SwapBuffersComplete();
1619 EXPECT_FALSE(resource_provider_->InUseByConsumer(resource1)); 1636 EXPECT_FALSE(resource_provider_->InUseByConsumer(resource1));
1620 EXPECT_FALSE(resource_provider_->InUseByConsumer(resource2)); 1637 EXPECT_TRUE(resource_provider_->InUseByConsumer(resource2));
1621 EXPECT_TRUE(resource_provider_->InUseByConsumer(resource3)); 1638 EXPECT_TRUE(resource_provider_->InUseByConsumer(resource3));
1622 1639
1623 // This completion corresponds to the third frame. 1640 ReturnResourceInUseQuery(resource2);
1624 SwapBuffersComplete(); 1641 ReturnResourceInUseQuery(resource3);
1625 EXPECT_FALSE(resource_provider_->InUseByConsumer(resource1)); 1642 EXPECT_FALSE(resource_provider_->InUseByConsumer(resource1));
1626 EXPECT_FALSE(resource_provider_->InUseByConsumer(resource2)); 1643 EXPECT_FALSE(resource_provider_->InUseByConsumer(resource2));
1627 EXPECT_FALSE(resource_provider_->InUseByConsumer(resource3)); 1644 EXPECT_FALSE(resource_provider_->InUseByConsumer(resource3));
1628 } 1645 }
1629 1646
1630 } // namespace 1647 } // namespace
1631 } // namespace cc 1648 } // namespace cc
OLDNEW
« no previous file with comments | « cc/output/output_surface_client.h ('k') | cc/output/renderer_settings.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698