Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Issue 206133005: Remove 3-args |SVGAnimatedLength::baseValueToString()| impl. (Closed)

Created:
6 years, 9 months ago by kouhei (in TOK)
Modified:
6 years, 9 months ago
Reviewers:
haraken, pdr., fs
CC:
blink-reviews, ed+blinkwatch_opera.com, shans, rjwright, alancutter (OOO until 2018), Mike Lawther (Google), rwlbuis, fs, kouhei+svg_chromium.org, dstockwell, Timothy Loh, krit, f(malita), gyuyoung.kim_webkit.org, darktears, Stephen Chennney, Steve Block, dino_apple.com, pdr., Eric Willigers
Visibility:
Public.

Description

Remove 3-args |SVGAnimatedLength::baseValueToString()| impl. This CL is to prepare for auto-dispatching baseValueToString in SVG*Element::parseAttribute. SVGAnimatedLength required {Forbid,Allow}NegativeValues setting to be passed in as an argument of baseValueToString. This was making auto-dispatch for baseValueToString calls difficult. This CL removes the SVGLengthNegativeValuesMode argument from |SVGAnimatedLength::baseValueToString()|. The setting is passed in by |SVGAnimatedLength| ctor. BUG=349370 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169648

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+144 lines, -140 lines) Patch
M Source/core/svg/SVGAnimatedLength.h View 1 chunk +8 lines, -4 lines 0 comments Download
M Source/core/svg/SVGAnimatedLength.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGCircleElement.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M Source/core/svg/SVGCursorElement.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/svg/SVGEllipseElement.cpp View 2 chunks +8 lines, -8 lines 0 comments Download
M Source/core/svg/SVGFilterElement.cpp View 2 chunks +8 lines, -8 lines 0 comments Download
M Source/core/svg/SVGFilterPrimitiveStandardAttributes.cpp View 2 chunks +8 lines, -8 lines 0 comments Download
M Source/core/svg/SVGForeignObjectElement.cpp View 2 chunks +8 lines, -8 lines 0 comments Download
M Source/core/svg/SVGImageElement.cpp View 2 chunks +8 lines, -8 lines 0 comments Download
M Source/core/svg/SVGLineElement.cpp View 2 chunks +8 lines, -8 lines 0 comments Download
M Source/core/svg/SVGLinearGradientElement.cpp View 2 chunks +8 lines, -8 lines 0 comments Download
M Source/core/svg/SVGMarkerElement.cpp View 2 chunks +8 lines, -8 lines 0 comments Download
M Source/core/svg/SVGMaskElement.cpp View 2 chunks +8 lines, -8 lines 0 comments Download
M Source/core/svg/SVGPatternElement.cpp View 2 chunks +8 lines, -8 lines 0 comments Download
M Source/core/svg/SVGRadialGradientElement.cpp View 2 chunks +12 lines, -12 lines 0 comments Download
M Source/core/svg/SVGRectElement.cpp View 2 chunks +12 lines, -12 lines 0 comments Download
M Source/core/svg/SVGSVGElement.cpp View 2 chunks +8 lines, -8 lines 0 comments Download
M Source/core/svg/SVGTextContentElement.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGTextPathElement.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGUseElement.cpp View 2 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
kouhei (in TOK)
Would you take a look?
6 years, 9 months ago (2014-03-20 11:11:10 UTC) #1
haraken
LGTM
6 years, 9 months ago (2014-03-20 11:24:58 UTC) #2
kouhei (in TOK)
The CQ bit was checked by kouhei@chromium.org
6 years, 9 months ago (2014-03-20 11:27:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kouhei@chromium.org/206133005/1
6 years, 9 months ago (2014-03-20 11:27:06 UTC) #4
commit-bot: I haz the power
6 years, 9 months ago (2014-03-20 12:28:47 UTC) #5
Message was sent while issue was closed.
Change committed as 169648

Powered by Google App Engine
This is Rietveld 408576698