Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1247)

Unified Diff: Source/core/svg/SVGFilterPrimitiveStandardAttributes.cpp

Issue 206133005: Remove 3-args |SVGAnimatedLength::baseValueToString()| impl. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/svg/SVGFilterElement.cpp ('k') | Source/core/svg/SVGForeignObjectElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/svg/SVGFilterPrimitiveStandardAttributes.cpp
diff --git a/Source/core/svg/SVGFilterPrimitiveStandardAttributes.cpp b/Source/core/svg/SVGFilterPrimitiveStandardAttributes.cpp
index 95d3e51e6fd78508eac5a09e229e134414878aa9..0536763a3b418d11409ad74a234cbcd308a21e5b 100644
--- a/Source/core/svg/SVGFilterPrimitiveStandardAttributes.cpp
+++ b/Source/core/svg/SVGFilterPrimitiveStandardAttributes.cpp
@@ -33,10 +33,10 @@ namespace WebCore {
SVGFilterPrimitiveStandardAttributes::SVGFilterPrimitiveStandardAttributes(const QualifiedName& tagName, Document& document)
: SVGElement(tagName, document)
- , m_x(SVGAnimatedLength::create(this, SVGNames::xAttr, SVGLength::create(LengthModeWidth)))
- , m_y(SVGAnimatedLength::create(this, SVGNames::yAttr, SVGLength::create(LengthModeHeight)))
- , m_width(SVGAnimatedLength::create(this, SVGNames::widthAttr, SVGLength::create(LengthModeWidth)))
- , m_height(SVGAnimatedLength::create(this, SVGNames::heightAttr, SVGLength::create(LengthModeHeight)))
+ , m_x(SVGAnimatedLength::create(this, SVGNames::xAttr, SVGLength::create(LengthModeWidth), AllowNegativeLengths))
+ , m_y(SVGAnimatedLength::create(this, SVGNames::yAttr, SVGLength::create(LengthModeHeight), AllowNegativeLengths))
+ , m_width(SVGAnimatedLength::create(this, SVGNames::widthAttr, SVGLength::create(LengthModeWidth), ForbidNegativeLengths))
+ , m_height(SVGAnimatedLength::create(this, SVGNames::heightAttr, SVGLength::create(LengthModeHeight), ForbidNegativeLengths))
, m_result(SVGAnimatedString::create(this, SVGNames::resultAttr, SVGString::create()))
{
// Spec: If the x/y attribute is not specified, the effect is as if a value of "0%" were specified.
@@ -74,13 +74,13 @@ void SVGFilterPrimitiveStandardAttributes::parseAttribute(const QualifiedName& n
if (!isSupportedAttribute(name))
SVGElement::parseAttribute(name, value);
else if (name == SVGNames::xAttr)
- m_x->setBaseValueAsString(value, AllowNegativeLengths, parseError);
+ m_x->setBaseValueAsString(value, parseError);
else if (name == SVGNames::yAttr)
- m_y->setBaseValueAsString(value, AllowNegativeLengths, parseError);
+ m_y->setBaseValueAsString(value, parseError);
else if (name == SVGNames::widthAttr)
- m_width->setBaseValueAsString(value, ForbidNegativeLengths, parseError);
+ m_width->setBaseValueAsString(value, parseError);
else if (name == SVGNames::heightAttr)
- m_height->setBaseValueAsString(value, ForbidNegativeLengths, parseError);
+ m_height->setBaseValueAsString(value, parseError);
else if (name == SVGNames::resultAttr)
m_result->setBaseValueAsString(value, parseError);
else
« no previous file with comments | « Source/core/svg/SVGFilterElement.cpp ('k') | Source/core/svg/SVGForeignObjectElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698