Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(839)

Unified Diff: Source/core/svg/SVGFilterElement.cpp

Issue 206133005: Remove 3-args |SVGAnimatedLength::baseValueToString()| impl. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/svg/SVGEllipseElement.cpp ('k') | Source/core/svg/SVGFilterPrimitiveStandardAttributes.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/svg/SVGFilterElement.cpp
diff --git a/Source/core/svg/SVGFilterElement.cpp b/Source/core/svg/SVGFilterElement.cpp
index 1e80d2e980e95113b0c6e98925be050ce12d63ae..2a1209989784750454ce05cd66e918812e487f89 100644
--- a/Source/core/svg/SVGFilterElement.cpp
+++ b/Source/core/svg/SVGFilterElement.cpp
@@ -35,10 +35,10 @@ namespace WebCore {
inline SVGFilterElement::SVGFilterElement(Document& document)
: SVGElement(SVGNames::filterTag, document)
, SVGURIReference(this)
- , m_x(SVGAnimatedLength::create(this, SVGNames::xAttr, SVGLength::create(LengthModeWidth)))
- , m_y(SVGAnimatedLength::create(this, SVGNames::yAttr, SVGLength::create(LengthModeHeight)))
- , m_width(SVGAnimatedLength::create(this, SVGNames::widthAttr, SVGLength::create(LengthModeWidth)))
- , m_height(SVGAnimatedLength::create(this, SVGNames::heightAttr, SVGLength::create(LengthModeHeight)))
+ , m_x(SVGAnimatedLength::create(this, SVGNames::xAttr, SVGLength::create(LengthModeWidth), AllowNegativeLengths))
+ , m_y(SVGAnimatedLength::create(this, SVGNames::yAttr, SVGLength::create(LengthModeHeight), AllowNegativeLengths))
+ , m_width(SVGAnimatedLength::create(this, SVGNames::widthAttr, SVGLength::create(LengthModeWidth), ForbidNegativeLengths))
+ , m_height(SVGAnimatedLength::create(this, SVGNames::heightAttr, SVGLength::create(LengthModeHeight), ForbidNegativeLengths))
, m_filterUnits(SVGAnimatedEnumeration<SVGUnitTypes::SVGUnitType>::create(this, SVGNames::filterUnitsAttr, SVGUnitTypes::SVG_UNIT_TYPE_OBJECTBOUNDINGBOX))
, m_primitiveUnits(SVGAnimatedEnumeration<SVGUnitTypes::SVGUnitType>::create(this, SVGNames::primitiveUnitsAttr, SVGUnitTypes::SVG_UNIT_TYPE_USERSPACEONUSE))
, m_filterRes(SVGAnimatedIntegerOptionalInteger::create(this, SVGNames::filterResAttr))
@@ -102,13 +102,13 @@ void SVGFilterElement::parseAttribute(const QualifiedName& name, const AtomicStr
else if (name == SVGNames::primitiveUnitsAttr)
m_primitiveUnits->setBaseValueAsString(value, parseError);
else if (name == SVGNames::xAttr)
- m_x->setBaseValueAsString(value, AllowNegativeLengths, parseError);
+ m_x->setBaseValueAsString(value, parseError);
else if (name == SVGNames::yAttr)
- m_y->setBaseValueAsString(value, AllowNegativeLengths, parseError);
+ m_y->setBaseValueAsString(value, parseError);
else if (name == SVGNames::widthAttr)
- m_width->setBaseValueAsString(value, ForbidNegativeLengths, parseError);
+ m_width->setBaseValueAsString(value, parseError);
else if (name == SVGNames::heightAttr)
- m_height->setBaseValueAsString(value, ForbidNegativeLengths, parseError);
+ m_height->setBaseValueAsString(value, parseError);
else if (name == SVGNames::filterResAttr)
m_filterRes->setBaseValueAsString(value, parseError);
else if (SVGURIReference::parseAttribute(name, value, parseError)) {
« no previous file with comments | « Source/core/svg/SVGEllipseElement.cpp ('k') | Source/core/svg/SVGFilterPrimitiveStandardAttributes.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698