Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(920)

Unified Diff: Source/core/svg/SVGAnimatedLength.cpp

Issue 206133005: Remove 3-args |SVGAnimatedLength::baseValueToString()| impl. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/svg/SVGAnimatedLength.h ('k') | Source/core/svg/SVGCircleElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/svg/SVGAnimatedLength.cpp
diff --git a/Source/core/svg/SVGAnimatedLength.cpp b/Source/core/svg/SVGAnimatedLength.cpp
index bc447b07280ebfb8d410374e1bd403a14d4851cc..097c96decd7e9d5e4c4ec4a0d10c624207cb863f 100644
--- a/Source/core/svg/SVGAnimatedLength.cpp
+++ b/Source/core/svg/SVGAnimatedLength.cpp
@@ -39,7 +39,7 @@ void SVGAnimatedLength::setDefaultValueAsString(const String& value)
baseValue()->setValueAsString(value, ASSERT_NO_EXCEPTION);
}
-void SVGAnimatedLength::setBaseValueAsString(const String& value, SVGLengthNegativeValuesMode mode, SVGParsingError& parseError)
+void SVGAnimatedLength::setBaseValueAsString(const String& value, SVGParsingError& parseError)
{
TrackExceptionState es;
@@ -48,7 +48,7 @@ void SVGAnimatedLength::setBaseValueAsString(const String& value, SVGLengthNegat
if (es.hadException()) {
parseError = ParsingAttributeFailedError;
baseValue()->newValueSpecifiedUnits(LengthTypeNumber, 0);
- } else if (mode == ForbidNegativeLengths && baseValue()->valueInSpecifiedUnits() < 0) {
+ } else if (m_negativeValuesMode == ForbidNegativeLengths && baseValue()->valueInSpecifiedUnits() < 0) {
parseError = NegativeValueForbiddenError;
}
}
« no previous file with comments | « Source/core/svg/SVGAnimatedLength.h ('k') | Source/core/svg/SVGCircleElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698