Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Side by Side Diff: Source/core/svg/SVGAnimatedLength.cpp

Issue 206133005: Remove 3-args |SVGAnimatedLength::baseValueToString()| impl. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/svg/SVGAnimatedLength.h ('k') | Source/core/svg/SVGCircleElement.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2014 Google Inc. All rights reserved. 2 * Copyright (C) 2014 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 21 matching lines...) Expand all
32 32
33 #include "core/svg/SVGAnimatedLength.h" 33 #include "core/svg/SVGAnimatedLength.h"
34 34
35 namespace WebCore { 35 namespace WebCore {
36 36
37 void SVGAnimatedLength::setDefaultValueAsString(const String& value) 37 void SVGAnimatedLength::setDefaultValueAsString(const String& value)
38 { 38 {
39 baseValue()->setValueAsString(value, ASSERT_NO_EXCEPTION); 39 baseValue()->setValueAsString(value, ASSERT_NO_EXCEPTION);
40 } 40 }
41 41
42 void SVGAnimatedLength::setBaseValueAsString(const String& value, SVGLengthNegat iveValuesMode mode, SVGParsingError& parseError) 42 void SVGAnimatedLength::setBaseValueAsString(const String& value, SVGParsingErro r& parseError)
43 { 43 {
44 TrackExceptionState es; 44 TrackExceptionState es;
45 45
46 baseValue()->setValueAsString(value, es); 46 baseValue()->setValueAsString(value, es);
47 47
48 if (es.hadException()) { 48 if (es.hadException()) {
49 parseError = ParsingAttributeFailedError; 49 parseError = ParsingAttributeFailedError;
50 baseValue()->newValueSpecifiedUnits(LengthTypeNumber, 0); 50 baseValue()->newValueSpecifiedUnits(LengthTypeNumber, 0);
51 } else if (mode == ForbidNegativeLengths && baseValue()->valueInSpecifiedUni ts() < 0) { 51 } else if (m_negativeValuesMode == ForbidNegativeLengths && baseValue()->val ueInSpecifiedUnits() < 0) {
52 parseError = NegativeValueForbiddenError; 52 parseError = NegativeValueForbiddenError;
53 } 53 }
54 } 54 }
55 55
56 } 56 }
OLDNEW
« no previous file with comments | « Source/core/svg/SVGAnimatedLength.h ('k') | Source/core/svg/SVGCircleElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698