Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Side by Side Diff: Source/core/svg/SVGLineElement.cpp

Issue 206133005: Remove 3-args |SVGAnimatedLength::baseValueToString()| impl. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/svg/SVGImageElement.cpp ('k') | Source/core/svg/SVGLinearGradientElement.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2006, 2008 Nikolas Zimmermann <zimmermann@kde.org> 2 * Copyright (C) 2004, 2005, 2006, 2008 Nikolas Zimmermann <zimmermann@kde.org>
3 * Copyright (C) 2004, 2005, 2006, 2007 Rob Buis <buis@kde.org> 3 * Copyright (C) 2004, 2005, 2006, 2007 Rob Buis <buis@kde.org>
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
(...skipping 12 matching lines...) Expand all
23 #include "core/svg/SVGLineElement.h" 23 #include "core/svg/SVGLineElement.h"
24 24
25 #include "core/rendering/svg/RenderSVGResource.h" 25 #include "core/rendering/svg/RenderSVGResource.h"
26 #include "core/svg/SVGElementInstance.h" 26 #include "core/svg/SVGElementInstance.h"
27 #include "core/svg/SVGLength.h" 27 #include "core/svg/SVGLength.h"
28 28
29 namespace WebCore { 29 namespace WebCore {
30 30
31 inline SVGLineElement::SVGLineElement(Document& document) 31 inline SVGLineElement::SVGLineElement(Document& document)
32 : SVGGeometryElement(SVGNames::lineTag, document) 32 : SVGGeometryElement(SVGNames::lineTag, document)
33 , m_x1(SVGAnimatedLength::create(this, SVGNames::x1Attr, SVGLength::create(L engthModeWidth))) 33 , m_x1(SVGAnimatedLength::create(this, SVGNames::x1Attr, SVGLength::create(L engthModeWidth), AllowNegativeLengths))
34 , m_y1(SVGAnimatedLength::create(this, SVGNames::y1Attr, SVGLength::create(L engthModeHeight))) 34 , m_y1(SVGAnimatedLength::create(this, SVGNames::y1Attr, SVGLength::create(L engthModeHeight), AllowNegativeLengths))
35 , m_x2(SVGAnimatedLength::create(this, SVGNames::x2Attr, SVGLength::create(L engthModeWidth))) 35 , m_x2(SVGAnimatedLength::create(this, SVGNames::x2Attr, SVGLength::create(L engthModeWidth), AllowNegativeLengths))
36 , m_y2(SVGAnimatedLength::create(this, SVGNames::y2Attr, SVGLength::create(L engthModeHeight))) 36 , m_y2(SVGAnimatedLength::create(this, SVGNames::y2Attr, SVGLength::create(L engthModeHeight), AllowNegativeLengths))
37 { 37 {
38 ScriptWrappable::init(this); 38 ScriptWrappable::init(this);
39 39
40 addToPropertyMap(m_x1); 40 addToPropertyMap(m_x1);
41 addToPropertyMap(m_y1); 41 addToPropertyMap(m_y1);
42 addToPropertyMap(m_x2); 42 addToPropertyMap(m_x2);
43 addToPropertyMap(m_y2); 43 addToPropertyMap(m_y2);
44 } 44 }
45 45
46 PassRefPtr<SVGLineElement> SVGLineElement::create(Document& document) 46 PassRefPtr<SVGLineElement> SVGLineElement::create(Document& document)
(...skipping 13 matching lines...) Expand all
60 return supportedAttributes.contains<SVGAttributeHashTranslator>(attrName); 60 return supportedAttributes.contains<SVGAttributeHashTranslator>(attrName);
61 } 61 }
62 62
63 void SVGLineElement::parseAttribute(const QualifiedName& name, const AtomicStrin g& value) 63 void SVGLineElement::parseAttribute(const QualifiedName& name, const AtomicStrin g& value)
64 { 64 {
65 SVGParsingError parseError = NoError; 65 SVGParsingError parseError = NoError;
66 66
67 if (!isSupportedAttribute(name)) 67 if (!isSupportedAttribute(name))
68 SVGGeometryElement::parseAttribute(name, value); 68 SVGGeometryElement::parseAttribute(name, value);
69 else if (name == SVGNames::x1Attr) 69 else if (name == SVGNames::x1Attr)
70 m_x1->setBaseValueAsString(value, AllowNegativeLengths, parseError); 70 m_x1->setBaseValueAsString(value, parseError);
71 else if (name == SVGNames::y1Attr) 71 else if (name == SVGNames::y1Attr)
72 m_y1->setBaseValueAsString(value, AllowNegativeLengths, parseError); 72 m_y1->setBaseValueAsString(value, parseError);
73 else if (name == SVGNames::x2Attr) 73 else if (name == SVGNames::x2Attr)
74 m_x2->setBaseValueAsString(value, AllowNegativeLengths, parseError); 74 m_x2->setBaseValueAsString(value, parseError);
75 else if (name == SVGNames::y2Attr) 75 else if (name == SVGNames::y2Attr)
76 m_y2->setBaseValueAsString(value, AllowNegativeLengths, parseError); 76 m_y2->setBaseValueAsString(value, parseError);
77 else 77 else
78 ASSERT_NOT_REACHED(); 78 ASSERT_NOT_REACHED();
79 79
80 reportAttributeParsingError(parseError, name, value); 80 reportAttributeParsingError(parseError, name, value);
81 } 81 }
82 82
83 void SVGLineElement::svgAttributeChanged(const QualifiedName& attrName) 83 void SVGLineElement::svgAttributeChanged(const QualifiedName& attrName)
84 { 84 {
85 if (!isSupportedAttribute(attrName)) { 85 if (!isSupportedAttribute(attrName)) {
86 SVGGeometryElement::svgAttributeChanged(attrName); 86 SVGGeometryElement::svgAttributeChanged(attrName);
(...skipping 25 matching lines...) Expand all
112 112
113 bool SVGLineElement::selfHasRelativeLengths() const 113 bool SVGLineElement::selfHasRelativeLengths() const
114 { 114 {
115 return m_x1->currentValue()->isRelative() 115 return m_x1->currentValue()->isRelative()
116 || m_y1->currentValue()->isRelative() 116 || m_y1->currentValue()->isRelative()
117 || m_x2->currentValue()->isRelative() 117 || m_x2->currentValue()->isRelative()
118 || m_y2->currentValue()->isRelative(); 118 || m_y2->currentValue()->isRelative();
119 } 119 }
120 120
121 } 121 }
OLDNEW
« no previous file with comments | « Source/core/svg/SVGImageElement.cpp ('k') | Source/core/svg/SVGLinearGradientElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698