Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 2060833002: Implementation of 'AudioContext.getOutputTimestamp' method (Closed)

Created:
4 years, 6 months ago by Mikhail
Modified:
4 years ago
CC:
blink-reviews, blink-reviews-api_chromium.org, chcunningham, chromium-reviews, darin-cc_chromium.org, dglazkov+blink, feature-media-reviews_chromium.org, hongchan, jam, miu+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implementation of 'AudioContext.getOutputTimestamp' method The newly added 'AudioContext.getOutputTimestamp' method helps to bind audio context time and performance time values. This CL contains generic code which provides the audio output timestamp from the content layer to 'AudioContext' JS bindings. Link to specification: https://webaudio.github.io/web-audio-api/#widl-AudioContext-getOutputTimestamp-AudioTimestamp Intent to ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/fEWdrU4C-3Y BUG=619533 Committed: https://crrev.com/851c52f392dde2c5611453142c737839b65fe1ab Cr-Commit-Position: refs/heads/master@{#439553}

Patch Set 1 : Implementation of 'AudioContext.getOutputTimestamp' method #

Patch Set 2 : Implementation of 'AudioContext.getOutputTimestamp' method #

Total comments: 24

Patch Set 3 : review commnets + more tests fixes + 'Packet' structure #

Total comments: 1

Patch Set 4 : Added a layout test. Moved timetsamp update to 'handlePreRenderTasks()' #

Patch Set 5 : Fixed suspend/resume bug. Moved 'getOutputTimestamp' implementation to 'AudioContext'. Manual test. #

Patch Set 6 : Added implementation for ALSA. #

Total comments: 5

Patch Set 7 : New implementation #

Patch Set 8 : rebased 'global-interface-listing-expected' layout test results #

Patch Set 9 : rebased 'global-interface-listing-expected' layout test results #

Total comments: 20

Patch Set 10 : Comments from Raymond and miu@ #

Total comments: 5

Patch Set 11 : Comments from miu@ #

Total comments: 2

Patch Set 12 : Comment from Raymond #

Patch Set 13 : Improved manual test. Added layout test. More checks. #

Total comments: 1

Patch Set 14 : Comments from Raymond #

Patch Set 15 : global-interface-listing rebaseline #

Patch Set 16 : Rebased. #

Patch Set 17 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+317 lines, -17 lines) Patch
M content/renderer/media/renderer_webaudiodevice_impl.cc View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +11 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +1 line, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/webaudio/audiocontext-getoutputtimestamp.html View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +29 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/resources/context-properties.js View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +1 line, -0 lines 0 comments Download
A third_party/WebKit/ManualTests/webaudio/audiooutputtimestamp.html View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +133 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/modules_idl_files.gni View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 2 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioContext.h View 1 2 3 4 5 6 2 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioContext.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +31 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioContext.idl View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioDestinationNode.h View 1 2 3 4 5 6 7 8 9 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioDestinationNode.cpp View 1 2 3 4 5 6 2 chunks +3 lines, -2 lines 0 comments Download
A third_party/WebKit/Source/modules/webaudio/AudioTimestamp.idl View 1 2 3 4 5 6 7 8 9 1 chunk +9 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/BaseAudioContext.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 3 chunks +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webaudio/BaseAudioContext.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 5 chunks +15 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/audio/AudioDestination.h View 1 2 3 4 5 6 10 2 chunks +8 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/audio/AudioDestination.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 5 chunks +34 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/audio/AudioIOCallback.h View 1 2 3 4 5 6 2 chunks +12 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/exported/WebAudioDevice.cpp View 1 2 3 4 5 6 1 chunk +4 lines, -1 line 0 comments Download
M third_party/WebKit/public/platform/WebAudioDevice.h View 1 2 3 4 5 6 7 8 9 10 1 chunk +9 lines, -2 lines 0 comments Download

Messages

Total messages: 151 (77 generated)
Raymond Toy
Can you rebase your CL before I review it? Looks like almost all bots are ...
4 years, 6 months ago (2016-06-13 16:04:25 UTC) #6
Mikhail
On 2016/06/13 16:04:25, Raymond Toy wrote: > Can you rebase your CL before I review ...
4 years, 6 months ago (2016-06-14 14:18:01 UTC) #9
Raymond Toy
An initial review. You'll need someone else to do a real review of the media/ ...
4 years, 6 months ago (2016-06-14 16:42:41 UTC) #10
hongchan
https://codereview.chromium.org/2060833002/diff/110001/content/renderer/media/renderer_webaudiodevice_impl.cc File content/renderer/media/renderer_webaudiodevice_impl.cc (right): https://codereview.chromium.org/2060833002/diff/110001/content/renderer/media/renderer_webaudiodevice_impl.cc#newcode128 content/renderer/media/renderer_webaudiodevice_impl.cc:128: WebAudioTimestamp web_timestamp(static_cast<size_t>(timestamp.frames), Perhaps web_audio_timestamp is better? https://codereview.chromium.org/2060833002/diff/110001/media/audio/audio_device_thread.h File media/audio/audio_device_thread.h ...
4 years, 6 months ago (2016-06-14 17:10:38 UTC) #11
Mikhail
Thanks for your comments! https://codereview.chromium.org/2060833002/diff/110001/content/renderer/media/renderer_webaudiodevice_impl.cc File content/renderer/media/renderer_webaudiodevice_impl.cc (right): https://codereview.chromium.org/2060833002/diff/110001/content/renderer/media/renderer_webaudiodevice_impl.cc#newcode128 content/renderer/media/renderer_webaudiodevice_impl.cc:128: WebAudioTimestamp web_timestamp(static_cast<size_t>(timestamp.frames), On 2016/06/14 17:10:38, ...
4 years, 6 months ago (2016-06-17 09:36:57 UTC) #13
Raymond Toy
https://codereview.chromium.org/2060833002/diff/110001/media/audio/audio_output_controller.cc File media/audio/audio_output_controller.cc (right): https://codereview.chromium.org/2060833002/diff/110001/media/audio/audio_output_controller.cc#newcode176 media/audio/audio_output_controller.cc:176: sync_reader_->UpdatePendingBytes(0, 0, {0, 0}); On 2016/06/17 09:36:57, Mikhail wrote: ...
4 years, 6 months ago (2016-06-17 20:55:16 UTC) #14
Raymond Toy
Do you have a test for this? I think some kind of test is important ...
4 years, 6 months ago (2016-06-17 20:56:35 UTC) #15
hongchan
I believe the experimental flag goes with 'a brief description'. Where can I find one ...
4 years, 6 months ago (2016-06-20 16:05:22 UTC) #16
Mikhail
On 2016/06/17 20:56:35, Raymond Toy wrote: > Do you have a test for this? I ...
4 years, 6 months ago (2016-06-22 16:58:27 UTC) #17
Mikhail
On 2016/06/20 16:05:22, hoch wrote: > I believe the experimental flag goes with 'a brief ...
4 years, 6 months ago (2016-06-22 17:00:45 UTC) #18
Mikhail
Could you pls have a look?
4 years, 5 months ago (2016-06-28 10:10:16 UTC) #19
Raymond Toy
On 2016/06/28 10:10:16, Mikhail wrote: > Could you pls have a look? I'm trying to ...
4 years, 5 months ago (2016-06-29 20:57:05 UTC) #20
Raymond Toy
On 2016/06/28 10:10:16, Mikhail wrote: > Could you pls have a look? I'm trying to ...
4 years, 5 months ago (2016-06-29 20:57:10 UTC) #21
Mikhail
On 2016/06/29 20:57:10, Raymond Toy wrote: > On 2016/06/28 10:10:16, Mikhail wrote: > > Could ...
4 years, 5 months ago (2016-07-03 18:45:14 UTC) #23
Raymond Toy
On 2016/07/03 18:45:14, Mikhail wrote: > On 2016/06/29 20:57:10, Raymond Toy wrote: > > On ...
4 years, 5 months ago (2016-07-07 17:09:51 UTC) #24
Mikhail
On 2016/07/07 17:09:51, Raymond Toy wrote: > > Are the changes for the platform-specific parts ...
4 years, 5 months ago (2016-07-11 15:14:27 UTC) #25
Raymond Toy
On 2016/07/11 15:14:27, Mikhail wrote: > On 2016/07/07 17:09:51, Raymond Toy wrote: > > > ...
4 years, 5 months ago (2016-07-11 15:17:12 UTC) #26
Mikhail
On 2016/07/11 15:17:12, Raymond Toy wrote: > > Up to you. I do use win ...
4 years, 5 months ago (2016-07-12 14:26:21 UTC) #27
Raymond Toy
Yeah that's fine with me. I'm out for the next couple of days but I'll ...
4 years, 5 months ago (2016-07-12 14:51:04 UTC) #28
Raymond Toy
Yeah that's fine with me. I'm out for the next couple of days but I'll ...
4 years, 5 months ago (2016-07-12 14:51:04 UTC) #29
Mikhail
CC'ing tommi@chromium.org and sandersd@chromium.org for review of the media/ code.
4 years, 5 months ago (2016-07-14 09:10:13 UTC) #31
sandersd (OOO until July 31)
To chcunningham@ for media/.
4 years, 5 months ago (2016-07-18 23:42:42 UTC) #33
DaleCurtis
This and https://codereview.chromium.org/2101303004 need to be reconciled.
4 years, 5 months ago (2016-07-18 23:57:47 UTC) #35
DaleCurtis
Also seems to be missing implementations for mac/android?
4 years, 5 months ago (2016-07-18 23:59:09 UTC) #36
miu
https://codereview.chromium.org/2060833002/diff/230001/media/audio/audio_io.h File media/audio/audio_io.h (right): https://codereview.chromium.org/2060833002/diff/230001/media/audio/audio_io.h#newcode54 media/audio/audio_io.h:54: int64_t frames; Why do we need this? Client code ...
4 years, 5 months ago (2016-07-19 01:22:36 UTC) #37
jameswest
https://codereview.chromium.org/2060833002/diff/230001/media/audio/audio_io.h File media/audio/audio_io.h (right): https://codereview.chromium.org/2060833002/diff/230001/media/audio/audio_io.h#newcode82 media/audio/audio_io.h:82: uint32_t frames_skipped, We're in favor of changing the API ...
4 years, 5 months ago (2016-07-20 04:19:18 UTC) #39
miu
Catching up on code reviews. Sorry for the delay. However, it's not clear whether we ...
4 years, 4 months ago (2016-07-30 21:17:33 UTC) #40
Mikhail
On 2016/07/20 04:19:18, James West wrote: > https://codereview.chromium.org/2060833002/diff/230001/media/audio/audio_io.h > File media/audio/audio_io.h (right): > > https://codereview.chromium.org/2060833002/diff/230001/media/audio/audio_io.h#newcode82 ...
4 years, 4 months ago (2016-08-05 12:05:22 UTC) #41
jameswest
On 2016/08/05 12:05:22, Mikhail wrote: > On 2016/07/20 04:19:18, James West wrote: > > https://codereview.chromium.org/2060833002/diff/230001/media/audio/audio_io.h ...
4 years, 4 months ago (2016-08-06 02:13:18 UTC) #42
Mikhail
On 2016/08/06 02:13:18, James West wrote: > > I'm not sure our change is really ...
4 years, 4 months ago (2016-08-08 11:39:47 UTC) #43
miu
On 2016/08/05 12:05:22, Mikhail wrote: > The intention of this CL is to bring a ...
4 years, 4 months ago (2016-08-11 23:36:15 UTC) #44
Mikhail
On 2016/08/11 23:36:15, miu wrote: > On 2016/08/05 12:05:22, Mikhail wrote: > > The intention ...
4 years, 4 months ago (2016-08-12 13:10:46 UTC) #45
Mikhail
On 2016/08/12 13:10:46, Mikhail wrote: > On 2016/08/11 23:36:15, miu wrote: > > On 2016/08/05 ...
4 years, 3 months ago (2016-08-31 18:04:22 UTC) #46
miu
On 2016/08/31 18:04:22, Mikhail wrote: > miu@ : how could we proceed with that? Hi. ...
4 years, 3 months ago (2016-09-01 05:23:44 UTC) #47
Mikhail
On 2016/09/01 05:23:44, miu wrote: > On 2016/08/31 18:04:22, Mikhail wrote: > > miu@ : ...
4 years, 3 months ago (2016-09-07 09:24:26 UTC) #48
miu
Okay. I reviewed the spec and all the Blink code changes, and I think I ...
4 years, 3 months ago (2016-09-07 22:03:31 UTC) #49
Mikhail
On 2016/09/07 22:03:31, miu wrote: > > I've gone through a whole bunch of steps ...
4 years, 3 months ago (2016-09-08 08:20:24 UTC) #50
miu
On 2016/09/08 08:20:24, Mikhail wrote: > On 2016/09/07 22:03:31, miu wrote: > 'AudioContext.getOutputTimestamp' should provide ...
4 years, 3 months ago (2016-09-08 21:10:45 UTC) #51
miu
On 2016/09/08 21:10:45, miu wrote: > On 2016/09/08 08:20:24, Mikhail wrote: > However, shouldn't that ...
4 years, 3 months ago (2016-09-08 21:14:52 UTC) #52
haraken
https://codereview.chromium.org/2060833002/diff/230001/third_party/WebKit/Source/modules/webaudio/AudioTimestamp.idl File third_party/WebKit/Source/modules/webaudio/AudioTimestamp.idl (right): https://codereview.chromium.org/2060833002/diff/230001/third_party/WebKit/Source/modules/webaudio/AudioTimestamp.idl#newcode6 third_party/WebKit/Source/modules/webaudio/AudioTimestamp.idl:6: Conditional=AudioTimestamp We no longer support [Conditional]. I think this ...
4 years, 3 months ago (2016-09-08 23:38:20 UTC) #54
Mikhail
After https://codereview.chromium.org/2101303004/ has landed I'm going to split the implementation. The first part is at ...
4 years, 2 months ago (2016-10-20 18:10:46 UTC) #55
Mikhail
The latest patch contains the updated implementation which is inspired by the comment from miu@ ...
4 years, 1 month ago (2016-10-31 19:40:05 UTC) #56
Mikhail
On 2016/10/31 19:40:05, Mikhail wrote: > The latest patch contains the updated implementation which is ...
4 years, 1 month ago (2016-11-02 14:46:51 UTC) #71
miu
I'm intending to take a look too. :) I'm just swamped on other things. Will ...
4 years, 1 month ago (2016-11-02 23:36:37 UTC) #72
Raymond Toy
https://codereview.chromium.org/2060833002/diff/290001/third_party/WebKit/ManualTests/webaudio/audiooutputtimestamp.html File third_party/WebKit/ManualTests/webaudio/audiooutputtimestamp.html (right): https://codereview.chromium.org/2060833002/diff/290001/third_party/WebKit/ManualTests/webaudio/audiooutputtimestamp.html#newcode33 third_party/WebKit/ManualTests/webaudio/audiooutputtimestamp.html:33: and compare them to 'AudioContext.currentTime' and 'Performance.now()'. </p> Please ...
4 years, 1 month ago (2016-11-04 17:51:40 UTC) #73
miu
https://codereview.chromium.org/2060833002/diff/290001/content/renderer/media/renderer_webaudiodevice_impl.cc File content/renderer/media/renderer_webaudiodevice_impl.cc (right): https://codereview.chromium.org/2060833002/diff/290001/content/renderer/media/renderer_webaudiodevice_impl.cc#newcode114 content/renderer/media/renderer_webaudiodevice_impl.cc:114: delay -= media::AudioTimestampHelper::FramesToTime(dest->frames(), Is this correct? I thought |delay| ...
4 years, 1 month ago (2016-11-04 21:29:40 UTC) #74
Mikhail
Thank you for your comments! I'll upload the new patch shortly. https://codereview.chromium.org/2060833002/diff/290001/content/renderer/media/renderer_webaudiodevice_impl.cc File content/renderer/media/renderer_webaudiodevice_impl.cc (right): ...
4 years, 1 month ago (2016-11-07 18:28:03 UTC) #75
miu
The timing logic is a complex problem. I could be right or wrong here, but ...
4 years, 1 month ago (2016-11-07 23:49:40 UTC) #76
miu
BTW--Your earlier change (https://codereview.chromium.org/2437863004/) got reverted shortly after landing. Looks like an issue with speech ...
4 years, 1 month ago (2016-11-07 23:51:37 UTC) #77
Raymond Toy
https://codereview.chromium.org/2060833002/diff/290001/third_party/WebKit/Source/platform/audio/AudioDestination.cpp File third_party/WebKit/Source/platform/audio/AudioDestination.cpp (right): https://codereview.chromium.org/2060833002/diff/290001/third_party/WebKit/Source/platform/audio/AudioDestination.cpp#newcode222 third_party/WebKit/Source/platform/audio/AudioDestination.cpp:222: if (m_callbackBufferSize > framesToProcess * 2) { On 2016/11/07 ...
4 years, 1 month ago (2016-11-08 20:47:01 UTC) #78
Mikhail
Thank you for your comments and sorry about the delay. https://codereview.chromium.org/2060833002/diff/290001/content/renderer/media/renderer_webaudiodevice_impl.cc File content/renderer/media/renderer_webaudiodevice_impl.cc (right): https://codereview.chromium.org/2060833002/diff/290001/content/renderer/media/renderer_webaudiodevice_impl.cc#newcode114 ...
4 years ago (2016-11-28 15:15:59 UTC) #80
miu
lgtm, but with a concern about the "output position fudging" logic in AudioDestination::provideInput(). I leave ...
4 years ago (2016-11-29 20:51:04 UTC) #81
miu
lgtm, but with a concern about the "output position fudging" logic in AudioDestination::provideInput(). I leave ...
4 years ago (2016-11-29 20:51:06 UTC) #82
Mikhail
On 2016/11/29 20:51:04, miu wrote: > Right, but consider: > > 1. The outputPosition will ...
4 years ago (2016-11-30 14:49:30 UTC) #83
miu
On 2016/11/30 14:49:30, Mikhail wrote: > Thanks for your comments and proposals! I would agree ...
4 years ago (2016-11-30 20:36:47 UTC) #84
Raymond Toy
On 2016/11/30 20:36:47, miu wrote: > On 2016/11/30 14:49:30, Mikhail wrote: > > Thanks for ...
4 years ago (2016-12-01 00:18:47 UTC) #85
miu
On 2016/12/01 00:18:47, Raymond Toy wrote: > (And our current UMA stats show that there ...
4 years ago (2016-12-01 05:31:26 UTC) #86
miu
https://codereview.chromium.org/2060833002/diff/330001/third_party/WebKit/Source/platform/audio/AudioDestination.h File third_party/WebKit/Source/platform/audio/AudioDestination.h (right): https://codereview.chromium.org/2060833002/diff/330001/third_party/WebKit/Source/platform/audio/AudioDestination.h#newcode86 third_party/WebKit/Source/platform/audio/AudioDestination.h:86: double delay, // Output delay in seconds. On 2016/11/29 ...
4 years ago (2016-12-01 05:33:17 UTC) #87
Raymond Toy
On 2016/12/01 05:31:26, miu wrote: > On 2016/12/01 00:18:47, Raymond Toy wrote: > > (And ...
4 years ago (2016-12-01 16:11:33 UTC) #88
sandersd (OOO until July 31)
content/renderer/media/ lgtm % question about timestamp representation. https://codereview.chromium.org/2060833002/diff/330001/third_party/WebKit/public/platform/WebAudioDevice.h File third_party/WebKit/public/platform/WebAudioDevice.h (right): https://codereview.chromium.org/2060833002/diff/330001/third_party/WebKit/public/platform/WebAudioDevice.h#newcode47 third_party/WebKit/public/platform/WebAudioDevice.h:47: double delayTimestamp, ...
4 years ago (2016-12-01 23:55:00 UTC) #89
Mikhail
https://codereview.chromium.org/2060833002/diff/330001/third_party/WebKit/Source/platform/audio/AudioDestination.h File third_party/WebKit/Source/platform/audio/AudioDestination.h (right): https://codereview.chromium.org/2060833002/diff/330001/third_party/WebKit/Source/platform/audio/AudioDestination.h#newcode86 third_party/WebKit/Source/platform/audio/AudioDestination.h:86: double delay, // Output delay in seconds. On 2016/11/29 ...
4 years ago (2016-12-02 11:48:21 UTC) #90
chcunningham
Moved self to CC. sandersd@ has media covered
4 years ago (2016-12-02 21:53:21 UTC) #91
miu
PS11 totally lgtm! :)
4 years ago (2016-12-02 23:31:45 UTC) #93
Raymond Toy
lgtm for the WebAudio parts.
4 years ago (2016-12-05 17:21:35 UTC) #94
Raymond Toy
https://codereview.chromium.org/2060833002/diff/350001/third_party/WebKit/Source/modules/webaudio/BaseAudioContext.cpp File third_party/WebKit/Source/modules/webaudio/BaseAudioContext.cpp (right): https://codereview.chromium.org/2060833002/diff/350001/third_party/WebKit/Source/modules/webaudio/BaseAudioContext.cpp#newcode827 third_party/WebKit/Source/modules/webaudio/BaseAudioContext.cpp:827: AutoLocker locker(this); nit: Add a DCHECK that this can ...
4 years ago (2016-12-05 17:25:28 UTC) #95
Mikhail
haraken@, could you please take a look at modules_idl_files.gni and also platform/ changes? https://codereview.chromium.org/2060833002/diff/350001/third_party/WebKit/Source/modules/webaudio/BaseAudioContext.cpp File ...
4 years ago (2016-12-07 13:09:16 UTC) #96
haraken
LGTM
4 years ago (2016-12-07 14:36:55 UTC) #97
Mikhail
rtoy@: the latest CL contains improved manual test (now it better illustrates the actual synchronization ...
4 years ago (2016-12-13 20:48:32 UTC) #121
Raymond Toy
lgtm for webaudio with nit. I ran the manual test locally. I can't see the ...
4 years ago (2016-12-13 22:02:30 UTC) #122
Mikhail
Thanks for your comments! On 2016/12/13 22:02:30, Raymond Toy wrote: > lgtm for webaudio with ...
4 years ago (2016-12-15 15:10:05 UTC) #125
Rick Byers
webexposed/ test changes LGTM (added the link to the approved intent-to-ship to the CL description).
4 years ago (2016-12-16 20:15:51 UTC) #135
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2060833002/550001
4 years ago (2016-12-19 20:58:47 UTC) #146
commit-bot: I haz the power
Committed patchset #17 (id:550001)
4 years ago (2016-12-19 21:06:24 UTC) #149
commit-bot: I haz the power
4 years ago (2016-12-19 21:10:01 UTC) #151
Message was sent while issue was closed.
Patchset 17 (id:??) landed as
https://crrev.com/851c52f392dde2c5611453142c737839b65fe1ab
Cr-Commit-Position: refs/heads/master@{#439553}

Powered by Google App Engine
This is Rietveld 408576698