|
Move GLSurface creation from //ui/gl to //ui/gl/init.
Move the code that performs GLSurface creation to the new target. Remove
old surface creation code and delete static methods from GLSurface.
Add InitializeGLSurface() function to simplify a common pattern. When a
new GLSurface is created, it is wrapped in a scoped_refptr and then
initialized. If initialization fails nullptr is returned instead.
Encapsulate this logic into a function instead of repeating it.
There are three Ozone related GLSurface subclasses that defined in an
anonymous namespace. Instead of moving the class definitions to a header
file, public functions are added to create these types, as the classes
need to be refactored heavily.
These is almost the last part of step 2 in the associated bug. There
may be some other small refactor work moving parts of initialization
code from gl_implementation_<platform>.cc to
gl_initializer_<platform>.cc necessary.
BUG= 611142
Committed: https://crrev.com/f1f2cba219ff4ee3071c716f7add731a5c9e39ca
Cr-Commit-Position: refs/heads/master@{#399190}
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+520 lines, -623 lines) |
Patch |
|
M |
ui/gl/BUILD.gn
|
View
|
|
3 chunks |
+3 lines, -1 line |
0 comments
|
Download
|
|
M |
ui/gl/gl.gyp
|
View
|
1
2
3
4
|
2 chunks |
+3 lines, -1 line |
0 comments
|
Download
|
|
M |
ui/gl/gl_surface.h
|
View
|
|
2 chunks |
+6 lines, -22 lines |
0 comments
|
Download
|
|
M |
ui/gl/gl_surface.cc
|
View
|
|
1 chunk |
+6 lines, -0 lines |
0 comments
|
Download
|
|
M |
ui/gl/gl_surface_android.cc
|
View
|
1
2
3
|
1 chunk |
+0 lines, -63 lines |
0 comments
|
Download
|
|
D |
ui/gl/gl_surface_mac.cc
|
View
|
|
1 chunk |
+0 lines, -107 lines |
0 comments
|
Download
|
|
M |
ui/gl/gl_surface_osmesa.h
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
|
A |
ui/gl/gl_surface_osmesa_win.h
|
View
|
1
2
3
4
|
1 chunk |
+43 lines, -0 lines |
0 comments
|
Download
|
|
A |
ui/gl/gl_surface_osmesa_win.cc
|
View
|
|
1 chunk |
+131 lines, -0 lines |
0 comments
|
Download
|
|
A |
ui/gl/gl_surface_ozone.h
|
View
|
|
1 chunk |
+26 lines, -0 lines |
0 comments
|
Download
|
|
M |
ui/gl/gl_surface_ozone.cc
|
View
|
1
2
3
4
|
4 chunks |
+19 lines, -93 lines |
0 comments
|
Download
|
|
M |
ui/gl/gl_surface_wgl.h
|
View
|
1
2
3
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
ui/gl/gl_surface_win.cc
|
View
|
1
2
3
|
1 chunk |
+0 lines, -228 lines |
0 comments
|
Download
|
|
M |
ui/gl/gl_surface_x11.cc
|
View
|
|
1 chunk |
+1 line, -82 lines |
0 comments
|
Download
|
|
M |
ui/gl/init/BUILD.gn
|
View
|
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
|
M |
ui/gl/init/gl_factory.cc
|
View
|
|
2 chunks |
+0 lines, -21 lines |
0 comments
|
Download
|
|
M |
ui/gl/init/gl_factory_android.cc
|
View
|
1
|
3 chunks |
+47 lines, -1 line |
0 comments
|
Download
|
|
M |
ui/gl/init/gl_factory_mac.cc
|
View
|
1
|
2 chunks |
+76 lines, -0 lines |
0 comments
|
Download
|
|
M |
ui/gl/init/gl_factory_ozone.cc
|
View
|
1
2
3
4
5
|
2 chunks |
+61 lines, -0 lines |
0 comments
|
Download
|
|
M |
ui/gl/init/gl_factory_win.cc
|
View
|
1
2
|
2 chunks |
+50 lines, -0 lines |
0 comments
|
Download
|
|
M |
ui/gl/init/gl_factory_x11.cc
|
View
|
|
2 chunks |
+42 lines, -0 lines |
0 comments
|
Download
|
Total messages: 15 (8 generated)
|