Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Unified Diff: ui/gl/init/gl_factory.cc

Issue 2047283003: Move GLSurface creation from //ui/gl to //ui/gl/init. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@gl_context
Patch Set: Fix Ozone CreateViewGLSurface logic. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/gl/init/BUILD.gn ('k') | ui/gl/init/gl_factory_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/gl/init/gl_factory.cc
diff --git a/ui/gl/init/gl_factory.cc b/ui/gl/init/gl_factory.cc
index 09aa9d1692c5a9410d787d517d4f608b81b0ad80..bab99ea3ae0b5896f3bd1915c83332c0dcb68c43 100644
--- a/ui/gl/init/gl_factory.cc
+++ b/ui/gl/init/gl_factory.cc
@@ -10,7 +10,6 @@
#include "base/command_line.h"
#include "base/logging.h"
#include "base/trace_event/trace_event.h"
-#include "ui/gl/gl_context.h"
#include "ui/gl/gl_share_group.h"
#include "ui/gl/gl_surface.h"
#include "ui/gl/init/gl_initializer.h"
@@ -84,25 +83,5 @@ bool InitializeGLOneOffImplementation(GLImplementation impl,
return initialized;
}
-// TODO(kylechar): The functions below should be replaced with a platform
-// specific version for X11, Ozone, Windows, Mac and Android. The implementation
-// of each function should be moved into a platform specific file and the
-// original static functions should be removed from GLSurface and GLContext.
-
-scoped_refptr<GLSurface> CreateViewGLSurface(gfx::AcceleratedWidget window) {
- return GLSurface::CreateViewGLSurface(window);
-}
-
-#if defined(USE_OZONE)
-scoped_refptr<GLSurface> CreateSurfacelessViewGLSurface(
- gfx::AcceleratedWidget window) {
- return GLSurface::CreateSurfacelessViewGLSurface(window);
-}
-#endif // defined(USE_OZONE)
-
-scoped_refptr<GLSurface> CreateOffscreenGLSurface(const gfx::Size& size) {
- return GLSurface::CreateOffscreenGLSurface(size);
-}
-
} // namespace init
} // namespace gl
« no previous file with comments | « ui/gl/init/BUILD.gn ('k') | ui/gl/init/gl_factory_android.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698