Move GLSurface creation from //ui/gl to //ui/gl/init.

Move GLSurface creation from //ui/gl to //ui/gl/init.

Move the code that performs GLSurface creation to the new target. Remove
old surface creation code and delete static methods from GLSurface.

Add InitializeGLSurface() function to simplify a common pattern. When a
new GLSurface is created, it is wrapped in a scoped_refptr and then
initialized. If initialization fails nullptr is returned instead.
Encapsulate this logic into a function instead of repeating it.

There are three Ozone related GLSurface subclasses that defined in an
anonymous namespace. Instead of moving the class definitions to a header
file, public functions are added to create these types, as the classes
need to be refactored heavily.

These is almost the last part of step 2 in the associated bug.  There
may be some other small refactor work moving parts of initialization
code from gl_implementation_<platform>.cc to
gl_initializer_<platform>.cc necessary.

BUG=611142
Committed: https://crrev.com/f1f2cba219ff4ee3071c716f7add731a5c9e39ca
Cr-Commit-Position: refs/heads/master@{#399190}

[kylechar, 2016-06-08 15:05:28]

Description was changed from

==========
Move GLSurface creation from //ui/gl to //ui/gl/init.

Move the code that performs GLSurface creation to the new target. Remove
old surface creation code and delete static methods from GLSurface.

Add InitializeGLSurface() function to simplify a common pattern. When a
new GLSurface is created, it is wrapped in a scoped_refptr and then
initialized. If initialization fails nullptr is returned instead.
Encapsulate this logic into a function instead of repeating it.

There are three Ozone related GLSurface subclasses that defined in an
anonymous namespace. Instead of moving the class definitions to a header
file, public functions are added to create these types, as the classes
need to be refactored heavily.

These is essentially the last part of step 2 in the associated bug.
There may be some other small refactor work moving parts of
initialization code from gl_implementation_<platform>.cc to
gl_initializer_<platform>.cc necessary.

BUG=611142
==========

to

==========
Move GLSurface creation from //ui/gl to //ui/gl/init.

Move the code that performs GLSurface creation to the new target. Remove
old surface creation code and delete static methods from GLSurface.

Add InitializeGLSurface() function to simplify a common pattern. When a
new GLSurface is created, it is wrapped in a scoped_refptr and then
initialized. If initialization fails nullptr is returned instead.
Encapsulate this logic into a function instead of repeating it.

There are three Ozone related GLSurface subclasses that defined in an
anonymous namespace. Instead of moving the class definitions to a header
file, public functions are added to create these types, as the classes
need to be refactored heavily.

These is almost the last part of step 2 in the associated bug.  There
may be some other small refactor work moving parts of initialization
code from gl_implementation_<platform>.cc to
gl_initializer_<platform>.cc necessary.

BUG=611142
==========

[kylechar, 2016-06-09 14:57:00]

kylechar@chromium.org changed reviewers:
+ piman@chromium.org

[kylechar, 2016-06-09 15:15:42]

The CQ bit was checked by kylechar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-09 15:16:06]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2047283003/80001

[commit-bot: I haz the power, 2016-06-09 15:55:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-09 15:55:24]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[piman, 2016-06-09 19:23:13]

lgtm

[kylechar, 2016-06-09 20:40:50]

Description was changed from

==========
Move GLSurface creation from //ui/gl to //ui/gl/init.

Move the code that performs GLSurface creation to the new target. Remove
old surface creation code and delete static methods from GLSurface.

Add InitializeGLSurface() function to simplify a common pattern. When a
new GLSurface is created, it is wrapped in a scoped_refptr and then
initialized. If initialization fails nullptr is returned instead.
Encapsulate this logic into a function instead of repeating it.

There are three Ozone related GLSurface subclasses that defined in an
anonymous namespace. Instead of moving the class definitions to a header
file, public functions are added to create these types, as the classes
need to be refactored heavily.

These is almost the last part of step 2 in the associated bug.  There
may be some other small refactor work moving parts of initialization
code from gl_implementation_<platform>.cc to
gl_initializer_<platform>.cc necessary.

BUG=611142
==========

to

==========
Move GLSurface creation from //ui/gl to //ui/gl/init.

Move the code that performs GLSurface creation to the new target. Remove
old surface creation code and delete static methods from GLSurface.

Add InitializeGLSurface() function to simplify a common pattern. When a
new GLSurface is created, it is wrapped in a scoped_refptr and then
initialized. If initialization fails nullptr is returned instead.
Encapsulate this logic into a function instead of repeating it.

There are three Ozone related GLSurface subclasses that defined in an
anonymous namespace. Instead of moving the class definitions to a header
file, public functions are added to create these types, as the classes
need to be refactored heavily.

These is almost the last part of step 2 in the associated bug.  There
may be some other small refactor work moving parts of initialization
code from gl_implementation_<platform>.cc to
gl_initializer_<platform>.cc necessary.

BUG=611142
==========

[kylechar, 2016-06-10 14:42:05]

The CQ bit was checked by kylechar@chromium.org

[commit-bot: I haz the power, 2016-06-10 14:42:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2047283003/100001

[commit-bot: I haz the power, 2016-06-10 15:41:17]

Description was changed from

==========
Move GLSurface creation from //ui/gl to //ui/gl/init.

Move the code that performs GLSurface creation to the new target. Remove
old surface creation code and delete static methods from GLSurface.

Add InitializeGLSurface() function to simplify a common pattern. When a
new GLSurface is created, it is wrapped in a scoped_refptr and then
initialized. If initialization fails nullptr is returned instead.
Encapsulate this logic into a function instead of repeating it.

There are three Ozone related GLSurface subclasses that defined in an
anonymous namespace. Instead of moving the class definitions to a header
file, public functions are added to create these types, as the classes
need to be refactored heavily.

These is almost the last part of step 2 in the associated bug.  There
may be some other small refactor work moving parts of initialization
code from gl_implementation_<platform>.cc to
gl_initializer_<platform>.cc necessary.

BUG=611142
==========

to

==========
Move GLSurface creation from //ui/gl to //ui/gl/init.

Move the code that performs GLSurface creation to the new target. Remove
old surface creation code and delete static methods from GLSurface.

Add InitializeGLSurface() function to simplify a common pattern. When a
new GLSurface is created, it is wrapped in a scoped_refptr and then
initialized. If initialization fails nullptr is returned instead.
Encapsulate this logic into a function instead of repeating it.

There are three Ozone related GLSurface subclasses that defined in an
anonymous namespace. Instead of moving the class definitions to a header
file, public functions are added to create these types, as the classes
need to be refactored heavily.

These is almost the last part of step 2 in the associated bug.  There
may be some other small refactor work moving parts of initialization
code from gl_implementation_<platform>.cc to
gl_initializer_<platform>.cc necessary.

BUG=611142
==========

[commit-bot: I haz the power, 2016-06-10 15:41:18]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-06-10 15:43:13]

Description was changed from

==========
Move GLSurface creation from //ui/gl to //ui/gl/init.

Move the code that performs GLSurface creation to the new target. Remove
old surface creation code and delete static methods from GLSurface.

Add InitializeGLSurface() function to simplify a common pattern. When a
new GLSurface is created, it is wrapped in a scoped_refptr and then
initialized. If initialization fails nullptr is returned instead.
Encapsulate this logic into a function instead of repeating it.

There are three Ozone related GLSurface subclasses that defined in an
anonymous namespace. Instead of moving the class definitions to a header
file, public functions are added to create these types, as the classes
need to be refactored heavily.

These is almost the last part of step 2 in the associated bug.  There
may be some other small refactor work moving parts of initialization
code from gl_implementation_<platform>.cc to
gl_initializer_<platform>.cc necessary.

BUG=611142
==========

to

==========
Move GLSurface creation from //ui/gl to //ui/gl/init.

Move the code that performs GLSurface creation to the new target. Remove
old surface creation code and delete static methods from GLSurface.

Add InitializeGLSurface() function to simplify a common pattern. When a
new GLSurface is created, it is wrapped in a scoped_refptr and then
initialized. If initialization fails nullptr is returned instead.
Encapsulate this logic into a function instead of repeating it.

There are three Ozone related GLSurface subclasses that defined in an
anonymous namespace. Instead of moving the class definitions to a header
file, public functions are added to create these types, as the classes
need to be refactored heavily.

These is almost the last part of step 2 in the associated bug.  There
may be some other small refactor work moving parts of initialization
code from gl_implementation_<platform>.cc to
gl_initializer_<platform>.cc necessary.

BUG=611142

Committed: https://crrev.com/f1f2cba219ff4ee3071c716f7add731a5c9e39ca
Cr-Commit-Position: refs/heads/master@{#399190}
==========

[commit-bot: I haz the power, 2016-06-10 15:43:15]

Patchset 6 (id:??) landed as
https://crrev.com/f1f2cba219ff4ee3071c716f7add731a5c9e39ca
Cr-Commit-Position: refs/heads/master@{#399190}