Send 'key' from fake keyboard events generated by file_manager.

Send 'key' from fake keyboard events generated by file_manager.

With the deprecation of keyIdentifier; the key variable needs to be
sent on the unit tests generating keyboard events.

BUG=607349
Committed: https://crrev.com/feff0d5843bf7a3c3ecdd682f77c39a43e75030a
Cr-Commit-Position: refs/heads/master@{#398464}

[dtapuska, 2016-06-07 20:29:02]

Description was changed from

==========
Send 'key' from fake keyboard events generated by file_manager.

With the deprecation of keyIdentifier; the key variable needs to be
sent on the unit tests generating keyboard events.

BUG=607349
==========

to

==========
Send 'key' from fake keyboard events generated by file_manager.

With the deprecation of keyIdentifier; the key variable needs to be
sent on the unit tests generating keyboard events.

BUG=607349
==========

[dtapuska, 2016-06-07 20:29:02]

dtapuska@chromium.org changed reviewers:
+ fukino@chromium.org

[dtapuska, 2016-06-07 20:29:17]

PTAL

[fukino, 2016-06-08 01:15:23]

On 2016/06/07 20:29:17, dtapuska wrote:
> PTAL

Thank you for taking care of it!
Could you fix following broken tests, too?
GalleryBrowserTest.SelectAllImagesAfterImageDeletionOnDownloads
GalleryBrowserTest.DeleteAllImagesInThumbnailModeWithDeleteKey
GalleryBrowserTest.SelectMultipleImagesWithShiftKeyOnDownloads

For the rest of Files app code (non-test code), I have an WIP CL.
https://codereview.chromium.org/1994563002/

[dtapuska, 2016-06-08 01:38:36]

On 2016/06/08 01:15:23, fukino wrote:
> On 2016/06/07 20:29:17, dtapuska wrote:
> > PTAL
> 
> Thank you for taking care of it!
> Could you fix following broken tests, too?
> GalleryBrowserTest.SelectAllImagesAfterImageDeletionOnDownloads
> GalleryBrowserTest.DeleteAllImagesInThumbnailModeWithDeleteKey
> GalleryBrowserTest.SelectMultipleImagesWithShiftKeyOnDownloads
> 
> For the rest of Files app code (non-test code), I have an WIP CL.
> https://codereview.chromium.org/1994563002/

Done. Do you know when you will land the WIP CL. I had it on my list to fix that
code as well; as I was hoping to remove keyIdentifier from blink this week.

[fukino, 2016-06-08 01:56:17]

On 2016/06/08 01:38:36, dtapuska wrote:
> On 2016/06/08 01:15:23, fukino wrote:
> > On 2016/06/07 20:29:17, dtapuska wrote:
> > > PTAL
> > 
> > Thank you for taking care of it!
> > Could you fix following broken tests, too?
> > GalleryBrowserTest.SelectAllImagesAfterImageDeletionOnDownloads
> > GalleryBrowserTest.DeleteAllImagesInThumbnailModeWithDeleteKey
> > GalleryBrowserTest.SelectMultipleImagesWithShiftKeyOnDownloads
> > 
> > For the rest of Files app code (non-test code), I have an WIP CL.
> > https://codereview.chromium.org/1994563002/
> 
> Done. Do you know when you will land the WIP CL. I had it on my list to fix
that
> code as well; as I was hoping to remove keyIdentifier from blink this week.

Is KeyboardEvent.key supported on iOS?
file_manager depends on cr library (src/ui/webui/resources/js/cr/), which uses
keyIdentifier, and it needs to work on iOS (Chrome for iOS) too.
Maybe it can make the removal of keyIdentifier tricker?

[dtapuska, 2016-06-08 02:05:25]

On 2016/06/08 01:56:17, fukino wrote:
> On 2016/06/08 01:38:36, dtapuska wrote:
> > On 2016/06/08 01:15:23, fukino wrote:
> > > On 2016/06/07 20:29:17, dtapuska wrote:
> > > > PTAL
> > > 
> > > Thank you for taking care of it!
> > > Could you fix following broken tests, too?
> > > GalleryBrowserTest.SelectAllImagesAfterImageDeletionOnDownloads
> > > GalleryBrowserTest.DeleteAllImagesInThumbnailModeWithDeleteKey
> > > GalleryBrowserTest.SelectMultipleImagesWithShiftKeyOnDownloads
> > > 
> > > For the rest of Files app code (non-test code), I have an WIP CL.
> > > https://codereview.chromium.org/1994563002/
> > 
> > Done. Do you know when you will land the WIP CL. I had it on my list to fix
> that
> > code as well; as I was hoping to remove keyIdentifier from blink this week.
> 
> Is KeyboardEvent.key supported on iOS?
> file_manager depends on cr library (src/ui/webui/resources/js/cr/), which uses
> keyIdentifier, and it needs to work on iOS (Chrome for iOS) too.
> Maybe it can make the removal of keyIdentifier tricker?

No KeyboardEvent.key is not supported on iOS. But code should be able to check
that event.keyIdentifer !== Undefined or event.key !== Undefined...

[dtapuska, 2016-06-08 02:19:51]

On 2016/06/08 02:05:25, dtapuska wrote:
> On 2016/06/08 01:56:17, fukino wrote:
> > On 2016/06/08 01:38:36, dtapuska wrote:
> > > On 2016/06/08 01:15:23, fukino wrote:
> > > > On 2016/06/07 20:29:17, dtapuska wrote:
> > > > > PTAL
> > > > 
> > > > Thank you for taking care of it!
> > > > Could you fix following broken tests, too?
> > > > GalleryBrowserTest.SelectAllImagesAfterImageDeletionOnDownloads
> > > > GalleryBrowserTest.DeleteAllImagesInThumbnailModeWithDeleteKey
> > > > GalleryBrowserTest.SelectMultipleImagesWithShiftKeyOnDownloads
> > > > 
> > > > For the rest of Files app code (non-test code), I have an WIP CL.
> > > > https://codereview.chromium.org/1994563002/
> > > 
> > > Done. Do you know when you will land the WIP CL. I had it on my list to
fix
> > that
> > > code as well; as I was hoping to remove keyIdentifier from blink this
week.
> > 
> > Is KeyboardEvent.key supported on iOS?
> > file_manager depends on cr library (src/ui/webui/resources/js/cr/), which
uses
> > keyIdentifier, and it needs to work on iOS (Chrome for iOS) too.
> > Maybe it can make the removal of keyIdentifier tricker?
> 
> No KeyboardEvent.key is not supported on iOS. But code should be able to check
> that event.keyIdentifer !== Undefined or event.key !== Undefined...

[dtapuska, 2016-06-08 02:20:24]

On 2016/06/08 02:05:25, dtapuska wrote:
> On 2016/06/08 01:56:17, fukino wrote:
> > On 2016/06/08 01:38:36, dtapuska wrote:
> > > On 2016/06/08 01:15:23, fukino wrote:
> > > > On 2016/06/07 20:29:17, dtapuska wrote:
> > > > > PTAL
> > > > 
> > > > Thank you for taking care of it!
> > > > Could you fix following broken tests, too?
> > > > GalleryBrowserTest.SelectAllImagesAfterImageDeletionOnDownloads
> > > > GalleryBrowserTest.DeleteAllImagesInThumbnailModeWithDeleteKey
> > > > GalleryBrowserTest.SelectMultipleImagesWithShiftKeyOnDownloads
> > > > 
> > > > For the rest of Files app code (non-test code), I have an WIP CL.
> > > > https://codereview.chromium.org/1994563002/
> > > 
> > > Done. Do you know when you will land the WIP CL. I had it on my list to
fix
> > that
> > > code as well; as I was hoping to remove keyIdentifier from blink this
week.
> > 
> > Is KeyboardEvent.key supported on iOS?
> > file_manager depends on cr library (src/ui/webui/resources/js/cr/), which
uses
> > keyIdentifier, and it needs to work on iOS (Chrome for iOS) too.
> > Maybe it can make the removal of keyIdentifier tricker?
> 
> No KeyboardEvent.key is not supported on iOS. But code should be able to check
> that event.keyIdentifer !== Undefined or event.key !== Undefined...

Is this change good for the test harness for now? All trybots are green.

[fukino, 2016-06-08 02:24:40]

lgtm. Thank you!
I'll try to remove keyIdentifier from file_manager this week. (For other WebUI
apps, I'm still not sure how much work is needed, though)

[dtapuska, 2016-06-08 02:25:49]

The CQ bit was checked by dtapuska@chromium.org

[commit-bot: I haz the power, 2016-06-08 02:26:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2046143002/20001

[commit-bot: I haz the power, 2016-06-08 02:30:18]

Description was changed from

==========
Send 'key' from fake keyboard events generated by file_manager.

With the deprecation of keyIdentifier; the key variable needs to be
sent on the unit tests generating keyboard events.

BUG=607349
==========

to

==========
Send 'key' from fake keyboard events generated by file_manager.

With the deprecation of keyIdentifier; the key variable needs to be
sent on the unit tests generating keyboard events.

BUG=607349
==========

[commit-bot: I haz the power, 2016-06-08 02:30:19]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-08 02:31:39]

Description was changed from

==========
Send 'key' from fake keyboard events generated by file_manager.

With the deprecation of keyIdentifier; the key variable needs to be
sent on the unit tests generating keyboard events.

BUG=607349
==========

to

==========
Send 'key' from fake keyboard events generated by file_manager.

With the deprecation of keyIdentifier; the key variable needs to be
sent on the unit tests generating keyboard events.

BUG=607349

Committed: https://crrev.com/feff0d5843bf7a3c3ecdd682f77c39a43e75030a
Cr-Commit-Position: refs/heads/master@{#398464}
==========

[commit-bot: I haz the power, 2016-06-08 02:31:40]

Patchset 2 (id:??) landed as
https://crrev.com/feff0d5843bf7a3c3ecdd682f77c39a43e75030a
Cr-Commit-Position: refs/heads/master@{#398464}