Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(792)

Unified Diff: ui/file_manager/integration_tests/remote_call.js

Issue 2046143002: Send 'key' from fake keyboard events generated by file_manager. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix additional tests I missed Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/file_manager/integration_tests/gallery/thumbnail_mode.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/file_manager/integration_tests/remote_call.js
diff --git a/ui/file_manager/integration_tests/remote_call.js b/ui/file_manager/integration_tests/remote_call.js
index 40efc898d3fe1830ccd56b0a51e6a12d1c62239e..aa014c6ed19bfe7f82349ea3569ae16c1944edea 100644
--- a/ui/file_manager/integration_tests/remote_call.js
+++ b/ui/file_manager/integration_tests/remote_call.js
@@ -201,6 +201,7 @@ RemoteCall.prototype.waitForElementLost =
* Sends a fake key down event.
* @param {string} windowId Window ID.
* @param {string} query Query for the target element.
+ * @param {string} key DOM UI Events Key value.
* @param {string} keyIdentifer Key identifier.
* @param {boolean} ctrlKey Control key flag.
* @param {boolean} shiftKey Shift key flag.
@@ -209,10 +210,10 @@ RemoteCall.prototype.waitForElementLost =
* result.
*/
RemoteCall.prototype.fakeKeyDown =
- function(windowId, query, keyIdentifer, ctrlKey, shiftKey, altKey) {
+ function(windowId, query, key, keyIdentifer, ctrlKey, shiftKey, altKey) {
var resultPromise = this.callRemoteTestUtil(
'fakeKeyDown', windowId,
- [query, keyIdentifer, ctrlKey, shiftKey, altKey]);
+ [query, key, keyIdentifer, ctrlKey, shiftKey, altKey]);
return resultPromise.then(function(result) {
if (result)
return true;
@@ -362,7 +363,7 @@ RemoteCallFilesApp.prototype.checkNextTabFocus =
function(windowId, elementId) {
return remoteCall.callRemoteTestUtil('fakeKeyDown',
windowId,
- ['body', 'U+0009', false]).then(
+ ['body', 'Tab', 'U+0009', false]).then(
function(result) {
chrome.test.assertTrue(result);
return remoteCall.callRemoteTestUtil('getActiveElement',
« no previous file with comments | « ui/file_manager/integration_tests/gallery/thumbnail_mode.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698