ui/file_manager/integration_tests/gallery/photo_editor.js - Issue 2046143002: Send 'key' from fake keyboard events generated by file_manager.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/file_manager/integration_tests/gallery/photo_editor.js

Issue 2046143002: Send 'key' from fake keyboard events generated by file_manager. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix additional tests I missed Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ui/file_manager/integration_tests/gallery/open_image_files.js ('k') | ui/file_manager/integration_tests/gallery/thumbnail_mode.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/file_manager/integration_tests/gallery/photo_editor.js

diff --git a/ui/file_manager/integration_tests/gallery/photo_editor.js b/ui/file_manager/integration_tests/gallery/photo_editor.js

index 04df8b535922723bb6dc25dd9182054c583f4a48..0427a3aee512ae3884b722ec5c12924a00d0eec0 100644

--- a/ui/file_manager/integration_tests/gallery/photo_editor.js

+++ b/ui/file_manager/integration_tests/gallery/photo_editor.js

@@ -94,7 +94,7 @@ function cropImage(testVolumeName, volumeType) {

}).

then(function() {

return gallery.fakeKeyDown(

- appId, 'body', 'Enter', false, false, false);

+ appId, 'body', 'Enter', 'Enter', false, false, false);

}).

then(function(ret) {

chrome.test.assertTrue(ret);

@@ -159,7 +159,8 @@ function exposureImage(testVolumeName, volumeType) {

origMetadata = metadata;

// Push the Enter key.

- return gallery.fakeKeyDown(appId, 'body', 'Enter', false, false, false);

+ return gallery.fakeKeyDown(appId, 'body', 'Enter', 'Enter', false, false,

+ false);

}).then(function() {

// Wait until the image is updated.

return repeatUntil(function() {