Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(486)

Unified Diff: ui/file_manager/integration_tests/file_manager/keyboard_operations.js

Issue 2046143002: Send 'key' from fake keyboard events generated by file_manager. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix additional tests I missed Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/file_manager/integration_tests/file_manager/keyboard_operations.js
diff --git a/ui/file_manager/integration_tests/file_manager/keyboard_operations.js b/ui/file_manager/integration_tests/file_manager/keyboard_operations.js
index 0fc42f4c31fdfebeea8b5380c5f83b2328e793fe..d5b8dd707ed84db0b8ca9e8a4dcc78d3c6d996e1 100644
--- a/ui/file_manager/integration_tests/file_manager/keyboard_operations.js
+++ b/ui/file_manager/integration_tests/file_manager/keyboard_operations.js
@@ -213,7 +213,7 @@ function renameFile(windowId, oldName, newName) {
then(function() {
// Push Ctrl+Enter.
return remoteCall.fakeKeyDown(
- windowId, '#detail-table', 'Enter', true, false, false);
+ windowId, '#detail-table', 'Enter', 'Enter', true, false, false);
}).then(function() {
// Wait for rename text field.
return remoteCall.waitForElement(windowId, 'input.rename');
@@ -224,7 +224,7 @@ function renameFile(windowId, oldName, newName) {
}).then(function() {
// Push Enter.
return remoteCall.fakeKeyDown(
- windowId, 'input.rename', 'Enter', false, false, false);
+ windowId, 'input.rename', 'Enter', 'Enter', false, false, false);
});
}
@@ -244,7 +244,7 @@ function testRenameNewDirectory(path, initialEntrySet, pathInBreadcrumb) {
var windowId = results.windowId;
return remoteCall.waitForFiles(windowId, expectedRows).then(function() {
return remoteCall.fakeKeyDown(
- windowId, '#list-container', 'U+0045', true, false, false);
+ windowId, '#list-container', 'e', 'U+0045', true, false, false);
}).then(function() {
// Wait for rename text field.
return remoteCall.waitForElement(windowId, 'input.rename');
@@ -255,11 +255,11 @@ function testRenameNewDirectory(path, initialEntrySet, pathInBreadcrumb) {
}).then(function() {
// Press Enter.
return remoteCall.fakeKeyDown(
- windowId, 'input.rename', 'Enter', false, false, false);
+ windowId, 'input.rename', 'Enter', 'Enter', false, false, false);
}).then(function() {
// Press Enter again to try to get into the new directory.
return remoteCall.fakeKeyDown(
- windowId, '#list-container', 'Enter', false, false, false);
+ windowId, '#list-container', 'Enter', 'Enter', false, false, false);
}).then(function() {
// Confirm that it doesn't move the directory since it's in renaming
// process.
@@ -271,7 +271,7 @@ function testRenameNewDirectory(path, initialEntrySet, pathInBreadcrumb) {
}).then(function() {
// Press Enter again.
return remoteCall.fakeKeyDown(windowId, '#list-container', 'Enter',
- false, false, false);
+ 'Enter', false, false, false);
}).then(function() {
// Confirm that it moves to renamed directory.
return remoteCall.waitUntilCurrentDirectoryIsChanged(windowId,

Powered by Google App Engine
This is Rietveld 408576698