Remove the use of KeyEvent.keyIdentifier.

Remove the use of KeyEvent.keyIdentifier.

We should use KeyboardEvent.key instead.
For the shortcut identifier of cr.ui.Command (<command> in main.html), we still depends on keyIdentifier, but it should be handled in a separate CL.

BUG=612717
TEST=run browser_tests

Committed: https://crrev.com/9e5d27298cb447dbf20cbcd189dfb36a4d94960d
Cr-Commit-Position: refs/heads/master@{#398876}

[fukino, 2016-06-09 12:48:45]

Description was changed from

==========
Remove the use of KeyEvent.keyIdentifier.

BUG=612717
TEST=run browser_tests
==========

to

==========
Remove the use of KeyEvent.keyIdentifier.

We should use KeyboardEvent.key instead.
For the shortcut identifier of cr.ui.Command (<command> in main.html), we still
depends on keyIdentifier, but it should be handled in a separate CL.

BUG=612717
TEST=run browser_tests
==========

[fukino, 2016-06-09 12:49:16]

fukino@chromium.org changed reviewers:
+ oka@chromium.org

[fukino, 2016-06-09 12:49:17]

PTAL

[oka, 2016-06-09 13:32:31]

lgtm

https://codereview.chromium.org/1994563002/diff/40001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/background/js/test_util.js (right):

https://codereview.chromium.org/1994563002/diff/40001/ui/file_manager/file_ma...
ui/file_manager/file_manager/background/js/test_util.js:190: contentWindow,
'#file-list', 'c', 'U+0043', true, false, false);
Can you remove keyIdentifier from fakeKeyDown?

[fukino, 2016-06-09 13:47:50]

Thanks!

https://codereview.chromium.org/1994563002/diff/40001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/background/js/test_util.js (right):

https://codereview.chromium.org/1994563002/diff/40001/ui/file_manager/file_ma...
ui/file_manager/file_manager/background/js/test_util.js:190: contentWindow,
'#file-list', 'c', 'U+0043', true, false, false);
On 2016/06/09 13:32:31, oka wrote:
> Can you remove keyIdentifier from fakeKeyDown?

As the cr.ui.Command still depends on keyIdentifier property of the event
object, so we need it right now.
I'll remove it once we remove the dependency from cr.ui.Command.

[fukino, 2016-06-09 14:03:01]

The CQ bit was checked by fukino@chromium.org

[commit-bot: I haz the power, 2016-06-09 14:03:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1994563002/40001

[oka, 2016-06-09 14:08:49]

On 2016/06/09 13:47:50, fukino wrote:
> Thanks!
> 
>
https://codereview.chromium.org/1994563002/diff/40001/ui/file_manager/file_ma...
> File ui/file_manager/file_manager/background/js/test_util.js (right):
> 
>
https://codereview.chromium.org/1994563002/diff/40001/ui/file_manager/file_ma...
> ui/file_manager/file_manager/background/js/test_util.js:190: contentWindow,
> '#file-list', 'c', 'U+0043', true, false, false);
> On 2016/06/09 13:32:31, oka wrote:
> > Can you remove keyIdentifier from fakeKeyDown?
> 
> As the cr.ui.Command still depends on keyIdentifier property of the event
> object, so we need it right now.
> I'll remove it once we remove the dependency from cr.ui.Command.

Understood.

[commit-bot: I haz the power, 2016-06-09 14:46:12]

Description was changed from

==========
Remove the use of KeyEvent.keyIdentifier.

We should use KeyboardEvent.key instead.
For the shortcut identifier of cr.ui.Command (<command> in main.html), we still
depends on keyIdentifier, but it should be handled in a separate CL.

BUG=612717
TEST=run browser_tests
==========

to

==========
Remove the use of KeyEvent.keyIdentifier.

We should use KeyboardEvent.key instead.
For the shortcut identifier of cr.ui.Command (<command> in main.html), we still
depends on keyIdentifier, but it should be handled in a separate CL.

BUG=612717
TEST=run browser_tests
==========

[commit-bot: I haz the power, 2016-06-09 14:46:13]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-09 14:46:21]

CQ bit was unchecked

[commit-bot: I haz the power, 2016-06-09 14:49:14]

Description was changed from

==========
Remove the use of KeyEvent.keyIdentifier.

We should use KeyboardEvent.key instead.
For the shortcut identifier of cr.ui.Command (<command> in main.html), we still
depends on keyIdentifier, but it should be handled in a separate CL.

BUG=612717
TEST=run browser_tests
==========

to

==========
Remove the use of KeyEvent.keyIdentifier.

We should use KeyboardEvent.key instead.
For the shortcut identifier of cr.ui.Command (<command> in main.html), we still
depends on keyIdentifier, but it should be handled in a separate CL.

BUG=612717
TEST=run browser_tests

Committed: https://crrev.com/9e5d27298cb447dbf20cbcd189dfb36a4d94960d
Cr-Commit-Position: refs/heads/master@{#398876}
==========

[commit-bot: I haz the power, 2016-06-09 14:49:16]

Patchset 3 (id:??) landed as
https://crrev.com/9e5d27298cb447dbf20cbcd189dfb36a4d94960d
Cr-Commit-Position: refs/heads/master@{#398876}