ui/file_manager/integration_tests/file_manager/folder_shortcuts.js - Issue 2046143002: Send 'key' from fake keyboard events generated by file_manager.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/file_manager/integration_tests/file_manager/folder_shortcuts.js

Issue 2046143002: Send 'key' from fake keyboard events generated by file_manager. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix additional tests I missed Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ui/file_manager/integration_tests/file_manager/file_dialog.js ('k') | ui/file_manager/integration_tests/file_manager/gear_menu.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/file_manager/integration_tests/file_manager/folder_shortcuts.js

diff --git a/ui/file_manager/integration_tests/file_manager/folder_shortcuts.js b/ui/file_manager/integration_tests/file_manager/folder_shortcuts.js

index e3f5f81c708200c0d1b2a701df5a039d6b3fb3f7..3f010c1bdadf9b1a29c0c1bb4656b64680507a43 100644

--- a/ui/file_manager/integration_tests/file_manager/folder_shortcuts.js

+++ b/ui/file_manager/integration_tests/file_manager/folder_shortcuts.js

@@ -299,7 +299,7 @@ testcase.traverseFolderShortcuts = function() {

// Shortcut to C should be selected.

function() {

remoteCall.callRemoteTestUtil('fakeKeyDown', windowId,

- ['#file-list', 'U+0034', true, false, false], this.next);

+ ['#file-list', '4', 'U+0034', true, false, false], this.next);

function(result) {

chrome.test.assertTrue(result);

@@ -311,7 +311,7 @@ testcase.traverseFolderShortcuts = function() {

// Shortcut to C should be selected.

function() {

remoteCall.callRemoteTestUtil('fakeKeyDown', windowId,

- ['#directory-tree', 'Up', false, false, false], this.next);

+ ['#directory-tree', 'ArrowUp', 'Up', false, false, false], this.next);

function(result) {

chrome.test.assertTrue(result);

@@ -322,7 +322,8 @@ testcase.traverseFolderShortcuts = function() {

// Current directory should be C.

function() {

remoteCall.callRemoteTestUtil('fakeKeyDown', windowId,

- ['#directory-tree', 'Enter', false, false, false], this.next);

+ ['#directory-tree', 'Enter', 'Enter', false, false, false],

+ this.next);

function(result) {

chrome.test.assertTrue(result);