Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Issue 2041863002: Remove HttpServerProperies::GetWeakPtr(). (Closed)

Created:
4 years, 6 months ago by Bence
Modified:
4 years, 6 months ago
CC:
alokp+watch_chromium.org, cbentzel+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, halliwell+watch_chromium.org, jam, johnme+watch_chromium.org, lcwu+watch_chromium.org, loading-reviews_chromium.org, Peter Beverloo, Randy Smith (Not in Mondays), sdefresne+watch_chromium.org, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove HttpServerProperies::GetWeakPtr(). Use HttpServerProperties* instead of WeakPtr<HttpServerProperties> everywhere outside HttpServerProperties and its derived classes. In production, IOThread (or IOSChromeIOThread) outlives everything that would reference HttpServerProperties, so there are no lifetime issues. As for tests, this CL ensures that in test base classes that own both an HttpServerPropertiesImpl and an HttpNetworkSession instance, the former outlives the latter. BUG=508548 Committed: https://crrev.com/525e175af915bb9eb205775a40eec66308324211 Cr-Commit-Position: refs/heads/master@{#400660}

Patch Set 1 #

Total comments: 10

Patch Set 2 : Re: #3. #

Patch Set 3 : Rebase #

Patch Set 4 : Revert removing const qualifier from ChromeBrowserStateIOData methods. #

Patch Set 5 : Rebase to manually resolve merge conflict. #

Patch Set 6 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+139 lines, -163 lines) Patch
M chrome/browser/io_thread.cc View 1 2 3 4 5 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/profiles/profile_io_data.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/profile_io_data.cc View 1 2 3 4 5 1 chunk +2 lines, -3 lines 0 comments Download
M chromecast/browser/url_request_context_factory.cc View 1 3 chunks +3 lines, -5 lines 0 comments Download
M components/cronet/ios/cronet_environment.cc View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/loader/resource_scheduler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M google_apis/gcm/tools/mcs_probe.cc View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M ios/chrome/browser/browser_state/chrome_browser_state_io_data.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/browser_state/chrome_browser_state_io_data.cc View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M ios/chrome/browser/ios_chrome_io_thread.mm View 1 2 3 4 5 1 chunk +1 line, -2 lines 0 comments Download
M ios/crnet/crnet_environment.mm View 1 chunk +1 line, -2 lines 0 comments Download
M net/http/http_network_layer_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M net/http/http_network_session.h View 3 chunks +3 lines, -3 lines 0 comments Download
M net/http/http_network_transaction_ssl_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M net/http/http_network_transaction_unittest.cc View 1 2 3 4 5 25 chunks +35 lines, -35 lines 0 comments Download
M net/http/http_response_body_drainer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_server_properties.h View 1 2 3 4 5 2 chunks +0 lines, -4 lines 0 comments Download
M net/http/http_server_properties_impl.h View 1 2 3 4 5 2 chunks +1 line, -1 line 0 comments Download
M net/http/http_server_properties_impl.cc View 1 2 3 4 5 1 chunk +0 lines, -4 lines 0 comments Download
M net/http/http_server_properties_manager.h View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M net/http/http_server_properties_manager.cc View 1 2 3 4 5 1 chunk +0 lines, -6 lines 0 comments Download
M net/http/http_stream_factory_impl_job.cc View 1 2 3 4 5 3 chunks +3 lines, -3 lines 0 comments Download
M net/http/http_stream_factory_impl_unittest.cc View 1 2 3 4 5 6 chunks +7 lines, -5 lines 0 comments Download
M net/quic/crypto/properties_based_quic_server_info.h View 3 chunks +5 lines, -6 lines 0 comments Download
M net/quic/crypto/properties_based_quic_server_info.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/crypto/properties_based_quic_server_info_test.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M net/quic/quic_end_to_end_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/quic_network_transaction_unittest.cc View 1 2 3 4 5 6 chunks +6 lines, -4 lines 0 comments Download
M net/quic/quic_stream_factory.h View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/quic_stream_factory.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_stream_factory_test.cc View 1 2 3 4 5 2 chunks +2 lines, -3 lines 0 comments Download
M net/socket/ssl_client_socket_pool_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M net/spdy/spdy_network_transaction_unittest.cc View 1 2 3 4 5 3 chunks +3 lines, -3 lines 0 comments Download
M net/spdy/spdy_session.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M net/spdy/spdy_session.cc View 1 2 3 4 1 chunk +13 lines, -14 lines 0 comments Download
M net/spdy/spdy_session_pool.h View 1 3 chunks +13 lines, -14 lines 0 comments Download
M net/spdy/spdy_session_pool.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/spdy_session_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/spdy_test_util_common.h View 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/spdy_test_util_common.cc View 1 2 3 chunks +3 lines, -2 lines 0 comments Download
M net/url_request/url_request_context.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/url_request/url_request_context.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/url_request/url_request_context_storage.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 24 (8 generated)
Bence
Asanka: PTAL. Thank you.
4 years, 6 months ago (2016-06-06 16:34:18 UTC) #2
asanka
lgtm % nits https://codereview.chromium.org/2041863002/diff/1/net/spdy/spdy_session.cc File net/spdy/spdy_session.cc (right): https://codereview.chromium.org/2041863002/diff/1/net/spdy/spdy_session.cc#newcode673 net/spdy/spdy_session.cc:673: HttpServerProperties* const http_server_properties, Same comment as ...
4 years, 6 months ago (2016-06-07 20:19:56 UTC) #3
Bence
asanka: Thank you. skuhne: PTAL at chrome/browser/profiles dimich: PTAL at google_apis/ slan: PTAL at chromecast/browser/ ...
4 years, 6 months ago (2016-06-08 18:27:18 UTC) #5
kapishnikov
components/cronet - LGTM
4 years, 6 months ago (2016-06-08 21:11:11 UTC) #6
Mr4D (OOO till 08-26)
chrome/browser/profiles lgtm
4 years, 6 months ago (2016-06-09 02:07:08 UTC) #7
alokp
chromecast/ lgtm
4 years, 6 months ago (2016-06-09 04:23:29 UTC) #9
rohitrao (ping after 24h)
ios/ LGTM
4 years, 6 months ago (2016-06-09 12:31:30 UTC) #10
slan
lgtm
4 years, 6 months ago (2016-06-10 16:36:21 UTC) #11
no sievers
content lgtm
4 years, 6 months ago (2016-06-10 17:32:21 UTC) #12
Bence
Dimitry: PTAL at google_apis/ Ryan: PTAL at chrome/browser/io_thread.cc Thank you.
4 years, 6 months ago (2016-06-13 13:48:30 UTC) #14
Ryan Hamilton
chrome/browser/io_thread.cc: lgtm
4 years, 6 months ago (2016-06-13 21:32:32 UTC) #15
Bence
Dimitry and/or Nicolas: PTAL at google_apis/gcm/tools/. Thank you.
4 years, 6 months ago (2016-06-17 18:06:44 UTC) #17
Nicolas Zea
gcm lgtm
4 years, 6 months ago (2016-06-20 07:15:17 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2041863002/100001
4 years, 6 months ago (2016-06-20 12:14:55 UTC) #21
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 6 months ago (2016-06-20 12:36:57 UTC) #22
commit-bot: I haz the power
4 years, 6 months ago (2016-06-20 12:38:48 UTC) #24
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/525e175af915bb9eb205775a40eec66308324211
Cr-Commit-Position: refs/heads/master@{#400660}

Powered by Google App Engine
This is Rietveld 408576698