|
Remove HttpServerProperies::GetWeakPtr().
Use HttpServerProperties* instead of WeakPtr<HttpServerProperties> everywhere
outside HttpServerProperties and its derived classes.
In production, IOThread (or IOSChromeIOThread) outlives everything that would
reference HttpServerProperties, so there are no lifetime issues.
As for tests, this CL ensures that in test base classes that own both an
HttpServerPropertiesImpl and an HttpNetworkSession instance, the former outlives
the latter.
BUG= 508548
Committed: https://crrev.com/525e175af915bb9eb205775a40eec66308324211
Cr-Commit-Position: refs/heads/master@{#400660}
Total comments: 10
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+139 lines, -163 lines) |
Patch |
 |
M |
chrome/browser/io_thread.cc
|
View
|
1
2
3
4
5
|
2 chunks |
+2 lines, -4 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/profiles/profile_io_data.h
|
View
|
1
2
3
4
5
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/profiles/profile_io_data.cc
|
View
|
1
2
3
4
5
|
1 chunk |
+2 lines, -3 lines |
0 comments
|
Download
|
 |
M |
chromecast/browser/url_request_context_factory.cc
|
View
|
1
|
3 chunks |
+3 lines, -5 lines |
0 comments
|
Download
|
 |
M |
components/cronet/ios/cronet_environment.cc
|
View
|
1
2
|
1 chunk |
+1 line, -2 lines |
0 comments
|
Download
|
 |
M |
content/browser/loader/resource_scheduler_unittest.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
google_apis/gcm/tools/mcs_probe.cc
|
View
|
1
2
|
1 chunk |
+1 line, -2 lines |
0 comments
|
Download
|
 |
M |
ios/chrome/browser/browser_state/chrome_browser_state_io_data.h
|
View
|
1
2
3
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
ios/chrome/browser/browser_state/chrome_browser_state_io_data.cc
|
View
|
1
2
3
|
1 chunk |
+3 lines, -3 lines |
0 comments
|
Download
|
 |
M |
ios/chrome/browser/ios_chrome_io_thread.mm
|
View
|
1
2
3
4
5
|
1 chunk |
+1 line, -2 lines |
0 comments
|
Download
|
 |
M |
ios/crnet/crnet_environment.mm
|
View
|
|
1 chunk |
+1 line, -2 lines |
0 comments
|
Download
|
 |
M |
net/http/http_network_layer_unittest.cc
|
View
|
|
1 chunk |
+1 line, -2 lines |
0 comments
|
Download
|
 |
M |
net/http/http_network_session.h
|
View
|
|
3 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
 |
M |
net/http/http_network_transaction_ssl_unittest.cc
|
View
|
|
1 chunk |
+1 line, -2 lines |
0 comments
|
Download
|
 |
M |
net/http/http_network_transaction_unittest.cc
|
View
|
1
2
3
4
5
|
25 chunks |
+35 lines, -35 lines |
0 comments
|
Download
|
 |
M |
net/http/http_response_body_drainer_unittest.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
net/http/http_server_properties.h
|
View
|
1
2
3
4
5
|
2 chunks |
+0 lines, -4 lines |
0 comments
|
Download
|
 |
M |
net/http/http_server_properties_impl.h
|
View
|
1
2
3
4
5
|
2 chunks |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
net/http/http_server_properties_impl.cc
|
View
|
1
2
3
4
5
|
1 chunk |
+0 lines, -4 lines |
0 comments
|
Download
|
 |
M |
net/http/http_server_properties_manager.h
|
View
|
1
2
3
4
5
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
 |
M |
net/http/http_server_properties_manager.cc
|
View
|
1
2
3
4
5
|
1 chunk |
+0 lines, -6 lines |
0 comments
|
Download
|
 |
M |
net/http/http_stream_factory_impl_job.cc
|
View
|
1
2
3
4
5
|
3 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
 |
M |
net/http/http_stream_factory_impl_unittest.cc
|
View
|
1
2
3
4
5
|
6 chunks |
+7 lines, -5 lines |
0 comments
|
Download
|
 |
M |
net/quic/crypto/properties_based_quic_server_info.h
|
View
|
|
3 chunks |
+5 lines, -6 lines |
0 comments
|
Download
|
 |
M |
net/quic/crypto/properties_based_quic_server_info.cc
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
net/quic/crypto/properties_based_quic_server_info_test.cc
|
View
|
|
3 chunks |
+5 lines, -5 lines |
0 comments
|
Download
|
 |
M |
net/quic/quic_end_to_end_unittest.cc
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
net/quic/quic_network_transaction_unittest.cc
|
View
|
1
2
3
4
5
|
6 chunks |
+6 lines, -4 lines |
0 comments
|
Download
|
 |
M |
net/quic/quic_stream_factory.h
|
View
|
1
2
3
4
5
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
net/quic/quic_stream_factory.cc
|
View
|
1
2
3
4
5
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
net/quic/quic_stream_factory_test.cc
|
View
|
1
2
3
4
5
|
2 chunks |
+2 lines, -3 lines |
0 comments
|
Download
|
 |
M |
net/socket/ssl_client_socket_pool_unittest.cc
|
View
|
|
3 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
 |
M |
net/spdy/spdy_network_transaction_unittest.cc
|
View
|
1
2
3
4
5
|
3 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
 |
M |
net/spdy/spdy_session.h
|
View
|
1
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
net/spdy/spdy_session.cc
|
View
|
1
2
3
4
|
1 chunk |
+13 lines, -14 lines |
0 comments
|
Download
|
 |
M |
net/spdy/spdy_session_pool.h
|
View
|
1
|
3 chunks |
+13 lines, -14 lines |
0 comments
|
Download
|
 |
M |
net/spdy/spdy_session_pool.cc
|
View
|
1
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
net/spdy/spdy_session_unittest.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
net/spdy/spdy_test_util_common.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
net/spdy/spdy_test_util_common.cc
|
View
|
1
2
|
3 chunks |
+3 lines, -2 lines |
0 comments
|
Download
|
 |
M |
net/url_request/url_request_context.h
|
View
|
|
2 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
 |
M |
net/url_request/url_request_context.cc
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
net/url_request/url_request_context_storage.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
Total messages: 24 (8 generated)
|