Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Unified Diff: net/quic/crypto/properties_based_quic_server_info.h

Issue 2041863002: Remove HttpServerProperies::GetWeakPtr(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/http/http_stream_factory_impl_unittest.cc ('k') | net/quic/crypto/properties_based_quic_server_info.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/crypto/properties_based_quic_server_info.h
diff --git a/net/quic/crypto/properties_based_quic_server_info.h b/net/quic/crypto/properties_based_quic_server_info.h
index c7189ab4810ce0da3c3d44ea1d35b4bd9a33263b..c4cea6981fa63e34d0971be702a155ad381223d9 100644
--- a/net/quic/crypto/properties_based_quic_server_info.h
+++ b/net/quic/crypto/properties_based_quic_server_info.h
@@ -23,9 +23,8 @@ class HttpServerProperties;
// it's ok for us to keep it on disk.
class NET_EXPORT_PRIVATE PropertiesBasedQuicServerInfo : public QuicServerInfo {
public:
- PropertiesBasedQuicServerInfo(
- const QuicServerId& server_id,
- base::WeakPtr<HttpServerProperties> http_server_properties);
+ PropertiesBasedQuicServerInfo(const QuicServerId& server_id,
+ HttpServerProperties* http_server_properties);
~PropertiesBasedQuicServerInfo() override;
// QuicServerInfo implementation.
@@ -39,7 +38,7 @@ class NET_EXPORT_PRIVATE PropertiesBasedQuicServerInfo : public QuicServerInfo {
void OnExternalCacheHit() override;
private:
- base::WeakPtr<HttpServerProperties> http_server_properties_;
+ HttpServerProperties* http_server_properties_;
DISALLOW_COPY_AND_ASSIGN(PropertiesBasedQuicServerInfo);
};
@@ -48,13 +47,13 @@ class NET_EXPORT_PRIVATE PropertiesBasedQuicServerInfoFactory
: public QuicServerInfoFactory {
public:
explicit PropertiesBasedQuicServerInfoFactory(
- base::WeakPtr<HttpServerProperties> http_server_properties);
+ HttpServerProperties* http_server_properties);
~PropertiesBasedQuicServerInfoFactory() override;
QuicServerInfo* GetForServer(const QuicServerId& server_id) override;
private:
- base::WeakPtr<HttpServerProperties> http_server_properties_;
+ HttpServerProperties* http_server_properties_;
DISALLOW_COPY_AND_ASSIGN(PropertiesBasedQuicServerInfoFactory);
};
« no previous file with comments | « net/http/http_stream_factory_impl_unittest.cc ('k') | net/quic/crypto/properties_based_quic_server_info.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698