components/cronet/ios/cronet_environment.cc - Issue 2041863002: Remove HttpServerProperies::GetWeakPtr().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/ios/cronet_environment.cc

Issue 2041863002: Remove HttpServerProperies::GetWeakPtr(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/cronet/ios/cronet_environment.cc

diff --git a/components/cronet/ios/cronet_environment.cc b/components/cronet/ios/cronet_environment.cc

index 96eacd2ddcd07060f72b81718ac44a1f4010f40c..3ff9faaafbe605c9b10ddd36c23cc99127db68b1 100644

--- a/components/cronet/ios/cronet_environment.cc

+++ b/components/cronet/ios/cronet_environment.cc

@@ -274,8 +274,7 @@ void CronetEnvironment::InitializeOnNetworkThread() {

main_context_->set_transport_security_state(

new net::TransportSecurityState());

http_server_properties_.reset(new net::HttpServerPropertiesImpl());

- main_context_->set_http_server_properties(

- http_server_properties_->GetWeakPtr());

+ main_context_->set_http_server_properties(http_server_properties_.get());

// TODO(rdsmith): Note that the ".release()" calls below are leaking

// the objects in question; this should be fixed by having an object