net/quic/quic_stream_factory_test.cc - Issue 2041863002: Remove HttpServerProperies::GetWeakPtr().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/quic_stream_factory_test.cc

Issue 2041863002: Remove HttpServerProperies::GetWeakPtr(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/quic/quic_stream_factory_test.cc

diff --git a/net/quic/quic_stream_factory_test.cc b/net/quic/quic_stream_factory_test.cc

index 29b9e0ed75e383c1b09da98517a9e2135dca6131..16a61b3b7c9b2dce2c7e22bb2317e708d0463235 100644

--- a/net/quic/quic_stream_factory_test.cc

+++ b/net/quic/quic_stream_factory_test.cc

@@ -312,7 +312,7 @@ class QuicStreamFactoryTestBase {

DCHECK(!factory_);

factory_.reset(new QuicStreamFactory(

net_log_.net_log(), &host_resolver_, &socket_factory_,

- http_server_properties_.GetWeakPtr(), cert_verifier_.get(), nullptr,

+ &http_server_properties_, cert_verifier_.get(), nullptr,

channel_id_service_.get(), &transport_security_state_,

cert_transparency_verifier_.get(),

/*SocketPerformanceWatcherFactory*/ nullptr,

@@ -3728,8 +3728,7 @@ TEST_P(QuicStreamFactoryTest, MaybeInitialize) {

QuicServerId quic_server_id(kDefaultServerHostName, 80,

PRIVACY_MODE_DISABLED);

QuicServerInfoFactory* quic_server_info_factory =

- new PropertiesBasedQuicServerInfoFactory(

- http_server_properties_.GetWeakPtr());

+ new PropertiesBasedQuicServerInfoFactory(&http_server_properties_);

factory_->set_quic_server_info_factory(quic_server_info_factory);

std::unique_ptr<QuicServerInfo> quic_server_info(

« no previous file with comments | « net/quic/quic_stream_factory.cc ('k') | net/socket/ssl_client_socket_pool_unittest.cc » ('j') | no next file with comments »