Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Unified Diff: net/quic/crypto/properties_based_quic_server_info_test.cc

Issue 2041863002: Remove HttpServerProperies::GetWeakPtr(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/crypto/properties_based_quic_server_info.cc ('k') | net/quic/quic_end_to_end_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/crypto/properties_based_quic_server_info_test.cc
diff --git a/net/quic/crypto/properties_based_quic_server_info_test.cc b/net/quic/crypto/properties_based_quic_server_info_test.cc
index 0cab74bc275ea3a06c72b7cce58d28fe165b6f2f..497e88ce4f467ffc0cac61cf66b2a2dff2cf93c3 100644
--- a/net/quic/crypto/properties_based_quic_server_info_test.cc
+++ b/net/quic/crypto/properties_based_quic_server_info_test.cc
@@ -28,7 +28,7 @@ class PropertiesBasedQuicServerInfoTest : public ::testing::Test {
protected:
PropertiesBasedQuicServerInfoTest()
: server_id_("www.google.com", 443, PRIVACY_MODE_DISABLED),
- server_info_(server_id_, http_server_properties_.GetWeakPtr()) {}
+ server_info_(server_id_, &http_server_properties_) {}
// Initialize |server_info_| object and persist it.
void InitializeAndPersist() {
@@ -71,8 +71,8 @@ TEST_F(PropertiesBasedQuicServerInfoTest, Update) {
InitializeAndPersist();
// Read the persisted data and verify we have read the data correctly.
- PropertiesBasedQuicServerInfo server_info1(
- server_id_, http_server_properties_.GetWeakPtr());
+ PropertiesBasedQuicServerInfo server_info1(server_id_,
+ &http_server_properties_);
server_info1.Start();
EXPECT_EQ(OK, server_info1.WaitForDataReady(callback_)); // Read the data.
EXPECT_TRUE(server_info1.IsDataReady());
@@ -89,8 +89,8 @@ TEST_F(PropertiesBasedQuicServerInfoTest, Update) {
server_info1.Persist();
// Read the persisted data and verify we have read the data correctly.
- PropertiesBasedQuicServerInfo server_info2(
- server_id_, http_server_properties_.GetWeakPtr());
+ PropertiesBasedQuicServerInfo server_info2(server_id_,
+ &http_server_properties_);
server_info2.Start();
EXPECT_EQ(OK, server_info2.WaitForDataReady(callback_)); // Read the data.
EXPECT_TRUE(server_info1.IsDataReady());
« no previous file with comments | « net/quic/crypto/properties_based_quic_server_info.cc ('k') | net/quic/quic_end_to_end_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698