Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Side by Side Diff: net/socket/ssl_client_socket_pool_unittest.cc

Issue 2041863002: Remove HttpServerProperies::GetWeakPtr(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/quic/quic_stream_factory_test.cc ('k') | net/spdy/spdy_network_transaction_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/http/http_proxy_client_socket_pool.h" 5 #include "net/http/http_proxy_client_socket_pool.h"
6 6
7 #include "base/callback.h" 7 #include "base/callback.h"
8 #include "base/compiler_specific.h" 8 #include "base/compiler_specific.h"
9 #include "base/strings/string_util.h" 9 #include "base/strings/string_util.h"
10 #include "base/strings/utf_string_conversions.h" 10 #include "base/strings/utf_string_conversions.h"
(...skipping 65 matching lines...) Expand 10 before | Expand all | Expand 10 after
76 class SSLClientSocketPoolTest 76 class SSLClientSocketPoolTest
77 : public testing::Test, 77 : public testing::Test,
78 public ::testing::WithParamInterface<NextProto> { 78 public ::testing::WithParamInterface<NextProto> {
79 protected: 79 protected:
80 SSLClientSocketPoolTest() 80 SSLClientSocketPoolTest()
81 : transport_security_state_(new TransportSecurityState), 81 : transport_security_state_(new TransportSecurityState),
82 proxy_service_(ProxyService::CreateDirect()), 82 proxy_service_(ProxyService::CreateDirect()),
83 ssl_config_service_(new SSLConfigServiceDefaults), 83 ssl_config_service_(new SSLConfigServiceDefaults),
84 http_auth_handler_factory_( 84 http_auth_handler_factory_(
85 HttpAuthHandlerFactory::CreateDefault(&host_resolver_)), 85 HttpAuthHandlerFactory::CreateDefault(&host_resolver_)),
86 http_server_properties_(new HttpServerPropertiesImpl),
86 session_(CreateNetworkSession()), 87 session_(CreateNetworkSession()),
87 direct_transport_socket_params_(new TransportSocketParams( 88 direct_transport_socket_params_(new TransportSocketParams(
88 HostPortPair("host", 443), 89 HostPortPair("host", 443),
89 false, 90 false,
90 OnHostResolutionCallback(), 91 OnHostResolutionCallback(),
91 TransportSocketParams::COMBINE_CONNECT_AND_WRITE_DEFAULT)), 92 TransportSocketParams::COMBINE_CONNECT_AND_WRITE_DEFAULT)),
92 transport_socket_pool_(kMaxSockets, 93 transport_socket_pool_(kMaxSockets,
93 kMaxSocketsPerGroup, 94 kMaxSocketsPerGroup,
94 &socket_factory_), 95 &socket_factory_),
95 proxy_transport_socket_params_(new TransportSocketParams( 96 proxy_transport_socket_params_(new TransportSocketParams(
(...skipping 63 matching lines...) Expand 10 before | Expand all | Expand 10 after
159 160
160 HttpNetworkSession* CreateNetworkSession() { 161 HttpNetworkSession* CreateNetworkSession() {
161 HttpNetworkSession::Params params; 162 HttpNetworkSession::Params params;
162 params.host_resolver = &host_resolver_; 163 params.host_resolver = &host_resolver_;
163 params.cert_verifier = cert_verifier_.get(); 164 params.cert_verifier = cert_verifier_.get();
164 params.transport_security_state = transport_security_state_.get(); 165 params.transport_security_state = transport_security_state_.get();
165 params.proxy_service = proxy_service_.get(); 166 params.proxy_service = proxy_service_.get();
166 params.client_socket_factory = &socket_factory_; 167 params.client_socket_factory = &socket_factory_;
167 params.ssl_config_service = ssl_config_service_.get(); 168 params.ssl_config_service = ssl_config_service_.get();
168 params.http_auth_handler_factory = http_auth_handler_factory_.get(); 169 params.http_auth_handler_factory = http_auth_handler_factory_.get();
169 params.http_server_properties = 170 params.http_server_properties = http_server_properties_.get();
170 http_server_properties_.GetWeakPtr();
171 params.spdy_default_protocol = GetParam(); 171 params.spdy_default_protocol = GetParam();
172 return new HttpNetworkSession(params); 172 return new HttpNetworkSession(params);
173 } 173 }
174 174
175 void TestIPPoolingDisabled(SSLSocketDataProvider* ssl); 175 void TestIPPoolingDisabled(SSLSocketDataProvider* ssl);
176 176
177 MockClientSocketFactory socket_factory_; 177 MockClientSocketFactory socket_factory_;
178 MockCachingHostResolver host_resolver_; 178 MockCachingHostResolver host_resolver_;
179 std::unique_ptr<CertVerifier> cert_verifier_; 179 std::unique_ptr<CertVerifier> cert_verifier_;
180 std::unique_ptr<TransportSecurityState> transport_security_state_; 180 std::unique_ptr<TransportSecurityState> transport_security_state_;
181 const std::unique_ptr<ProxyService> proxy_service_; 181 const std::unique_ptr<ProxyService> proxy_service_;
182 const scoped_refptr<SSLConfigService> ssl_config_service_; 182 const scoped_refptr<SSLConfigService> ssl_config_service_;
183 const std::unique_ptr<HttpAuthHandlerFactory> http_auth_handler_factory_; 183 const std::unique_ptr<HttpAuthHandlerFactory> http_auth_handler_factory_;
184 HttpServerPropertiesImpl http_server_properties_; 184 const std::unique_ptr<HttpServerPropertiesImpl> http_server_properties_;
185 const std::unique_ptr<HttpNetworkSession> session_; 185 const std::unique_ptr<HttpNetworkSession> session_;
186 186
187 scoped_refptr<TransportSocketParams> direct_transport_socket_params_; 187 scoped_refptr<TransportSocketParams> direct_transport_socket_params_;
188 MockTransportClientSocketPool transport_socket_pool_; 188 MockTransportClientSocketPool transport_socket_pool_;
189 189
190 scoped_refptr<TransportSocketParams> proxy_transport_socket_params_; 190 scoped_refptr<TransportSocketParams> proxy_transport_socket_params_;
191 191
192 scoped_refptr<SOCKSSocketParams> socks_socket_params_; 192 scoped_refptr<SOCKSSocketParams> socks_socket_params_;
193 MockSOCKSClientSocketPool socks_socket_pool_; 193 MockSOCKSClientSocketPool socks_socket_pool_;
194 194
(...skipping 736 matching lines...) Expand 10 before | Expand all | Expand 10 after
931 ssl.channel_id_sent = true; 931 ssl.channel_id_sent = true;
932 ssl.SetNextProto(GetParam()); 932 ssl.SetNextProto(GetParam());
933 TestIPPoolingDisabled(&ssl); 933 TestIPPoolingDisabled(&ssl);
934 } 934 }
935 935
936 // It would be nice to also test the timeouts in SSLClientSocketPool. 936 // It would be nice to also test the timeouts in SSLClientSocketPool.
937 937
938 } // namespace 938 } // namespace
939 939
940 } // namespace net 940 } // namespace net
OLDNEW
« no previous file with comments | « net/quic/quic_stream_factory_test.cc ('k') | net/spdy/spdy_network_transaction_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698