Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 2038613003: Revert of ExtensionFunction: don't pass ownership of base::Value by raw pointer. (Closed)

Created:
4 years, 6 months ago by dcheng
Modified:
4 years, 6 months ago
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, davemoore+watch_chromium.org, extensions-reviews_chromium.org, nona+watch_chromium.org, oshima+watch_chromium.org, rginda+watch_chromium.org, shuchen+watch_chromium.org, yusukes+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of ExtensionFunction: don't pass ownership of base::Value by raw pointer. (patchset #1 id:1 of https://codereview.chromium.org/2025103003/ ) Reason for revert: Speculatively reverting to fix release-blocking crash. Original issue's description: > ExtensionFunction: don't pass ownership of base::Value by raw pointer. > > BUG=581865 > R=rockot@chromium.org > TBR=rdevlin.cronin@chromium.org > > Committed: https://crrev.com/5a01060d89daad34fa1cd8a20a0e4fdb48976a79 > Cr-Commit-Position: refs/heads/master@{#397284} TBR=rdevlin.cronin@chromium.org,rockot@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=581865 Committed: https://crrev.com/34661418ac5f137f1dcb72194e76c117308b6c7f Cr-Commit-Position: refs/heads/master@{#397533}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -155 lines) Patch
M chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/extensions/input_method_api.cc View 7 chunks +7 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/extensions/users_private/users_private_api.cc View 9 chunks +9 lines, -19 lines 0 comments Download
M chrome/browser/extensions/api/autofill_private/autofill_private_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/automation_internal/automation_internal_api.cc View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/extensions/api/cryptotoken_private/cryptotoken_private_api.cc View 4 chunks +4 lines, -9 lines 0 comments Download
M chrome/browser/extensions/api/data_reduction_proxy/data_reduction_proxy_api.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/data_reduction_proxy/data_reduction_proxy_api.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/developer_private/developer_private_api.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/extensions/api/identity/identity_api.cc View 4 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/instance_id/instance_id_api.cc View 4 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/extensions/api/language_settings_private/language_settings_private_api.cc View 7 chunks +7 lines, -10 lines 0 comments Download
M chrome/browser/extensions/api/settings_private/settings_private_api.cc View 7 chunks +7 lines, -14 lines 0 comments Download
M chrome/browser/extensions/api/webstore_widget_private/webstore_widget_private_api.cc View 2 chunks +10 lines, -11 lines 0 comments Download
M extensions/browser/api/hid/hid_api.cc View 6 chunks +10 lines, -14 lines 0 comments Download
M extensions/browser/api/idle/idle_manager.h View 2 chunks +1 line, -3 lines 0 comments Download
M extensions/browser/api/idle/idle_manager.cc View 3 chunks +2 lines, -4 lines 0 comments Download
M extensions/browser/api/management/management_api.cc View 2 chunks +1 line, -2 lines 0 comments Download
M extensions/browser/api/runtime/runtime_api.cc View 3 chunks +5 lines, -7 lines 0 comments Download
M extensions/browser/api/storage/storage_api.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M extensions/browser/api/usb/usb_api.cc View 5 chunks +7 lines, -9 lines 0 comments Download
M extensions/browser/api/vpn_provider/vpn_provider_api.cc View 2 chunks +1 line, -2 lines 0 comments Download
M extensions/browser/extension_function.h View 2 chunks +13 lines, -8 lines 0 comments Download
M extensions/browser/extension_function.cc View 1 chunk +11 lines, -6 lines 0 comments Download
M extensions/shell/browser/api/identity/identity_api.cc View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
dcheng
Created Revert of ExtensionFunction: don't pass ownership of base::Value by raw pointer.
4 years, 6 months ago (2016-06-02 22:35:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2038613003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2038613003/1
4 years, 6 months ago (2016-06-02 22:37:04 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-02 22:38:38 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/34661418ac5f137f1dcb72194e76c117308b6c7f Cr-Commit-Position: refs/heads/master@{#397533}
4 years, 6 months ago (2016-06-02 22:42:06 UTC) #6
dcheng
4 years, 6 months ago (2016-06-03 21:17:45 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2038083004/ by dcheng@chromium.org.

The reason for reverting is: As expected, didn't stop the crashes =).

Powered by Google App Engine
This is Rietveld 408576698