Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Side by Side Diff: chrome/browser/extensions/api/automation_internal/automation_internal_api.cc

Issue 2038613003: Revert of ExtensionFunction: don't pass ownership of base::Value by raw pointer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/api/automation_internal/automation_internal_ api.h" 5 #include "chrome/browser/extensions/api/automation_internal/automation_internal_ api.h"
6 6
7 #include <stdint.h> 7 #include <stdint.h>
8 8
9 #include <vector> 9 #include <vector>
10 10
11 #include "base/macros.h" 11 #include "base/macros.h"
12 #include "base/memory/ptr_util.h"
13 #include "base/strings/string16.h" 12 #include "base/strings/string16.h"
14 #include "base/strings/string_number_conversions.h" 13 #include "base/strings/string_number_conversions.h"
15 #include "base/strings/utf_string_conversions.h" 14 #include "base/strings/utf_string_conversions.h"
16 #include "chrome/browser/extensions/api/automation_internal/automation_action_ad apter.h" 15 #include "chrome/browser/extensions/api/automation_internal/automation_action_ad apter.h"
17 #include "chrome/browser/extensions/api/automation_internal/automation_event_rou ter.h" 16 #include "chrome/browser/extensions/api/automation_internal/automation_event_rou ter.h"
18 #include "chrome/browser/extensions/api/tabs/tabs_constants.h" 17 #include "chrome/browser/extensions/api/tabs/tabs_constants.h"
19 #include "chrome/browser/extensions/extension_tab_util.h" 18 #include "chrome/browser/extensions/extension_tab_util.h"
20 #include "chrome/browser/profiles/profile.h" 19 #include "chrome/browser/profiles/profile.h"
21 #include "chrome/browser/ui/browser.h" 20 #include "chrome/browser/ui/browser.h"
22 #include "chrome/browser/ui/tabs/tab_strip_model.h" 21 #include "chrome/browser/ui/tabs/tab_strip_model.h"
(...skipping 419 matching lines...) Expand 10 before | Expand all | Expand 10 after
442 } 441 }
443 442
444 void AutomationInternalQuerySelectorFunction::OnResponse( 443 void AutomationInternalQuerySelectorFunction::OnResponse(
445 const std::string& error, 444 const std::string& error,
446 int result_acc_obj_id) { 445 int result_acc_obj_id) {
447 if (!error.empty()) { 446 if (!error.empty()) {
448 Respond(Error(error)); 447 Respond(Error(error));
449 return; 448 return;
450 } 449 }
451 450
452 Respond( 451 Respond(OneArgument(new base::FundamentalValue(result_acc_obj_id)));
453 OneArgument(base::MakeUnique<base::FundamentalValue>(result_acc_obj_id)));
454 } 452 }
455 453
456 } // namespace extensions 454 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698