chrome/browser/extensions/api/autofill_private/autofill_private_api.cc - Issue 2038613003: Revert of ExtensionFunction: don't pass ownership of base::Value by raw pointer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/autofill_private/autofill_private_api.cc

Issue 2038613003: Revert of ExtensionFunction: don't pass ownership of base::Value by raw pointer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/extensions/users_private/users_private_api.cc ('k') | chrome/browser/extensions/api/automation_internal/automation_internal_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/autofill_private/autofill_private_api.cc

diff --git a/chrome/browser/extensions/api/autofill_private/autofill_private_api.cc b/chrome/browser/extensions/api/autofill_private/autofill_private_api.cc

index a7efdf5dce4e430f3105bcc3a5e998a5190843ad..ce3ab6460e1c5437b1c33fd2769bf15154289f4e 100644

--- a/chrome/browser/extensions/api/autofill_private/autofill_private_api.cc

+++ b/chrome/browser/extensions/api/autofill_private/autofill_private_api.cc

@@ -297,7 +297,7 @@

g_browser_process->GetApplicationLocale(),

&components);

- return RespondNow(OneArgument(components.ToValue()));

+ return RespondNow(OneArgument(components.ToValue().release()));

}

////////////////////////////////////////////////////////////////////////////////