Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Side by Side Diff: chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc

Issue 2038613003: Revert of ExtensionFunction: don't pass ownership of base::Value by raw pointer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/chromeos/extensions/file_manager/private_api_file_syste m.h" 5 #include "chrome/browser/chromeos/extensions/file_manager/private_api_file_syste m.h"
6 6
7 #include <sys/statvfs.h> 7 #include <sys/statvfs.h>
8 8
9 #include <set> 9 #include <set>
10 #include <utility> 10 #include <utility>
(...skipping 927 matching lines...) Expand 10 before | Expand all | Expand 10 after
938 list->AppendString( 938 list->AppendString(
939 file_manager::util::ConvertDrivePathToFileSystemUrl( 939 file_manager::util::ConvertDrivePathToFileSystemUrl(
940 GetProfile(), hashAndPath.path, extension_id()).spec()); 940 GetProfile(), hashAndPath.path, extension_id()).spec());
941 } 941 }
942 SetResult(std::move(result)); 942 SetResult(std::move(result));
943 SendResponse(true); 943 SendResponse(true);
944 } 944 }
945 945
946 ExtensionFunction::ResponseAction 946 ExtensionFunction::ResponseAction
947 FileManagerPrivateIsUMAEnabledFunction::Run() { 947 FileManagerPrivateIsUMAEnabledFunction::Run() {
948 return RespondNow(OneArgument(base::MakeUnique<base::FundamentalValue>( 948 return RespondNow(OneArgument(new base::FundamentalValue(
949 ChromeMetricsServiceAccessor::IsMetricsAndCrashReportingEnabled()))); 949 ChromeMetricsServiceAccessor::IsMetricsAndCrashReportingEnabled())));
950 } 950 }
951 951
952 FileManagerPrivateInternalSetEntryTagFunction:: 952 FileManagerPrivateInternalSetEntryTagFunction::
953 FileManagerPrivateInternalSetEntryTagFunction() 953 FileManagerPrivateInternalSetEntryTagFunction()
954 : chrome_details_(this) {} 954 : chrome_details_(this) {}
955 955
956 ExtensionFunction::ResponseAction 956 ExtensionFunction::ResponseAction
957 FileManagerPrivateInternalSetEntryTagFunction::Run() { 957 FileManagerPrivateInternalSetEntryTagFunction::Run() {
958 using extensions::api::file_manager_private_internal::SetEntryTag::Params; 958 using extensions::api::file_manager_private_internal::SetEntryTag::Params;
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
993 return RespondLater(); 993 return RespondLater();
994 } 994 }
995 995
996 void FileManagerPrivateInternalSetEntryTagFunction::OnSetEntryPropertyCompleted( 996 void FileManagerPrivateInternalSetEntryTagFunction::OnSetEntryPropertyCompleted(
997 drive::FileError result) { 997 drive::FileError result) {
998 Respond(result == drive::FILE_ERROR_OK ? NoArguments() 998 Respond(result == drive::FILE_ERROR_OK ? NoArguments()
999 : Error("Failed to set a tag.")); 999 : Error("Failed to set a tag."));
1000 } 1000 }
1001 1001
1002 } // namespace extensions 1002 } // namespace extensions
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698