Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5370)

Unified Diff: chrome/browser/extensions/api/instance_id/instance_id_api.cc

Issue 2038613003: Revert of ExtensionFunction: don't pass ownership of base::Value by raw pointer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/instance_id/instance_id_api.cc
diff --git a/chrome/browser/extensions/api/instance_id/instance_id_api.cc b/chrome/browser/extensions/api/instance_id/instance_id_api.cc
index 3baab243e3dd3acbfe5ba5e85a1ed0f80281a963..57609b3a8538cf1a9bb2f911a4d5194ada36956d 100644
--- a/chrome/browser/extensions/api/instance_id/instance_id_api.cc
+++ b/chrome/browser/extensions/api/instance_id/instance_id_api.cc
@@ -5,7 +5,6 @@
#include "chrome/browser/extensions/api/instance_id/instance_id_api.h"
#include "base/logging.h"
-#include "base/memory/ptr_util.h"
#include "base/metrics/histogram_macros.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/services/gcm/instance_id/instance_id_profile_service.h"
@@ -95,7 +94,7 @@
}
void InstanceIDGetIDFunction::GetIDCompleted(const std::string& id) {
- Respond(OneArgument(base::MakeUnique<base::StringValue>(id)));
+ Respond(OneArgument(new base::StringValue(id)));
}
InstanceIDGetCreationTimeFunction::InstanceIDGetCreationTimeFunction() {}
@@ -111,8 +110,7 @@
void InstanceIDGetCreationTimeFunction::GetCreationTimeCompleted(
const base::Time& creation_time) {
- Respond(OneArgument(
- base::MakeUnique<base::FundamentalValue>(creation_time.ToDoubleT())));
+ Respond(OneArgument(new base::FundamentalValue(creation_time.ToDoubleT())));
}
InstanceIDGetTokenFunction::InstanceIDGetTokenFunction() {}
@@ -141,7 +139,7 @@
const std::string& token,
instance_id::InstanceID::Result result) {
if (result == instance_id::InstanceID::SUCCESS)
- Respond(OneArgument(base::MakeUnique<base::StringValue>(token)));
+ Respond(OneArgument(new base::StringValue(token)));
else
Respond(Error(InstanceIDResultToError(result)));
}

Powered by Google App Engine
This is Rietveld 408576698