Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2037593004: [DevTools] Remove unnecessary knowledge about console from core. (Closed)

Created:
4 years, 6 months ago by dgozman
Modified:
4 years, 6 months ago
Reviewers:
kozy, caseq
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Remove unnecessary knowledge about console from core. BUG=613882 Committed: https://crrev.com/dc3db9db9d183fdbe57418e5924c0486d6dd7de2 Cr-Commit-Position: refs/heads/master@{#397947}

Patch Set 1 #

Total comments: 4

Patch Set 2 : default text #

Patch Set 3 : one more test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -49 lines) Patch
M third_party/WebKit/LayoutTests/fast/dom/Window/console-trace-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/workers/worker-console-log-expected.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/sources/debugger/async-callstack-network-initiator-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/console/console-deprecated-methods.html View 2 chunks +6 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/console/console-deprecated-methods-expected.txt View 1 chunk +4 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-clear-function-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-command-clear-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-filter-test-expected.txt View 1 3 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-nested-group-expected.txt View 1 1 chunk +10 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-tests-expected.txt View 1 2 chunks +12 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-time.html View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-time-expected.txt View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-trace-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-trace-in-eval-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-async/async-callstack-in-console-expected.txt View 1 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-pause/debugger-pause-on-failed-assertion-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger/debugger-uncaught-promise-on-pause-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger/rethrow-error-from-bindings-crash-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/tracing/console-timeline.html View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/tracing/console-timeline-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/tracing/timeline-time.html View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameConsole.cpp View 2 chunks +1 line, -18 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/ScriptArguments.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8Console.cpp View 1 2 3 chunks +17 lines, -17 lines 0 comments Download

Dependent Patchsets:

Issue 2035263002 Patch 1
Issue 2035653006 Patch 40001

Messages

Total messages: 18 (8 generated)
dgozman
Could you please take a look?
4 years, 6 months ago (2016-06-03 21:09:14 UTC) #2
kozy
https://codereview.chromium.org/2037593004/diff/1/third_party/WebKit/LayoutTests/inspector/sources/debugger/rethrow-error-from-bindings-crash-expected.txt File third_party/WebKit/LayoutTests/inspector/sources/debugger/rethrow-error-from-bindings-crash-expected.txt (right): https://codereview.chromium.org/2037593004/diff/1/third_party/WebKit/LayoutTests/inspector/sources/debugger/rethrow-error-from-bindings-crash-expected.txt#newcode1 third_party/WebKit/LayoutTests/inspector/sources/debugger/rethrow-error-from-bindings-crash-expected.txt:1: CONSOLE MESSAGE: line 11: Let's add default message for ...
4 years, 6 months ago (2016-06-03 23:49:17 UTC) #3
dgozman
PTAL https://codereview.chromium.org/2037593004/diff/1/third_party/WebKit/LayoutTests/inspector/sources/debugger/rethrow-error-from-bindings-crash-expected.txt File third_party/WebKit/LayoutTests/inspector/sources/debugger/rethrow-error-from-bindings-crash-expected.txt (right): https://codereview.chromium.org/2037593004/diff/1/third_party/WebKit/LayoutTests/inspector/sources/debugger/rethrow-error-from-bindings-crash-expected.txt#newcode1 third_party/WebKit/LayoutTests/inspector/sources/debugger/rethrow-error-from-bindings-crash-expected.txt:1: CONSOLE MESSAGE: line 11: On 2016/06/03 23:49:17, kozyatinskiy ...
4 years, 6 months ago (2016-06-04 00:33:30 UTC) #4
kozy
lgtm
4 years, 6 months ago (2016-06-04 00:36:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2037593004/20001
4 years, 6 months ago (2016-06-04 00:37:01 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/239135)
4 years, 6 months ago (2016-06-04 02:17:06 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2037593004/40001
4 years, 6 months ago (2016-06-04 23:35:18 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2037593004/40001
4 years, 6 months ago (2016-06-05 14:50:51 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-06-05 20:10:38 UTC) #16
commit-bot: I haz the power
4 years, 6 months ago (2016-06-05 20:13:30 UTC) #18
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/dc3db9db9d183fdbe57418e5924c0486d6dd7de2
Cr-Commit-Position: refs/heads/master@{#397947}

Powered by Google App Engine
This is Rietveld 408576698