third_party/WebKit/LayoutTests/inspector-protocol/console/console-deprecated-methods.html - Issue 2037593004: [DevTools] Remove unnecessary knowledge about console from core.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/inspector-protocol/console/console-deprecated-methods.html

Issue 2037593004: [DevTools] Remove unnecessary knowledge about console from core. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: one more test Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/inspector/sources/debugger/async-callstack-network-initiator-expected.txt ('k') | third_party/WebKit/LayoutTests/inspector-protocol/console/console-deprecated-methods-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <html>	1 <html>

2 <head>	2 <head>

3 <script type="text/javascript" src="../../http/tests/inspector-protocol/inspecto r-protocol-test.js"></script>	3 <script type="text/javascript" src="../../http/tests/inspector-protocol/inspecto r-protocol-test.js"></script>

4 <script>	4 <script>

5	5

	6 testRunner.setDumpConsoleMessages(false);

	7

6 function test()	8 function test()

7 {	9 {

8 InspectorTest.eventHandler["Console.messageAdded"] = messageAdded;	10 InspectorTest.eventHandler["Console.messageAdded"] = messageAdded;

9 InspectorTest.sendCommand("Console.enable", {});	11 InspectorTest.sendCommand("Console.enable", {});

10	12

11 var deprecatedMethods = [	13 var deprecatedMethods = [

12 "console.timeline(\"42\")",	14 "console.timeline(\"42\")",

13 "console.timeline(\"42\")",	15 "console.timeline(\"42\")",

14 "console.timeline(\"42\")", // three calls should produce one warning me ssage	16 "console.timeline(\"42\")", // three calls should produce one warning me ssage

15 "console.timelineEnd(\"42\")",	17 "console.timelineEnd(\"42\")",

16 "console.markTimeline(\"42\")",	18 "console.markTimeline(\"42\")",

17 ];	19 ];

18 InspectorTest.sendCommand("Runtime.evaluate", { expression: deprecatedMethod s.join(";") });	20 InspectorTest.sendCommand("Runtime.evaluate", { expression: deprecatedMethod s.join(";") });

19	21

20 var messagesLeft = 3;	22 var messagesLeft = 3;

21 function messageAdded(data)	23 function messageAdded(data)

22 {	24 {

	25 var text = data.params.message.text;

	26 if (text.indexOf("deprecated") === -1)

	27 return;

	28 InspectorTest.log(text);

23 if (!--messagesLeft)	29 if (!--messagesLeft)

24 InspectorTest.completeTest();	30 InspectorTest.completeTest();

25 }	31 }

26 }	32 }

27 </script>	33 </script>

28 </head>	34 </head>

29 <body onload="runTest()">Tests checks that deprecation messages for console.</bo dy>	35 <body onload="runTest()">Tests checks that deprecation messages for console.</bo dy>

30 </html>	36 </html>

OLD	NEW