Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Unified Diff: third_party/WebKit/Source/core/frame/FrameConsole.cpp

Issue 2037593004: [DevTools] Remove unnecessary knowledge about console from core. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: one more test Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/FrameConsole.cpp
diff --git a/third_party/WebKit/Source/core/frame/FrameConsole.cpp b/third_party/WebKit/Source/core/frame/FrameConsole.cpp
index acce9bf7e8c009bad3eb3a161edf4e5fed09a9a9..2faacc352bd3ec2283b3e3c5500108362b3baeeb 100644
--- a/third_party/WebKit/Source/core/frame/FrameConsole.cpp
+++ b/third_party/WebKit/Source/core/frame/FrameConsole.cpp
@@ -41,21 +41,6 @@
namespace blink {
-static const HashSet<int>& allClientReportingMessageTypes()
-{
- DEFINE_STATIC_LOCAL(HashSet<int>, types, ());
- if (types.isEmpty()) {
- types.add(LogMessageType);
- types.add(DirMessageType);
- types.add(DirXMLMessageType);
- types.add(TableMessageType);
- types.add(TraceMessageType);
- types.add(ClearMessageType);
- types.add(AssertMessageType);
- }
- return types;
-}
-
namespace {
int muteCount = 0;
@@ -93,9 +78,7 @@ void FrameConsole::reportMessageToClient(ConsoleMessage* consoleMessage)
String url = consoleMessage->location()->url();
String stackTrace;
if (consoleMessage->source() == ConsoleAPIMessageSource) {
- if (!frame().host() || (consoleMessage->scriptArguments() && !consoleMessage->scriptArguments()->argumentCount()))
- return;
- if (!allClientReportingMessageTypes().contains(consoleMessage->type()))
+ if (!frame().host())
return;
if (frame().chromeClient().shouldReportDetailedMessageForSource(frame(), url)) {
OwnPtr<SourceLocation> location = SourceLocation::captureWithFullStackTrace();

Powered by Google App Engine
This is Rietveld 408576698