Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2035263002: Extract SourceLocation for ConsoleMessages on call sites. (Closed)

Created:
4 years, 6 months ago by dgozman
Modified:
4 years, 6 months ago
Reviewers:
CC:
chromium-reviews, eae+blinkwatch, fs, kinuko+watch, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, Yoav Weiss, krit, blink-reviews-html_chromium.org, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews-bindings_chromium.org, gavinp+loader_chromium.org, blink-reviews, gyuyoung2, rwlbuis, sof, loading-reviews_chromium.org, Nate Chapin, mkwst+watchlist-csp_chromium.org, tyoshino+watch_chromium.org, gavinp+prerender_chromium.org, f(malita), Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/src.git@2037593004
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Extract SourceLocation for ConsoleMessages on call sites. This avoids possibly wrong locations being captured by generic hack in Document. BUG=613882

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -48 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 2 chunks +2 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/core/frame/csp/CSPDirectiveList.cpp View 2 chunks +5 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/frame/csp/ContentSecurityPolicy.h View 3 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/frame/csp/ContentSecurityPolicy.cpp View 1 chunk +4 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLIFrameElement.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/forms/InputType.cpp View 2 chunks +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/parser/XSSAuditorDelegate.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/FrameFetchContext.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/FrameLoader.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/HttpEquiv.cpp View 3 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/loader/LinkLoader.cpp View 6 chunks +9 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/loader/MixedContentChecker.cpp View 4 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGDocumentExtensions.cpp View 2 chunks +2 lines, -1 line 0 comments Download

Depends on Patchset:

Issue 2037593004 Patch 40001

Messages

Total messages: 4 (2 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2035263002/1
4 years, 6 months ago (2016-06-05 04:30:14 UTC) #2
commit-bot: I haz the power
4 years, 6 months ago (2016-06-05 05:12:50 UTC) #4 
Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

Powered by Google App Engine
This is Rietveld 408576698